From: Andi Kleen <andi@firstfloor.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Andi Kleen <andi@firstfloor.org>,
mingo@kernel.org, hpa@zytor.com, linux-kernel@vger.kernel.org,
tglx@linutronix.de, linux-tip-commits@vger.kernel.org
Subject: Re: [tip:perf/core] perf/x86/intel: Clean-up/reduce PEBS code
Date: Mon, 16 Sep 2013 18:09:21 +0200 [thread overview]
Message-ID: <20130916160921.GX18242@two.firstfloor.org> (raw)
In-Reply-To: <20130916072431.GV26785@twins.programming.kicks-ass.net>
>
> /*
> * Should not happen, we program the threshold at 1 and do not
> * set a reset value.
> */
> - WARN_ONCE(n > x86_pmu.max_pebs_events,
> - "Unexpected number of pebs records %d\n", n);
> + WARN_ONCE(top - at > x86_pmu.max_pebs_events * x86_pmu.pebs_record_size,
That should work yes.
-Andi
next prev parent reply other threads:[~2013-09-16 16:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-12 18:04 [tip:perf/core] perf/x86/intel: Clean-up/reduce PEBS code tip-bot for Peter Zijlstra
2013-09-14 6:18 ` Andi Kleen
2013-09-16 6:07 ` Peter Zijlstra
2013-09-16 6:17 ` H. Peter Anvin
2013-09-16 7:24 ` Peter Zijlstra
2013-09-16 16:09 ` Andi Kleen [this message]
2013-09-16 16:03 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130916160921.GX18242@two.firstfloor.org \
--to=andi@firstfloor.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox