Re: [tip:perf/core] perf/x86/intel: Clean-up/reduce PEBS code

Andi Kleen
2013-09-16T16:03:16Z

> There already was an implicit division there, and
> sizeof(pebs_record_hsw) = 176, can it really optimize that constant
> division?

Yes it can (if nothing else then by converting it to * 1/x)

The only exception is with -Os, but if you want performance
you should not be using that anyways.

You could do that manually, but it's easiest to just keep
the code paths separate and let the compiler worry about it.

> I suppose we could go and introduce CONFIG_PERF_DEBUG and stuff sanity
> checks under that.. :/

Hmm, it's not a sanity check?

-Andi

--
ak@linux.intel.com -- Speaking for myself only.