Re: [PATCH 3/3] dma: Add Freescale eDMA engine driver support

Vinod Koul
2013-09-23T05:16:13Z

On Tue, Sep 17, 2013 at 08:08:46AM +0000, Lu Jingchang-B35083 wrote:
> > > + case DMA_PAUSE:
> > > + if (fsl_chan->edesc)
> > > + fsl_edma_disable_request(fsl_chan);
> > racy here too...
> It only set the channel HW register, no list is handled,
> is lock needed here? Thanks!
well thats the point while you are terminating the current trasnaction can
complete and then start another one. You want to try and prevent these case
also. Here you are neither locking the HW access nor the the list, so its juts
waiting to crash!

~Vinod
--