* [PATCH] dma/Kconfig: Make TI_EDMA select TI_PRIV_EDMA
@ 2013-09-04 13:32 Josh Boyer
2013-09-04 16:10 ` Josh Boyer
2013-09-05 15:19 ` Matt Porter
0 siblings, 2 replies; 4+ messages in thread
From: Josh Boyer @ 2013-09-04 13:32 UTC (permalink / raw)
To: Matt Porter; +Cc: Vinod Koul, Dan Williams, linux-kernel
The TI_EDMA driver unconditionally calls functions provided by the
TI_PRIV_EDMA code, but it doesn't force that to be built-in. If that isn't
otherwise enabled somewhere, you can get build errors like:
linux-3.12.0-0.rc0.git1.1.fc21.armv7hl/drivers/dma/edma.c:593: undefined reference to `edma_free_slot'
drivers/built-in.o: In function `edma_terminate_all':
linux-3.12.0-0.rc0.git1.1.fc21.armv7hl/drivers/dma/edma.c:169: undefined reference to `edma_stop'
drivers/built-in.o: In function `edma_execute':
linux-3.12.0-0.rc0.git1.1.fc21.armv7hl/drivers/dma/edma.c:122: undefined reference to `edma_write_slot'
linux-3.12.0-0.rc0.git1.1.fc21.armv7hl/drivers/dma/edma.c:149: undefined reference to `edma_link'
linux-3.12.0-0.rc0.git1.1.fc21.armv7hl/drivers/dma/edma.c:152: undefined reference to `edma_start'
Make TI_EDMA select TI_PRIV_EDMA to avoid this.
Signed-off-by: Josh Boyer <jwboyer@fedoraproject.org>
---
drivers/dma/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
index daa4da2..825374b 100644
--- a/drivers/dma/Kconfig
+++ b/drivers/dma/Kconfig
@@ -198,6 +198,7 @@ config TI_EDMA
depends on ARCH_DAVINCI || ARCH_OMAP
select DMA_ENGINE
select DMA_VIRTUAL_CHANNELS
+ select TI_PRIV_EDMA
default n
help
Enable support for the TI EDMA controller. This DMA
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] dma/Kconfig: Make TI_EDMA select TI_PRIV_EDMA
2013-09-04 13:32 [PATCH] dma/Kconfig: Make TI_EDMA select TI_PRIV_EDMA Josh Boyer
@ 2013-09-04 16:10 ` Josh Boyer
2013-09-17 4:56 ` Vinod Koul
2013-09-05 15:19 ` Matt Porter
1 sibling, 1 reply; 4+ messages in thread
From: Josh Boyer @ 2013-09-04 16:10 UTC (permalink / raw)
To: Matt Porter; +Cc: Vinod Koul, Dan Williams, linux-kernel
On Wed, Sep 04, 2013 at 09:32:03AM -0400, Josh Boyer wrote:
> The TI_EDMA driver unconditionally calls functions provided by the
> TI_PRIV_EDMA code, but it doesn't force that to be built-in. If that isn't
> otherwise enabled somewhere, you can get build errors like:
>
> linux-3.12.0-0.rc0.git1.1.fc21.armv7hl/drivers/dma/edma.c:593: undefined reference to `edma_free_slot'
> drivers/built-in.o: In function `edma_terminate_all':
> linux-3.12.0-0.rc0.git1.1.fc21.armv7hl/drivers/dma/edma.c:169: undefined reference to `edma_stop'
> drivers/built-in.o: In function `edma_execute':
> linux-3.12.0-0.rc0.git1.1.fc21.armv7hl/drivers/dma/edma.c:122: undefined reference to `edma_write_slot'
> linux-3.12.0-0.rc0.git1.1.fc21.armv7hl/drivers/dma/edma.c:149: undefined reference to `edma_link'
> linux-3.12.0-0.rc0.git1.1.fc21.armv7hl/drivers/dma/edma.c:152: undefined reference to `edma_start'
>
> Make TI_EDMA select TI_PRIV_EDMA to avoid this.
>
> Signed-off-by: Josh Boyer <jwboyer@fedoraproject.org>
Just replying to Matt's new email address as the TI one bounced when I
originally sent this.
> ---
> drivers/dma/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
> index daa4da2..825374b 100644
> --- a/drivers/dma/Kconfig
> +++ b/drivers/dma/Kconfig
> @@ -198,6 +198,7 @@ config TI_EDMA
> depends on ARCH_DAVINCI || ARCH_OMAP
> select DMA_ENGINE
> select DMA_VIRTUAL_CHANNELS
> + select TI_PRIV_EDMA
> default n
> help
> Enable support for the TI EDMA controller. This DMA
> --
> 1.8.3.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dma/Kconfig: Make TI_EDMA select TI_PRIV_EDMA
2013-09-04 16:10 ` Josh Boyer
@ 2013-09-17 4:56 ` Vinod Koul
0 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2013-09-17 4:56 UTC (permalink / raw)
To: Josh Boyer; +Cc: Matt Porter, Dan Williams, linux-kernel
On Wed, Sep 04, 2013 at 12:10:45PM -0400, Josh Boyer wrote:
> On Wed, Sep 04, 2013 at 09:32:03AM -0400, Josh Boyer wrote:
> > The TI_EDMA driver unconditionally calls functions provided by the
> > TI_PRIV_EDMA code, but it doesn't force that to be built-in. If that isn't
> > otherwise enabled somewhere, you can get build errors like:
> >
> > linux-3.12.0-0.rc0.git1.1.fc21.armv7hl/drivers/dma/edma.c:593: undefined reference to `edma_free_slot'
> > drivers/built-in.o: In function `edma_terminate_all':
> > linux-3.12.0-0.rc0.git1.1.fc21.armv7hl/drivers/dma/edma.c:169: undefined reference to `edma_stop'
> > drivers/built-in.o: In function `edma_execute':
> > linux-3.12.0-0.rc0.git1.1.fc21.armv7hl/drivers/dma/edma.c:122: undefined reference to `edma_write_slot'
> > linux-3.12.0-0.rc0.git1.1.fc21.armv7hl/drivers/dma/edma.c:149: undefined reference to `edma_link'
> > linux-3.12.0-0.rc0.git1.1.fc21.armv7hl/drivers/dma/edma.c:152: undefined reference to `edma_start'
> >
> > Make TI_EDMA select TI_PRIV_EDMA to avoid this.
> >
> > Signed-off-by: Josh Boyer <jwboyer@fedoraproject.org>
Applied, thanks
~Vinod
>
> Just replying to Matt's new email address as the TI one bounced when I
> originally sent this.
>
> > ---
> > drivers/dma/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
> > index daa4da2..825374b 100644
> > --- a/drivers/dma/Kconfig
> > +++ b/drivers/dma/Kconfig
> > @@ -198,6 +198,7 @@ config TI_EDMA
> > depends on ARCH_DAVINCI || ARCH_OMAP
> > select DMA_ENGINE
> > select DMA_VIRTUAL_CHANNELS
> > + select TI_PRIV_EDMA
> > default n
> > help
> > Enable support for the TI EDMA controller. This DMA
> > --
> > 1.8.3.1
> >
--
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dma/Kconfig: Make TI_EDMA select TI_PRIV_EDMA
2013-09-04 13:32 [PATCH] dma/Kconfig: Make TI_EDMA select TI_PRIV_EDMA Josh Boyer
2013-09-04 16:10 ` Josh Boyer
@ 2013-09-05 15:19 ` Matt Porter
1 sibling, 0 replies; 4+ messages in thread
From: Matt Porter @ 2013-09-05 15:19 UTC (permalink / raw)
To: Josh Boyer; +Cc: Vinod Koul, Dan Williams, linux-kernel
On 09/04/2013 09:32 AM, Josh Boyer wrote:
> The TI_EDMA driver unconditionally calls functions provided by the
> TI_PRIV_EDMA code, but it doesn't force that to be built-in. If that isn't
> otherwise enabled somewhere, you can get build errors like:
>
> linux-3.12.0-0.rc0.git1.1.fc21.armv7hl/drivers/dma/edma.c:593: undefined reference to `edma_free_slot'
> drivers/built-in.o: In function `edma_terminate_all':
> linux-3.12.0-0.rc0.git1.1.fc21.armv7hl/drivers/dma/edma.c:169: undefined reference to `edma_stop'
> drivers/built-in.o: In function `edma_execute':
> linux-3.12.0-0.rc0.git1.1.fc21.armv7hl/drivers/dma/edma.c:122: undefined reference to `edma_write_slot'
> linux-3.12.0-0.rc0.git1.1.fc21.armv7hl/drivers/dma/edma.c:149: undefined reference to `edma_link'
> linux-3.12.0-0.rc0.git1.1.fc21.armv7hl/drivers/dma/edma.c:152: undefined reference to `edma_start'
>
> Make TI_EDMA select TI_PRIV_EDMA to avoid this.
>
> Signed-off-by: Josh Boyer <jwboyer@fedoraproject.org>
> ---
> drivers/dma/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
> index daa4da2..825374b 100644
> --- a/drivers/dma/Kconfig
> +++ b/drivers/dma/Kconfig
> @@ -198,6 +198,7 @@ config TI_EDMA
> depends on ARCH_DAVINCI || ARCH_OMAP
> select DMA_ENGINE
> select DMA_VIRTUAL_CHANNELS
> + select TI_PRIV_EDMA
> default n
> help
> Enable support for the TI EDMA controller. This DMA
>
Looks good, thanks for addressing this.
Acked-by: Matt Porter <matt.porter@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-09-17 5:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-04 13:32 [PATCH] dma/Kconfig: Make TI_EDMA select TI_PRIV_EDMA Josh Boyer
2013-09-04 16:10 ` Josh Boyer
2013-09-17 4:56 ` Vinod Koul
2013-09-05 15:19 ` Matt Porter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox