From: Lee Jones <lee.jones@linaro.org>
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: sameo@linux.intel.com, patches@opensource.wolfsonmicro.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: arizona: Update volatile registers for WM5110 DSP
Date: Tue, 17 Sep 2013 08:24:25 +0100 [thread overview]
Message-ID: <20130917072425.GP16984@lee--X1> (raw)
In-Reply-To: <1379345514-2998-1-git-send-email-ckeepax@opensource.wolfsonmicro.com>
On Mon, 16 Sep 2013, Charles Keepax wrote:
Any chance of a little more information in the commit message?
What are scratch registers and why are they required now where they
weren't before? Why are the control and clocking regulators no longer
needed?
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> ---
> drivers/mfd/wm5110-tables.c | 18 ++++++++++++++++--
> 1 files changed, 16 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mfd/wm5110-tables.c b/drivers/mfd/wm5110-tables.c
> index 2a79723..92c6ea6 100644
> --- a/drivers/mfd/wm5110-tables.c
> +++ b/drivers/mfd/wm5110-tables.c
> @@ -2334,20 +2334,34 @@ static bool wm5110_volatile_register(struct device *dev, unsigned int reg)
> case ARIZONA_AOD_IRQ2:
> case ARIZONA_ASRC_STATUS:
> case ARIZONA_DSP_STATUS:
> - case ARIZONA_DSP1_CONTROL_1:
> - case ARIZONA_DSP1_CLOCKING_1:
> case ARIZONA_DSP1_STATUS_1:
> case ARIZONA_DSP1_STATUS_2:
> case ARIZONA_DSP1_STATUS_3:
> + case ARIZONA_DSP1_SCRATCH_0:
> + case ARIZONA_DSP1_SCRATCH_1:
> + case ARIZONA_DSP1_SCRATCH_2:
> + case ARIZONA_DSP1_SCRATCH_3:
> case ARIZONA_DSP2_STATUS_1:
> case ARIZONA_DSP2_STATUS_2:
> case ARIZONA_DSP2_STATUS_3:
> + case ARIZONA_DSP2_SCRATCH_0:
> + case ARIZONA_DSP2_SCRATCH_1:
> + case ARIZONA_DSP2_SCRATCH_2:
> + case ARIZONA_DSP2_SCRATCH_3:
> case ARIZONA_DSP3_STATUS_1:
> case ARIZONA_DSP3_STATUS_2:
> case ARIZONA_DSP3_STATUS_3:
> + case ARIZONA_DSP3_SCRATCH_0:
> + case ARIZONA_DSP3_SCRATCH_1:
> + case ARIZONA_DSP3_SCRATCH_2:
> + case ARIZONA_DSP3_SCRATCH_3:
> case ARIZONA_DSP4_STATUS_1:
> case ARIZONA_DSP4_STATUS_2:
> case ARIZONA_DSP4_STATUS_3:
> + case ARIZONA_DSP4_SCRATCH_0:
> + case ARIZONA_DSP4_SCRATCH_1:
> + case ARIZONA_DSP4_SCRATCH_2:
> + case ARIZONA_DSP4_SCRATCH_3:
> return true;
> default:
> return false;
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2013-09-17 7:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-16 15:31 [PATCH] mfd: arizona: Update volatile registers for WM5110 DSP Charles Keepax
2013-09-17 7:24 ` Lee Jones [this message]
2013-09-17 9:18 ` Charles Keepax
2013-09-17 9:54 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130917072425.GP16984@lee--X1 \
--to=lee.jones@linaro.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox