* [PATCH] Staging: bcm: PHSModule.c: Matching the function definition with function declaration
@ 2013-09-17 7:12 Shalin Mehta
2013-09-17 7:58 ` Dan Carpenter
2013-09-17 8:35 ` Julia Lawall
0 siblings, 2 replies; 5+ messages in thread
From: Shalin Mehta @ 2013-09-17 7:12 UTC (permalink / raw)
To: gregkh, klmckinney1, devel; +Cc: shalinmehta85, kernel-janitors, linux-kernel
From: Shalin Mehta <shalinmehta85@gmail.com>
NOTE: Sending it again. I got mail delivery failure due to typo in emai ID gregkh@linuxfoundation.org
The function implementations of the PHSModule didn't match with the declaration. The functions are static
in the declaration but in the implemntation they are non-static
Signed-off-by: Shalin Mehta <shalinmehta85@gmail.com>
---
drivers/staging/bcm/PHSModule.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/bcm/PHSModule.c b/drivers/staging/bcm/PHSModule.c
index af5d22f..56c5bee 100644
--- a/drivers/staging/bcm/PHSModule.c
+++ b/drivers/staging/bcm/PHSModule.c
@@ -596,7 +596,7 @@ ULONG PhsDeleteSFRules(IN void *pvContext, IN B_UINT16 uiVcid)
* 0 if successful,
* >0 Error.
*/
-ULONG PhsCompress(IN void *pvContext,
+static ULONG PhsCompress(IN void *pvContext,
IN B_UINT16 uiVcid,
IN B_UINT16 uiClsId,
IN void *pvInputBuffer,
@@ -677,7 +677,7 @@ ULONG PhsCompress(IN void *pvContext,
* 0 if successful,
* >0 Error.
*/
-ULONG PhsDeCompress(IN void *pvContext,
+static ULONG PhsDeCompress(IN void *pvContext,
IN B_UINT16 uiVcid,
IN void *pvInputBuffer,
OUT void *pvOutputBuffer,
@@ -829,7 +829,7 @@ UINT GetServiceFlowEntry(IN struct bcm_phs_table *psServiceFlowTable,
return PHS_INVALID_TABLE_INDEX;
}
-UINT GetClassifierEntry(IN struct bcm_phs_classifier_table *pstClassifierTable,
+static UINT GetClassifierEntry(IN struct bcm_phs_classifier_table *pstClassifierTable,
IN B_UINT32 uiClsid, enum bcm_phs_classifier_context eClsContext,
OUT struct bcm_phs_classifier_entry **ppstClassifierEntry)
{
@@ -880,7 +880,7 @@ static UINT GetPhsRuleEntry(IN struct bcm_phs_classifier_table *pstClassifierTab
return PHS_INVALID_TABLE_INDEX;
}
-UINT CreateSFToClassifierRuleMapping(IN B_UINT16 uiVcid, IN B_UINT16 uiClsId,
+static UINT CreateSFToClassifierRuleMapping(IN B_UINT16 uiVcid, IN B_UINT16 uiClsId,
IN struct bcm_phs_table *psServiceFlowTable,
struct bcm_phs_rule *psPhsRule,
B_UINT8 u8AssociatedPHSI)
@@ -913,7 +913,7 @@ UINT CreateSFToClassifierRuleMapping(IN B_UINT16 uiVcid, IN B_UINT16 uiClsId,
return uiStatus;
}
-UINT CreateClassiferToPHSRuleMapping(IN B_UINT16 uiVcid,
+static UINT CreateClassiferToPHSRuleMapping(IN B_UINT16 uiVcid,
IN B_UINT16 uiClsId,
IN struct bcm_phs_entry *pstServiceFlowEntry,
struct bcm_phs_rule *psPhsRule,
@@ -1239,7 +1239,7 @@ void DumpPhsRules(struct bcm_phs_extension *pDeviceExtension)
* header.
* 0 -If PHS rule is NULL.If PHSI is 0 indicateing packet as uncompressed.
*/
-int phs_decompress(unsigned char *in_buf,
+static int phs_decompress(unsigned char *in_buf,
unsigned char *out_buf,
struct bcm_phs_rule *decomp_phs_rules,
UINT *header_size)
--
1.8.1.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] Staging: bcm: PHSModule.c: Matching the function definition with function declaration
2013-09-17 7:12 [PATCH] Staging: bcm: PHSModule.c: Matching the function definition with function declaration Shalin Mehta
@ 2013-09-17 7:58 ` Dan Carpenter
2013-09-17 8:35 ` Julia Lawall
1 sibling, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2013-09-17 7:58 UTC (permalink / raw)
To: Shalin Mehta; +Cc: gregkh, klmckinney1, devel, kernel-janitors, linux-kernel
On Tue, Sep 17, 2013 at 12:12:42AM -0700, Shalin Mehta wrote:
> From: Shalin Mehta <shalinmehta85@gmail.com>
>
> NOTE: Sending it again. I got mail delivery failure due to typo in emai ID gregkh@linuxfoundation.org
>
Put these comments that don't belong in the changelog under the ---
cut off line with the diffstat.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Staging: bcm: PHSModule.c: Matching the function definition with function declaration
2013-09-17 7:12 [PATCH] Staging: bcm: PHSModule.c: Matching the function definition with function declaration Shalin Mehta
2013-09-17 7:58 ` Dan Carpenter
@ 2013-09-17 8:35 ` Julia Lawall
1 sibling, 0 replies; 5+ messages in thread
From: Julia Lawall @ 2013-09-17 8:35 UTC (permalink / raw)
To: Shalin Mehta; +Cc: gregkh, klmckinney1, devel, kernel-janitors, linux-kernel
On Tue, 17 Sep 2013, Shalin Mehta wrote:
> From: Shalin Mehta <shalinmehta85@gmail.com>
>
> NOTE: Sending it again. I got mail delivery failure due to typo in emai ID gregkh@linuxfoundation.org
I think that such a comment should go below the ---, since it doesn't have
to be preserved in git.
julia
>
>
> The function implementations of the PHSModule didn't match with the declaration. The functions are static
> in the declaration but in the implemntation they are non-static
>
> Signed-off-by: Shalin Mehta <shalinmehta85@gmail.com>
> ---
> drivers/staging/bcm/PHSModule.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/bcm/PHSModule.c b/drivers/staging/bcm/PHSModule.c
> index af5d22f..56c5bee 100644
> --- a/drivers/staging/bcm/PHSModule.c
> +++ b/drivers/staging/bcm/PHSModule.c
> @@ -596,7 +596,7 @@ ULONG PhsDeleteSFRules(IN void *pvContext, IN B_UINT16 uiVcid)
> * 0 if successful,
> * >0 Error.
> */
> -ULONG PhsCompress(IN void *pvContext,
> +static ULONG PhsCompress(IN void *pvContext,
> IN B_UINT16 uiVcid,
> IN B_UINT16 uiClsId,
> IN void *pvInputBuffer,
> @@ -677,7 +677,7 @@ ULONG PhsCompress(IN void *pvContext,
> * 0 if successful,
> * >0 Error.
> */
> -ULONG PhsDeCompress(IN void *pvContext,
> +static ULONG PhsDeCompress(IN void *pvContext,
> IN B_UINT16 uiVcid,
> IN void *pvInputBuffer,
> OUT void *pvOutputBuffer,
> @@ -829,7 +829,7 @@ UINT GetServiceFlowEntry(IN struct bcm_phs_table *psServiceFlowTable,
> return PHS_INVALID_TABLE_INDEX;
> }
>
> -UINT GetClassifierEntry(IN struct bcm_phs_classifier_table *pstClassifierTable,
> +static UINT GetClassifierEntry(IN struct bcm_phs_classifier_table *pstClassifierTable,
> IN B_UINT32 uiClsid, enum bcm_phs_classifier_context eClsContext,
> OUT struct bcm_phs_classifier_entry **ppstClassifierEntry)
> {
> @@ -880,7 +880,7 @@ static UINT GetPhsRuleEntry(IN struct bcm_phs_classifier_table *pstClassifierTab
> return PHS_INVALID_TABLE_INDEX;
> }
>
> -UINT CreateSFToClassifierRuleMapping(IN B_UINT16 uiVcid, IN B_UINT16 uiClsId,
> +static UINT CreateSFToClassifierRuleMapping(IN B_UINT16 uiVcid, IN B_UINT16 uiClsId,
> IN struct bcm_phs_table *psServiceFlowTable,
> struct bcm_phs_rule *psPhsRule,
> B_UINT8 u8AssociatedPHSI)
> @@ -913,7 +913,7 @@ UINT CreateSFToClassifierRuleMapping(IN B_UINT16 uiVcid, IN B_UINT16 uiClsId,
> return uiStatus;
> }
>
> -UINT CreateClassiferToPHSRuleMapping(IN B_UINT16 uiVcid,
> +static UINT CreateClassiferToPHSRuleMapping(IN B_UINT16 uiVcid,
> IN B_UINT16 uiClsId,
> IN struct bcm_phs_entry *pstServiceFlowEntry,
> struct bcm_phs_rule *psPhsRule,
> @@ -1239,7 +1239,7 @@ void DumpPhsRules(struct bcm_phs_extension *pDeviceExtension)
> * header.
> * 0 -If PHS rule is NULL.If PHSI is 0 indicateing packet as uncompressed.
> */
> -int phs_decompress(unsigned char *in_buf,
> +static int phs_decompress(unsigned char *in_buf,
> unsigned char *out_buf,
> struct bcm_phs_rule *decomp_phs_rules,
> UINT *header_size)
> --
> 1.8.1.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] Staging: bcm: PHSModule.c: Matching the function definition with function declaration
@ 2013-09-17 7:42 Shalin Mehta
0 siblings, 0 replies; 5+ messages in thread
From: Shalin Mehta @ 2013-09-17 7:42 UTC (permalink / raw)
To: gregkh, klmckinney1, devel; +Cc: shalinmehta85, kernel-janitors, linux-kernel
From: Shalin Mehta <shalinmehta85@gmail.com>
The function implementations of the PHSModule didn't match with the declaration. The functions are static
in the declaration but in the implemntation they are non-static
Signed-off-by: Shalin Mehta <shalinmehta85@gmail.com>
---
NOTE: Submitting the same patch again. Added NOTE at wrong location the previous submission
drivers/staging/bcm/PHSModule.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/bcm/PHSModule.c b/drivers/staging/bcm/PHSModule.c
index af5d22f..56c5bee 100644
--- a/drivers/staging/bcm/PHSModule.c
+++ b/drivers/staging/bcm/PHSModule.c
@@ -596,7 +596,7 @@ ULONG PhsDeleteSFRules(IN void *pvContext, IN B_UINT16 uiVcid)
* 0 if successful,
* >0 Error.
*/
-ULONG PhsCompress(IN void *pvContext,
+static ULONG PhsCompress(IN void *pvContext,
IN B_UINT16 uiVcid,
IN B_UINT16 uiClsId,
IN void *pvInputBuffer,
@@ -677,7 +677,7 @@ ULONG PhsCompress(IN void *pvContext,
* 0 if successful,
* >0 Error.
*/
-ULONG PhsDeCompress(IN void *pvContext,
+static ULONG PhsDeCompress(IN void *pvContext,
IN B_UINT16 uiVcid,
IN void *pvInputBuffer,
OUT void *pvOutputBuffer,
@@ -829,7 +829,7 @@ UINT GetServiceFlowEntry(IN struct bcm_phs_table *psServiceFlowTable,
return PHS_INVALID_TABLE_INDEX;
}
-UINT GetClassifierEntry(IN struct bcm_phs_classifier_table *pstClassifierTable,
+static UINT GetClassifierEntry(IN struct bcm_phs_classifier_table *pstClassifierTable,
IN B_UINT32 uiClsid, enum bcm_phs_classifier_context eClsContext,
OUT struct bcm_phs_classifier_entry **ppstClassifierEntry)
{
@@ -880,7 +880,7 @@ static UINT GetPhsRuleEntry(IN struct bcm_phs_classifier_table *pstClassifierTab
return PHS_INVALID_TABLE_INDEX;
}
-UINT CreateSFToClassifierRuleMapping(IN B_UINT16 uiVcid, IN B_UINT16 uiClsId,
+static UINT CreateSFToClassifierRuleMapping(IN B_UINT16 uiVcid, IN B_UINT16 uiClsId,
IN struct bcm_phs_table *psServiceFlowTable,
struct bcm_phs_rule *psPhsRule,
B_UINT8 u8AssociatedPHSI)
@@ -913,7 +913,7 @@ UINT CreateSFToClassifierRuleMapping(IN B_UINT16 uiVcid, IN B_UINT16 uiClsId,
return uiStatus;
}
-UINT CreateClassiferToPHSRuleMapping(IN B_UINT16 uiVcid,
+static UINT CreateClassiferToPHSRuleMapping(IN B_UINT16 uiVcid,
IN B_UINT16 uiClsId,
IN struct bcm_phs_entry *pstServiceFlowEntry,
struct bcm_phs_rule *psPhsRule,
@@ -1239,7 +1239,7 @@ void DumpPhsRules(struct bcm_phs_extension *pDeviceExtension)
* header.
* 0 -If PHS rule is NULL.If PHSI is 0 indicateing packet as uncompressed.
*/
-int phs_decompress(unsigned char *in_buf,
+static int phs_decompress(unsigned char *in_buf,
unsigned char *out_buf,
struct bcm_phs_rule *decomp_phs_rules,
UINT *header_size)
--
1.8.1.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH] Staging: bcm: PHSModule.c: Matching the function definition with function declaration
@ 2013-09-17 7:04 Shalin Mehta
0 siblings, 0 replies; 5+ messages in thread
From: Shalin Mehta @ 2013-09-17 7:04 UTC (permalink / raw)
To: gregkh, klmckinney1, devel; +Cc: shalinmehta85, kernel-janitors, linux-kernel
From: Shalin Mehta <shalinmehta85@gmail.com>
The function implementations of the PHSModule didn't match with the declaration. The functions are static
in the declaration but in the implemntation they are non-static
Signed-off-by: Shalin Mehta <shalinmehta85@gmail.com>
---
drivers/staging/bcm/PHSModule.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/bcm/PHSModule.c b/drivers/staging/bcm/PHSModule.c
index af5d22f..56c5bee 100644
--- a/drivers/staging/bcm/PHSModule.c
+++ b/drivers/staging/bcm/PHSModule.c
@@ -596,7 +596,7 @@ ULONG PhsDeleteSFRules(IN void *pvContext, IN B_UINT16 uiVcid)
* 0 if successful,
* >0 Error.
*/
-ULONG PhsCompress(IN void *pvContext,
+static ULONG PhsCompress(IN void *pvContext,
IN B_UINT16 uiVcid,
IN B_UINT16 uiClsId,
IN void *pvInputBuffer,
@@ -677,7 +677,7 @@ ULONG PhsCompress(IN void *pvContext,
* 0 if successful,
* >0 Error.
*/
-ULONG PhsDeCompress(IN void *pvContext,
+static ULONG PhsDeCompress(IN void *pvContext,
IN B_UINT16 uiVcid,
IN void *pvInputBuffer,
OUT void *pvOutputBuffer,
@@ -829,7 +829,7 @@ UINT GetServiceFlowEntry(IN struct bcm_phs_table *psServiceFlowTable,
return PHS_INVALID_TABLE_INDEX;
}
-UINT GetClassifierEntry(IN struct bcm_phs_classifier_table *pstClassifierTable,
+static UINT GetClassifierEntry(IN struct bcm_phs_classifier_table *pstClassifierTable,
IN B_UINT32 uiClsid, enum bcm_phs_classifier_context eClsContext,
OUT struct bcm_phs_classifier_entry **ppstClassifierEntry)
{
@@ -880,7 +880,7 @@ static UINT GetPhsRuleEntry(IN struct bcm_phs_classifier_table *pstClassifierTab
return PHS_INVALID_TABLE_INDEX;
}
-UINT CreateSFToClassifierRuleMapping(IN B_UINT16 uiVcid, IN B_UINT16 uiClsId,
+static UINT CreateSFToClassifierRuleMapping(IN B_UINT16 uiVcid, IN B_UINT16 uiClsId,
IN struct bcm_phs_table *psServiceFlowTable,
struct bcm_phs_rule *psPhsRule,
B_UINT8 u8AssociatedPHSI)
@@ -913,7 +913,7 @@ UINT CreateSFToClassifierRuleMapping(IN B_UINT16 uiVcid, IN B_UINT16 uiClsId,
return uiStatus;
}
-UINT CreateClassiferToPHSRuleMapping(IN B_UINT16 uiVcid,
+static UINT CreateClassiferToPHSRuleMapping(IN B_UINT16 uiVcid,
IN B_UINT16 uiClsId,
IN struct bcm_phs_entry *pstServiceFlowEntry,
struct bcm_phs_rule *psPhsRule,
@@ -1239,7 +1239,7 @@ void DumpPhsRules(struct bcm_phs_extension *pDeviceExtension)
* header.
* 0 -If PHS rule is NULL.If PHSI is 0 indicateing packet as uncompressed.
*/
-int phs_decompress(unsigned char *in_buf,
+static int phs_decompress(unsigned char *in_buf,
unsigned char *out_buf,
struct bcm_phs_rule *decomp_phs_rules,
UINT *header_size)
--
1.8.1.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-09-18 4:57 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-17 7:12 [PATCH] Staging: bcm: PHSModule.c: Matching the function definition with function declaration Shalin Mehta
2013-09-17 7:58 ` Dan Carpenter
2013-09-17 8:35 ` Julia Lawall
-- strict thread matches above, loose matches on Subject: below --
2013-09-17 7:42 Shalin Mehta
2013-09-17 7:04 Shalin Mehta
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox