* [PATCH] mfd: arizona: Update volatile registers for WM5110 DSP
@ 2013-09-16 15:31 Charles Keepax
2013-09-17 7:24 ` Lee Jones
0 siblings, 1 reply; 4+ messages in thread
From: Charles Keepax @ 2013-09-16 15:31 UTC (permalink / raw)
To: sameo, lee.jones; +Cc: patches, linux-kernel, Charles Keepax
Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
---
drivers/mfd/wm5110-tables.c | 18 ++++++++++++++++--
1 files changed, 16 insertions(+), 2 deletions(-)
diff --git a/drivers/mfd/wm5110-tables.c b/drivers/mfd/wm5110-tables.c
index 2a79723..92c6ea6 100644
--- a/drivers/mfd/wm5110-tables.c
+++ b/drivers/mfd/wm5110-tables.c
@@ -2334,20 +2334,34 @@ static bool wm5110_volatile_register(struct device *dev, unsigned int reg)
case ARIZONA_AOD_IRQ2:
case ARIZONA_ASRC_STATUS:
case ARIZONA_DSP_STATUS:
- case ARIZONA_DSP1_CONTROL_1:
- case ARIZONA_DSP1_CLOCKING_1:
case ARIZONA_DSP1_STATUS_1:
case ARIZONA_DSP1_STATUS_2:
case ARIZONA_DSP1_STATUS_3:
+ case ARIZONA_DSP1_SCRATCH_0:
+ case ARIZONA_DSP1_SCRATCH_1:
+ case ARIZONA_DSP1_SCRATCH_2:
+ case ARIZONA_DSP1_SCRATCH_3:
case ARIZONA_DSP2_STATUS_1:
case ARIZONA_DSP2_STATUS_2:
case ARIZONA_DSP2_STATUS_3:
+ case ARIZONA_DSP2_SCRATCH_0:
+ case ARIZONA_DSP2_SCRATCH_1:
+ case ARIZONA_DSP2_SCRATCH_2:
+ case ARIZONA_DSP2_SCRATCH_3:
case ARIZONA_DSP3_STATUS_1:
case ARIZONA_DSP3_STATUS_2:
case ARIZONA_DSP3_STATUS_3:
+ case ARIZONA_DSP3_SCRATCH_0:
+ case ARIZONA_DSP3_SCRATCH_1:
+ case ARIZONA_DSP3_SCRATCH_2:
+ case ARIZONA_DSP3_SCRATCH_3:
case ARIZONA_DSP4_STATUS_1:
case ARIZONA_DSP4_STATUS_2:
case ARIZONA_DSP4_STATUS_3:
+ case ARIZONA_DSP4_SCRATCH_0:
+ case ARIZONA_DSP4_SCRATCH_1:
+ case ARIZONA_DSP4_SCRATCH_2:
+ case ARIZONA_DSP4_SCRATCH_3:
return true;
default:
return false;
--
1.7.2.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] mfd: arizona: Update volatile registers for WM5110 DSP
2013-09-16 15:31 [PATCH] mfd: arizona: Update volatile registers for WM5110 DSP Charles Keepax
@ 2013-09-17 7:24 ` Lee Jones
2013-09-17 9:18 ` Charles Keepax
0 siblings, 1 reply; 4+ messages in thread
From: Lee Jones @ 2013-09-17 7:24 UTC (permalink / raw)
To: Charles Keepax; +Cc: sameo, patches, linux-kernel
On Mon, 16 Sep 2013, Charles Keepax wrote:
Any chance of a little more information in the commit message?
What are scratch registers and why are they required now where they
weren't before? Why are the control and clocking regulators no longer
needed?
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> ---
> drivers/mfd/wm5110-tables.c | 18 ++++++++++++++++--
> 1 files changed, 16 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mfd/wm5110-tables.c b/drivers/mfd/wm5110-tables.c
> index 2a79723..92c6ea6 100644
> --- a/drivers/mfd/wm5110-tables.c
> +++ b/drivers/mfd/wm5110-tables.c
> @@ -2334,20 +2334,34 @@ static bool wm5110_volatile_register(struct device *dev, unsigned int reg)
> case ARIZONA_AOD_IRQ2:
> case ARIZONA_ASRC_STATUS:
> case ARIZONA_DSP_STATUS:
> - case ARIZONA_DSP1_CONTROL_1:
> - case ARIZONA_DSP1_CLOCKING_1:
> case ARIZONA_DSP1_STATUS_1:
> case ARIZONA_DSP1_STATUS_2:
> case ARIZONA_DSP1_STATUS_3:
> + case ARIZONA_DSP1_SCRATCH_0:
> + case ARIZONA_DSP1_SCRATCH_1:
> + case ARIZONA_DSP1_SCRATCH_2:
> + case ARIZONA_DSP1_SCRATCH_3:
> case ARIZONA_DSP2_STATUS_1:
> case ARIZONA_DSP2_STATUS_2:
> case ARIZONA_DSP2_STATUS_3:
> + case ARIZONA_DSP2_SCRATCH_0:
> + case ARIZONA_DSP2_SCRATCH_1:
> + case ARIZONA_DSP2_SCRATCH_2:
> + case ARIZONA_DSP2_SCRATCH_3:
> case ARIZONA_DSP3_STATUS_1:
> case ARIZONA_DSP3_STATUS_2:
> case ARIZONA_DSP3_STATUS_3:
> + case ARIZONA_DSP3_SCRATCH_0:
> + case ARIZONA_DSP3_SCRATCH_1:
> + case ARIZONA_DSP3_SCRATCH_2:
> + case ARIZONA_DSP3_SCRATCH_3:
> case ARIZONA_DSP4_STATUS_1:
> case ARIZONA_DSP4_STATUS_2:
> case ARIZONA_DSP4_STATUS_3:
> + case ARIZONA_DSP4_SCRATCH_0:
> + case ARIZONA_DSP4_SCRATCH_1:
> + case ARIZONA_DSP4_SCRATCH_2:
> + case ARIZONA_DSP4_SCRATCH_3:
> return true;
> default:
> return false;
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mfd: arizona: Update volatile registers for WM5110 DSP
2013-09-17 7:24 ` Lee Jones
@ 2013-09-17 9:18 ` Charles Keepax
2013-09-17 9:54 ` Lee Jones
0 siblings, 1 reply; 4+ messages in thread
From: Charles Keepax @ 2013-09-17 9:18 UTC (permalink / raw)
To: Lee Jones; +Cc: sameo, patches, linux-kernel
No problem sorry the commit message was a little vague there.
Seems I accidentally generated the first version of this patch
against the ASoC tree, but this got me thinking now you are
looking after MFD patches which tree should I be generating them
against?
Thanks,
Charles
On Tue, Sep 17, 2013 at 08:24:25AM +0100, Lee Jones wrote:
> On Mon, 16 Sep 2013, Charles Keepax wrote:
>
> Any chance of a little more information in the commit message?
>
> What are scratch registers and why are they required now where they
> weren't before? Why are the control and clocking regulators no longer
> needed?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mfd: arizona: Update volatile registers for WM5110 DSP
2013-09-17 9:18 ` Charles Keepax
@ 2013-09-17 9:54 ` Lee Jones
0 siblings, 0 replies; 4+ messages in thread
From: Lee Jones @ 2013-09-17 9:54 UTC (permalink / raw)
To: Charles Keepax; +Cc: sameo, patches, linux-kernel
> No problem sorry the commit message was a little vague there.
> Seems I accidentally generated the first version of this patch
> against the ASoC tree, but this got me thinking now you are
> looking after MFD patches which tree should I be generating them
> against?
That depends. If you are submitting MFD only patches and you base them
on either Sam's [1] or my tree [2], you probably won't go too far
wrong.
However, if your patch or patch-set touches other subsystems then the
latest -rc is usually appropriate.
> On Tue, Sep 17, 2013 at 08:24:25AM +0100, Lee Jones wrote:
> > On Mon, 16 Sep 2013, Charles Keepax wrote:
> >
> > Any chance of a little more information in the commit message?
> >
> > What are scratch registers and why are they required now where they
> > weren't before? Why are the control and clocking regulators no longer
> > needed?
[1] git://git.kernel.org/pub/scm/linux/kernel/git/sameo/mfd-next.git - master
[2] git://git.linaro.org/people/ljones/mfd.git - for-mfd-next
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-09-17 9:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-16 15:31 [PATCH] mfd: arizona: Update volatile registers for WM5110 DSP Charles Keepax
2013-09-17 7:24 ` Lee Jones
2013-09-17 9:18 ` Charles Keepax
2013-09-17 9:54 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox