From: Lee Jones <lee.jones@linaro.org>
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: sameo@linux.intel.com, patches@opensource.wolfsonmicro.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mfd: arizona: Update registers for WM5110 DSP
Date: Tue, 17 Sep 2013 15:44:33 +0100 [thread overview]
Message-ID: <20130917144433.GZ16984@lee--X1> (raw)
In-Reply-To: <1379427784-7193-1-git-send-email-ckeepax@opensource.wolfsonmicro.com>
On Tue, 17 Sep 2013, Charles Keepax wrote:
> DSPx_CONTROL_1 and DSPx_CLOCKING_1 are not volatile registers and are
> incorrectly marked as such, fix this. Also add the DSP scratch
> registers, which are frequently used to output debug info from the DSP
> core.
>
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> ---
>
> Version 2 of the patch, improved commit message and turns
> out the scratch registers were missing from the readable
> callback as well.
>
> Based on Lee Jones's for-mfd-next branch.
>
> Thanks,
> Charles
>
> drivers/mfd/wm5110-tables.c | 34 ++++++++++++++++++++++++++++++++--
> 1 files changed, 32 insertions(+), 2 deletions(-)
If you're sure this is the right configuration, the patch looks good to me.
Applied, thanks.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2013-09-17 14:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-17 14:23 [PATCH v2] mfd: arizona: Update registers for WM5110 DSP Charles Keepax
2013-09-17 14:44 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130917144433.GZ16984@lee--X1 \
--to=lee.jones@linaro.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox