From: Felipe Balbi <balbi@ti.com>
To: Robert Baldyga <r.baldyga@samsung.com>
Cc: <balbi@ti.com>, <gregkh@linuxfoundation.org>,
<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<b.zolnierkie@samsung.com>, <m.szyprowski@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH 5/6] USB: gadget: s3c-hsotg: fix dedicated fifos handling
Date: Tue, 17 Sep 2013 10:58:41 -0500 [thread overview]
Message-ID: <20130917155841.GP15645@radagast> (raw)
In-Reply-To: <1378995532-32142-6-git-send-email-r.baldyga@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 820 bytes --]
On Thu, Sep 12, 2013 at 04:18:51PM +0200, Robert Baldyga wrote:
> This patch adds few fixes:
> - In s3c_hsotg_write_fifo function PTxFEmp/NPTxFEmp interrupts are enabled
> only in shared-fifo mode. In dedicated-fifo mode they should not be used
> (when enabled then cause interrupt storm).
> - When s3c_hsotg_trytx is called for ep without enqueued request, interrupts
> for this ep are disabled, to prevent interrupt flooding. Interrupts are
> enabled when new request for this ep is starting.
> - In s3c_hsotg_core_init enabled INTknTXFEmpMsk, becouse without this mask
> TxFIFOEmpty interrupt does not occur.
> - In OEPInt/IEPInt interrupts handling added bitwise and of DAINT and
> DAINTMSK, because we should handle masked interrupts only.
each fix in its own patch please.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-09-17 15:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-12 14:18 [PATCH 0/6] usb: s3c-hsotg: fixes for proper functioning Robert Baldyga
2013-09-12 14:18 ` [PATCH 1/6] usb: s3c-hsotg: change dependency to PLAT_SAMSUNG Robert Baldyga
2013-09-12 14:18 ` [PATCH 2/6] usb: s3c-hsotg: fix unregistration function Robert Baldyga
2013-09-12 14:18 ` [PATCH 3/6] usb: s3c-hsotg: do not disconnect gadget when receiving ErlySusp intr Robert Baldyga
2013-09-12 14:18 ` [PATCH 4/6] USB: gadget: s3c-hsotg: fix "protocol stall" handling Robert Baldyga
2013-09-17 15:57 ` Felipe Balbi
2013-09-12 14:18 ` [PATCH 5/6] USB: gadget: s3c-hsotg: fix dedicated fifos handling Robert Baldyga
2013-09-17 15:58 ` Felipe Balbi [this message]
2013-09-12 14:18 ` [PATCH 6/6] USB: gadget: s3c-hsotg: fix clear feature ENDPOINT_HALT Robert Baldyga
2013-09-17 15:58 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130917155841.GP15645@radagast \
--to=balbi@ti.com \
--cc=b.zolnierkie@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=r.baldyga@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox