From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753883Ab3IQUaP (ORCPT ); Tue, 17 Sep 2013 16:30:15 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:41269 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753336Ab3IQUaN (ORCPT ); Tue, 17 Sep 2013 16:30:13 -0400 Date: Tue, 17 Sep 2013 13:30:12 -0700 From: Christoph Hellwig To: Gerd Hoffmann Cc: linux-usb@vger.kernel.org, Matthew Wilcox , Sarah Sharp , Matthew Dharm , Greg Kroah-Hartman , "open list:USB ATTACHED SCSI" , "open list:USB MASS STORAGE..." , open list Subject: Re: [PATCH v3 3/6] uas: make work list per-device Message-ID: <20130917203012.GA1752@infradead.org> References: <1379071635-30701-1-git-send-email-kraxel@redhat.com> <1379071635-30701-4-git-send-email-kraxel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1379071635-30701-4-git-send-email-kraxel@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 13, 2013 at 01:27:12PM +0200, Gerd Hoffmann wrote: > Simplifies locking, we'll protect the list with the device spin lock. > Also plugs races which can happen when two devices operate on the > global list. > > While being at it rename the list head from "list" to "work", preparing > for the addition of a second list. Why do you even the list? What would a ordered per-device workqueue not provide?