From: Ingo Molnar <mingo@kernel.org>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@redhat.com>,
Namhyung Kim <namhyung@kernel.org>,
Waiman Long <Waiman.Long@hp.com>,
Stephane Eranian <eranian@google.com>,
Jiri Olsa <jolsa@redhat.com>, David Ahern <dsahern@gmail.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] perf: Support for Openembedded/Yocto -dbg packages
Date: Wed, 18 Sep 2013 15:29:03 +0200 [thread overview]
Message-ID: <20130918132903.GA4071@gmail.com> (raw)
In-Reply-To: <20130918130735.GC2240@ghostprotocols.net>
* Arnaldo Carvalho de Melo <acme@ghostprotocols.net> wrote:
> Em Wed, Sep 18, 2013 at 12:18:01PM +0200, Peter Zijlstra escreveu:
> > On Wed, Sep 18, 2013 at 12:02:12PM +0200, Ricardo Ribalda Delgado wrote:
> > > Perhaps this is even more clear than v2:
>
> > > len = snprintf(file, size, "%s", symbol_conf.symfs);
> > > size -= len;
> > > file += len;
> > > len = snprintf(file, MIN(size,(last_slash - dso->long_name) + 2),
> > > "%s", dso->long_name);
> > > size -= len;
> > > file += len;
> > > len = snprintf(file, size, ".debug%s", last_slash);
>
> > len = 0;
>
> > len += snprintf(str + len, size - len, ...);
> > len += snprintf(str + len, size - len, ...);
>
> And avoid snprintf like the plague, use scnprintf instead... See
> e7f01d1e3d8d501deb8abeaa269d5d48a703b8b0 for details :-)
Hm, could we do:
#define snprintf scnprintf
or:
#define snprintf(x...) BUILD_BUG()
?
I don't think there's any valid code, except printf wrappers (which we
don't have in perf), where the semantics of snprintf() would be needed.
Thanks,
Ingo
next prev parent reply other threads:[~2013-09-18 13:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-18 8:43 [PATCH] perf: Support for Openembedded/Yocto -dbg packages Ricardo Ribalda Delgado
2013-09-18 9:24 ` Ingo Molnar
2013-09-18 9:47 ` Ricardo Ribalda Delgado
2013-09-18 10:02 ` Ricardo Ribalda Delgado
2013-09-18 10:18 ` Peter Zijlstra
2013-09-18 13:07 ` Arnaldo Carvalho de Melo
2013-09-18 13:29 ` Ingo Molnar [this message]
2013-09-18 13:58 ` Ricardo Ribalda Delgado
2013-09-18 14:08 ` Arnaldo Carvalho de Melo
2013-10-02 0:54 ` Namhyung Kim
2013-10-02 6:13 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130918132903.GA4071@gmail.com \
--to=mingo@kernel.org \
--cc=Waiman.Long@hp.com \
--cc=acme@ghostprotocols.net \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=ricardo.ribalda@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).