From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
LKML <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@redhat.com>,
David Ahern <dsahern@gmail.com>, Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Stephane Eranian <eranian@google.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 0/4] perf tools: New comm infrastructure
Date: Wed, 18 Sep 2013 12:12:53 -0300 [thread overview]
Message-ID: <20130918151253.GC3891@infradead.org> (raw)
In-Reply-To: <20130918142038.GA3891@infradead.org>
Em Wed, Sep 18, 2013 at 11:20:38AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Tue, Sep 17, 2013 at 02:54:22PM +0900, Namhyung Kim escreveu:
> > On Sat, 14 Sep 2013 08:11:49 +0200, Ingo Molnar wrote:
> > > * Frederic Weisbecker <fweisbec@gmail.com> wrote:
> > >> My patches and Namhyung's should improve the comm situation a lot but we
> > >> can't do much miracle. The only way would be perhaps to be able to limit
> > >
> > >>
> > >> Now may be we can find other big contention point in perf. It's possible
> > >> we also have some endless loop somewhere.
> > >
> > > Well, it was the 100,000+ step linear list walk that was causing 90% of
> > > the slowness here. Namhyung's patch should dramatically improve that. I
> > > guess time for someone to post a combined tree so that it can be tested
> > > all together?
> > I pushed combined tree to 'perf/callchain-v2' branch in my tree
> > git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git
> But you did it for some old tree, as I tried running it now and since my
> big perf.data file has PERF_RECORD_MMAP2 records, I can't try it with
> your branch, working on cherry picking those changesets, since a plain
> rebase didn't work.
Cherry picking just:
commit ad3c9edd70122c8776bc0735287daba3945e328a
Author: Namhyung Kim <namhyung.kim@lge.com>
Date: Mon Sep 9 17:05:38 2013 +0900
perf callchain: Convert children list to rbtree
I go from too-long-to-wait to:
[root@sandy ~]# echo performance > /sys/devices/system/cpu/cpu3/cpufreq/scaling_governor
[acme@sandy linux]$ taskset -c 3 perf stat --null --sync --repeat 3 perf report -i perf.data.make-j8-kernel > /dev/null
Performance counter stats for 'perf report -i perf.data.make-j8-kernel' (3 runs):
79.158464654 seconds time elapsed ( +- 0.15% )
[acme@sandy linux]$
[acme@sandy linux]$ ls -lah perf.data.make-j8-kernel
-rw-------. 1 acme acme 2.3G Sep 16 11:56 perf.data.make-j8-kernel
Looking at the other patches, modulo the ones that do the progress bar updating
while collapsing, as they clash with a patch from Jiri Olsa.
- Arnaldo
next prev parent reply other threads:[~2013-09-18 15:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-12 20:29 [PATCH 0/4] perf tools: New comm infrastructure Frederic Weisbecker
2013-09-12 20:29 ` [PATCH 1/4] perf tools: Use an accessor to read thread comm Frederic Weisbecker
2013-09-12 20:29 ` [PATCH 2/4] perf tools: Add time argument on comm setting Frederic Weisbecker
2013-09-12 20:29 ` [PATCH 3/4] perf tools: Add new comm infrastructure Frederic Weisbecker
2013-09-12 20:29 ` [PATCH 4/4] perf tools: Compare hists comm by addresses Frederic Weisbecker
2013-09-13 8:07 ` Namhyung Kim
2013-09-13 13:59 ` Frederic Weisbecker
2013-09-17 1:46 ` Namhyung Kim
2013-09-12 20:36 ` [PATCH 0/4] perf tools: New comm infrastructure Ingo Molnar
2013-09-13 12:43 ` Frederic Weisbecker
2013-09-13 15:59 ` David Ahern
2013-09-14 6:11 ` Ingo Molnar
2013-09-17 5:54 ` Namhyung Kim
2013-09-17 7:16 ` Ingo Molnar
2013-09-18 14:20 ` Arnaldo Carvalho de Melo
2013-09-18 15:12 ` Arnaldo Carvalho de Melo [this message]
2013-09-18 15:58 ` Arnaldo Carvalho de Melo
2013-09-18 16:17 ` Namhyung Kim
2013-09-13 6:32 ` Namhyung Kim
2013-09-13 12:46 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130918151253.GC3891@infradead.org \
--to=acme@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox