public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Tobias Polzer <bulsa.t.polzer@studium.uni-erlangen.de>
Cc: usbip-devel@lists.sourceforge.net,
	Dominik Paulus <dominik.paulus@fau.de>,
	Anthony Foiani <anthony.foiani@gmail.com>,
	devel@driverdev.osuosl.org, linux-kernel@i4.cs.fau.de,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, Tobias Polzer <tobias.polzer@fau.de>,
	linux-kernel@vger.kernel.org,
	Stefan Reif <ke42caxa@cip.cs.fau.de>
Subject: Re: [PATCH] staging: usbip: Fix build on Debian ppc
Date: Thu, 19 Sep 2013 12:12:44 +0300	[thread overview]
Message-ID: <20130919091244.GV25896@mwanda> (raw)
In-Reply-To: <op.w3nhqgkq423x8j@localhost>

On Thu, Sep 19, 2013 at 10:55:18AM +0200, Tobias Polzer wrote:
> When testing usbip under powerpc, it (unexpectedly) worked, but only after
> removing the following lines from vhch_hcd.c:
> 
> 1004         /* will be removed */
> 1005         if (pdev->dev.dma_mask) {
> 1006                 dev_info(&pdev->dev, "vhci_hcd DMA not supported\n");
> 1007                 return -EINVAL;
> 1008         }
> 
> We encountered no problems without those lines. Is it safe to remove this
> check?

Hehe.  No.

Also which vhch_hcd.c are you talking about?  "find -name vhch_hcd.c"
doesn't show anything.

What the error message?

regards,
dan carpenter


  reply	other threads:[~2013-09-19  9:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-19  8:39 [PATCH] staging: usbip: Fix build on Debian ppc Dominik Paulus
2013-09-19  8:55 ` Tobias Polzer
2013-09-19  9:12   ` Dan Carpenter [this message]
2013-09-19 10:10     ` Dominik Paulus
2013-09-19 11:40       ` Dan Carpenter
  -- strict thread matches above, loose matches on Subject: below --
2013-09-19 11:28 navin patidar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130919091244.GV25896@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=anthony.foiani@gmail.com \
    --cc=bulsa.t.polzer@studium.uni-erlangen.de \
    --cc=devel@driverdev.osuosl.org \
    --cc=dominik.paulus@fau.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=ke42caxa@cip.cs.fau.de \
    --cc=linux-kernel@i4.cs.fau.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=tobias.polzer@fau.de \
    --cc=usbip-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox