From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753139Ab3ISJNz (ORCPT ); Thu, 19 Sep 2013 05:13:55 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:35970 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752971Ab3ISJNy (ORCPT ); Thu, 19 Sep 2013 05:13:54 -0400 Date: Thu, 19 Sep 2013 12:12:44 +0300 From: Dan Carpenter To: Tobias Polzer Cc: usbip-devel@lists.sourceforge.net, Dominik Paulus , Anthony Foiani , devel@driverdev.osuosl.org, linux-kernel@i4.cs.fau.de, Greg Kroah-Hartman , linux-usb@vger.kernel.org, Tobias Polzer , linux-kernel@vger.kernel.org, Stefan Reif Subject: Re: [PATCH] staging: usbip: Fix build on Debian ppc Message-ID: <20130919091244.GV25896@mwanda> References: <1379579978-2570-1-git-send-email-dominik.paulus@fau.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: acsinet22.oracle.com [141.146.126.238] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 19, 2013 at 10:55:18AM +0200, Tobias Polzer wrote: > When testing usbip under powerpc, it (unexpectedly) worked, but only after > removing the following lines from vhch_hcd.c: > > 1004 /* will be removed */ > 1005 if (pdev->dev.dma_mask) { > 1006 dev_info(&pdev->dev, "vhci_hcd DMA not supported\n"); > 1007 return -EINVAL; > 1008 } > > We encountered no problems without those lines. Is it safe to remove this > check? Hehe. No. Also which vhch_hcd.c are you talking about? "find -name vhch_hcd.c" doesn't show anything. What the error message? regards, dan carpenter