From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Kent Overstreet <kmo@daterainc.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Mel Gorman <mgorman@suse.de>, Jens Axboe <axboe@kernel.dk>,
Jan Kara <jack@suse.cz>, Hannes Reinecke <hare@suse.de>,
linux-kernel@vger.kernel.org
Subject: [PATCH] mm: Fix a regression where MS_SNAP_STABLE (stable pages snapshotting) was ignored
Date: Thu, 19 Sep 2013 20:06:02 -0700 [thread overview]
Message-ID: <20130920030602.GC4565@birch.djwong.org> (raw)
The "force" parameter in __blk_queue_bounce was being ignored, which means that
stable page snapshots are not always happening (on ext3). This of course
leads to DIF disks reporting checksum errors, so fix this regression.
The regression was introduced in commit 6bc454d1 (bounce: Refactor
__blk_queue_bounce to not use bi_io_vec)
Reported-by: Mel Gorman <mgorman@suse.de>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
mm/bounce.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/mm/bounce.c b/mm/bounce.c
index c9f0a43..5a7d58f 100644
--- a/mm/bounce.c
+++ b/mm/bounce.c
@@ -204,6 +204,8 @@ static void __blk_queue_bounce(struct request_queue *q, struct bio **bio_orig,
struct bio_vec *to, *from;
unsigned i;
+ if (force)
+ goto bounce;
bio_for_each_segment(from, *bio_orig, i)
if (page_to_pfn(from->bv_page) > queue_bounce_pfn(q))
goto bounce;
next reply other threads:[~2013-09-20 3:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-20 3:06 Darrick J. Wong [this message]
2013-09-20 3:28 ` [PATCH] mm: Fix a regression where MS_SNAP_STABLE (stable pages snapshotting) was ignored Mike Snitzer
2013-09-20 8:06 ` Mel Gorman
2013-09-20 8:28 ` Mel Gorman
2013-09-20 16:54 ` Darrick J. Wong
2013-09-24 8:33 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130920030602.GC4565@birch.djwong.org \
--to=darrick.wong@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=hare@suse.de \
--cc=jack@suse.cz \
--cc=kmo@daterainc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).