* [GIT PULL 0/9] perf/urgent fixes
@ 2012-03-30 16:09 Arnaldo Carvalho de Melo
2012-03-31 7:31 ` Ingo Molnar
0 siblings, 1 reply; 22+ messages in thread
From: Arnaldo Carvalho de Melo @ 2012-03-30 16:09 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo,
Ananth N Mavinakayanahalli, Benjamin Herrenschmidt, David Ahern,
David S. Miller, Frederic Weisbecker, Jiri Olsa, Linus Torvalds,
Masami Hiramatsu, Mike Galbraith, Namhyung Kim, Namhyung Kim,
Paul Mackerras, Peter Zijlstra, Prashanth Nageshappa,
Sorin Dumitru, Srikar Dronamraju, Stephane Eranian,
Steven Rostedt, Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling.
But please test the bison/flex thing, it was a bit tricky to make it
work with/without O=, and also to make it work on at least RHEL6.2, Fedora 14
and Ubuntu 10.04 LTS.
I know that bison barfs on Fedora 8, but left the fix for later.
- Arnaldo
The following changes since commit b01c3a0010aabadf745f3e7fdb9cab682e0a28a2:
perf: Move mmap page data_head offset assertion out of header (2012-03-24 08:46:59 +0100)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux perf/urgent
for you to fetch changes up to 65f3e56e0c81d1f581c4bdef7646ae5a8d51f494:
perf tools: Remove auto-generated bison/flex files (2012-03-30 12:43:17 -0300)
----------------------------------------------------------------
perf/urgent Fixes
. Assorted fixes from David Miller
. Fix display of first level of callchains, from Frederic Weisbecker
. Remove auto-generated bison/flex files, from Ingo Molnar and me
. Add missing ref-cycles event back to event parser, from Namhyung Kim
. Ignore DWARF decl tags to properly resolve function name do address,
from Prashanth Nageshappa
. Fix bug in raw sample parsing bug introduced in the branch stack patches,
from Stephane Eranian
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Arnaldo Carvalho de Melo (1):
perf annotate: Fix off by one symbol hist size allocation and hit accounting
David Miller (3):
perf symbols: Do not include libgen.h
perf symbols: Handle NULL dso in dso__name_len
perf annotate: addr2line wants addresses in same format as objdump
Frederic Weisbecker (1):
perf tools: Fix display of first level of callchains
Ingo Molnar (1):
perf tools: Remove auto-generated bison/flex files
Namhyung Kim (1):
perf tools: Add missing ref-cycles event back to event parser
Prashanth Nageshappa (1):
perf probe: Finder fails to resolve function name to address
Stephane Eranian (1):
perf tools: Fix bug in raw sample parsing
tools/perf/Makefile | 47 +-
tools/perf/util/annotate.c | 8 +-
tools/perf/util/evsel.c | 2 +
tools/perf/util/hist.c | 157 ++-
tools/perf/util/parse-events-bison.c | 1917 ----------------------------
tools/perf/util/parse-events-bison.h | 81 --
tools/perf/util/parse-events-flex.c | 2272 ----------------------------------
tools/perf/util/parse-events-flex.h | 316 -----
tools/perf/util/parse-events.l | 1 +
tools/perf/util/pmu-bison.c | 1663 -------------------------
tools/perf/util/pmu-bison.h | 73 --
tools/perf/util/pmu-flex.c | 1821 ---------------------------
tools/perf/util/pmu-flex.h | 316 -----
tools/perf/util/probe-finder.c | 4 +-
tools/perf/util/symbol.c | 3 +-
15 files changed, 135 insertions(+), 8546 deletions(-)
delete mode 100644 tools/perf/util/parse-events-bison.c
delete mode 100644 tools/perf/util/parse-events-bison.h
delete mode 100644 tools/perf/util/parse-events-flex.c
delete mode 100644 tools/perf/util/parse-events-flex.h
delete mode 100644 tools/perf/util/pmu-bison.c
delete mode 100644 tools/perf/util/pmu-bison.h
delete mode 100644 tools/perf/util/pmu-flex.c
delete mode 100644 tools/perf/util/pmu-flex.h
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [GIT PULL 0/9] perf/urgent fixes
2012-03-30 16:09 Arnaldo Carvalho de Melo
@ 2012-03-31 7:31 ` Ingo Molnar
0 siblings, 0 replies; 22+ messages in thread
From: Ingo Molnar @ 2012-03-31 7:31 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Ananth N Mavinakayanahalli, Benjamin Herrenschmidt,
David Ahern, David S. Miller, Frederic Weisbecker, Jiri Olsa,
Linus Torvalds, Masami Hiramatsu, Mike Galbraith, Namhyung Kim,
Namhyung Kim, Paul Mackerras, Peter Zijlstra,
Prashanth Nageshappa, Sorin Dumitru, Srikar Dronamraju,
Stephane Eranian, Steven Rostedt, Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:
> Hi Ingo,
>
> Please consider pulling.
>
> But please test the bison/flex thing, it was a bit tricky to make it
> work with/without O=, and also to make it work on at least RHEL6.2, Fedora 14
> and Ubuntu 10.04 LTS.
>
> I know that bison barfs on Fedora 8, but left the fix for later.
>
> - Arnaldo
>
> The following changes since commit b01c3a0010aabadf745f3e7fdb9cab682e0a28a2:
>
> perf: Move mmap page data_head offset assertion out of header (2012-03-24 08:46:59 +0100)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux perf/urgent
>
> for you to fetch changes up to 65f3e56e0c81d1f581c4bdef7646ae5a8d51f494:
>
> perf tools: Remove auto-generated bison/flex files (2012-03-30 12:43:17 -0300)
>
> ----------------------------------------------------------------
> perf/urgent Fixes
>
> . Assorted fixes from David Miller
>
> . Fix display of first level of callchains, from Frederic Weisbecker
>
> . Remove auto-generated bison/flex files, from Ingo Molnar and me
>
> . Add missing ref-cycles event back to event parser, from Namhyung Kim
>
> . Ignore DWARF decl tags to properly resolve function name do address,
> from Prashanth Nageshappa
>
> . Fix bug in raw sample parsing bug introduced in the branch stack patches,
> from Stephane Eranian
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (1):
> perf annotate: Fix off by one symbol hist size allocation and hit accounting
>
> David Miller (3):
> perf symbols: Do not include libgen.h
> perf symbols: Handle NULL dso in dso__name_len
> perf annotate: addr2line wants addresses in same format as objdump
>
> Frederic Weisbecker (1):
> perf tools: Fix display of first level of callchains
>
> Ingo Molnar (1):
> perf tools: Remove auto-generated bison/flex files
>
> Namhyung Kim (1):
> perf tools: Add missing ref-cycles event back to event parser
>
> Prashanth Nageshappa (1):
> perf probe: Finder fails to resolve function name to address
>
> Stephane Eranian (1):
> perf tools: Fix bug in raw sample parsing
>
> tools/perf/Makefile | 47 +-
> tools/perf/util/annotate.c | 8 +-
> tools/perf/util/evsel.c | 2 +
> tools/perf/util/hist.c | 157 ++-
> tools/perf/util/parse-events-bison.c | 1917 ----------------------------
> tools/perf/util/parse-events-bison.h | 81 --
> tools/perf/util/parse-events-flex.c | 2272 ----------------------------------
> tools/perf/util/parse-events-flex.h | 316 -----
> tools/perf/util/parse-events.l | 1 +
> tools/perf/util/pmu-bison.c | 1663 -------------------------
> tools/perf/util/pmu-bison.h | 73 --
> tools/perf/util/pmu-flex.c | 1821 ---------------------------
> tools/perf/util/pmu-flex.h | 316 -----
> tools/perf/util/probe-finder.c | 4 +-
> tools/perf/util/symbol.c | 3 +-
> 15 files changed, 135 insertions(+), 8546 deletions(-)
> delete mode 100644 tools/perf/util/parse-events-bison.c
> delete mode 100644 tools/perf/util/parse-events-bison.h
> delete mode 100644 tools/perf/util/parse-events-flex.c
> delete mode 100644 tools/perf/util/parse-events-flex.h
> delete mode 100644 tools/perf/util/pmu-bison.c
> delete mode 100644 tools/perf/util/pmu-bison.h
> delete mode 100644 tools/perf/util/pmu-flex.c
> delete mode 100644 tools/perf/util/pmu-flex.h
Pulled, thanks a lot Arnaldo!
It's working fine on all my test-boxes.
Thanks,
Ingo
^ permalink raw reply [flat|nested] 22+ messages in thread
* [GIT PULL 0/9] perf/urgent fixes
@ 2013-09-19 18:40 Arnaldo Carvalho de Melo
2013-09-19 18:40 ` [PATCH 1/9] perf tools: Sharpen the libaudit dependencies test Arnaldo Carvalho de Melo
` (9 more replies)
0 siblings, 10 replies; 22+ messages in thread
From: Arnaldo Carvalho de Melo @ 2013-09-19 18:40 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Ananth N Mavinakayanahalli, Borislav Petkov, David Ahern,
Frederic Weisbecker, H. Peter Anvin, Jiri Olsa, Masami Hiramatsu,
Mike Galbraith, Namhyung Kim, Paul Mackerras, Peter Zijlstra,
Prashanth Nageshappa, Srikar Dronamraju, Stephane Eranian,
Steven Rostedt, Thomas Gleixner, Vinson Lee, Vinson Lee,
yrl.pp-manager.tt, Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit a8e0108cac181a7b141dacaa99ea52efaf9b5f07:
perf: Fix UAPI export of PERF_EVENT_IOC_ID (2013-09-18 11:29:07 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-urgent-for-mingo
for you to fetch changes up to ce7eebe5c3deef8e19c177c24ee75843256e69ca:
tools lib lk: Uninclude linux/magic.h in debugfs.c (2013-09-19 15:08:53 -0300)
----------------------------------------------------------------
perf/urgent fixes:
. Check for SIGINT in more loops, allowing tools such as 'perf report' to
react faster to control+C.
. Fix objdump line parsing offset validation in the annotate code,
from Adrian Hunter.
. Fix buildid cache handling of kallsyms with kcore, from Adrian Hunter.
. Fix compile with libelf without get_phdrnum, from Adrian Hunter.
. Sharpen the libaudit dependencies test, refusing to build with older
libraries that doesn't have all the functions used by 'perf trace", fix
from Ingo Molnar.
. Fill in new definitions for madvise()/mmap() flags to fix the build in
older systems, from Ingo Molnar.
. Fix old GCC build error in older systems in the kallsyms parsing code in
trace-event-parse.c, from Ingo Molnar.
. Ignore DWARF declaration tags, allowing, for instance, that the
$ perf probe -L getname
command succeeds in showing the source code for the 'getname' kernel
function, telling in which lines probes can be inserted, fix from
Masami Hiramatsu.
. Fix linux/magic.h related build breakage in some systems, fix from
Vinson Lee.
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Adrian Hunter (3):
perf annotate: Fix objdump line parsing offset validation
perf tools: Fix buildid cache handling of kallsyms with kcore
perf tools: Fix compile with libelf without get_phdrnum
Arnaldo Carvalho de Melo (1):
perf session: Check for SIGINT in more loops
Ingo Molnar (3):
perf tools: Sharpen the libaudit dependencies test
perf tools: Fill in new definitions for madvise()/mmap() flags
perf tools: Fix old GCC build error in trace-event-parse.c:parse_proc_kallsyms()
Masami Hiramatsu (1):
perf probe: Fix finder to find lines of given function
Vinson Lee (1):
tools lib lk: Uninclude linux/magic.h in debugfs.c
tools/lib/lk/debugfs.c | 1 -
tools/perf/builtin-inject.c | 2 --
tools/perf/builtin-report.c | 5 +++--
tools/perf/builtin-script.c | 2 --
tools/perf/builtin-trace.c | 17 +++++++++++++++
tools/perf/config/Makefile | 3 +++
tools/perf/config/feature-tests.mak | 10 +++++++++
tools/perf/util/annotate.c | 2 +-
tools/perf/util/dwarf-aux.c | 19 +++++++++++++++++
tools/perf/util/dwarf-aux.h | 3 +++
tools/perf/util/header.c | 41 +++++++++++++++++++++++++------------
tools/perf/util/hist.c | 2 ++
tools/perf/util/probe-finder.c | 12 +++++------
tools/perf/util/session.c | 9 ++++++--
tools/perf/util/session.h | 4 ++++
tools/perf/util/symbol-elf.c | 16 +++++++++++++++
tools/perf/util/trace-event-parse.c | 2 +-
17 files changed, 119 insertions(+), 31 deletions(-)
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH 1/9] perf tools: Sharpen the libaudit dependencies test
2013-09-19 18:40 [GIT PULL 0/9] perf/urgent fixes Arnaldo Carvalho de Melo
@ 2013-09-19 18:40 ` Arnaldo Carvalho de Melo
2013-09-19 18:40 ` [PATCH 2/9] perf tools: Fill in new definitions for madvise()/mmap() flags Arnaldo Carvalho de Melo
` (8 subsequent siblings)
9 siblings, 0 replies; 22+ messages in thread
From: Arnaldo Carvalho de Melo @ 2013-09-19 18:40 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Adrian Hunter, David Ahern, Frederic Weisbecker,
H. Peter Anvin, Mike Galbraith, Paul Mackerras, Peter Zijlstra,
Stephane Eranian, Thomas Gleixner, Arnaldo Carvalho de Melo
From: Ingo Molnar <mingo@kernel.org>
There are older libaudit versions that don't have an
audit_errno_to_name() method, resulting in a builtin-trace.c build
error:
builtin-trace.c: In function ‘trace__sys_exit’:
builtin-trace.c:794: warning: implicit declaration of function ‘audit_errno_to_name’
Expand the libaudit test to detect this.
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/20130912132706.GD23826@gmail.com
[ Fix the test by escaping the double quotes ]
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/config/feature-tests.mak | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/perf/config/feature-tests.mak b/tools/perf/config/feature-tests.mak
index 708fb8e..7f550c1 100644
--- a/tools/perf/config/feature-tests.mak
+++ b/tools/perf/config/feature-tests.mak
@@ -210,6 +210,7 @@ define SOURCE_LIBAUDIT
int main(void)
{
+ printf(\"error message: %s\n\", audit_errno_to_name(0));
return audit_open();
}
endef
--
1.8.1.4
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH 2/9] perf tools: Fill in new definitions for madvise()/mmap() flags
2013-09-19 18:40 [GIT PULL 0/9] perf/urgent fixes Arnaldo Carvalho de Melo
2013-09-19 18:40 ` [PATCH 1/9] perf tools: Sharpen the libaudit dependencies test Arnaldo Carvalho de Melo
@ 2013-09-19 18:40 ` Arnaldo Carvalho de Melo
2013-09-19 18:40 ` [PATCH 3/9] perf annotate: Fix objdump line parsing offset validation Arnaldo Carvalho de Melo
` (7 subsequent siblings)
9 siblings, 0 replies; 22+ messages in thread
From: Arnaldo Carvalho de Melo @ 2013-09-19 18:40 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Adrian Hunter, David Ahern, Frederic Weisbecker,
H. Peter Anvin, Mike Galbraith, Paul Mackerras, Peter Zijlstra,
Stephane Eranian, Thomas Gleixner, linux-tip-commits,
Arnaldo Carvalho de Melo
From: Ingo Molnar <mingo@kernel.org>
builtin-trace.c started using various new syscall features not defined
in the header files of older distros - resulting in build failures.
Fill in the (ABI) constants if they are not defined.
(There might be a better place to put this than builtin-trace.c, into a
compat header or so.)
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-tip-commits@vger.kernel.org
Link: http://lkml.kernel.org/r/20130912132900.GE23826@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-trace.c | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
index f5aa637..fd48534 100644
--- a/tools/perf/builtin-trace.c
+++ b/tools/perf/builtin-trace.c
@@ -16,6 +16,23 @@
#include <sys/mman.h>
#include <linux/futex.h>
+/* For older distros: */
+#ifndef MAP_STACK
+# define MAP_STACK 0x20000
+#endif
+
+#ifndef MADV_HWPOISON
+# define MADV_HWPOISON 100
+#endif
+
+#ifndef MADV_MERGEABLE
+# define MADV_MERGEABLE 12
+#endif
+
+#ifndef MADV_UNMERGEABLE
+# define MADV_UNMERGEABLE 13
+#endif
+
static size_t syscall_arg__scnprintf_hex(char *bf, size_t size,
unsigned long arg,
u8 arg_idx __maybe_unused,
--
1.8.1.4
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH 3/9] perf annotate: Fix objdump line parsing offset validation
2013-09-19 18:40 [GIT PULL 0/9] perf/urgent fixes Arnaldo Carvalho de Melo
2013-09-19 18:40 ` [PATCH 1/9] perf tools: Sharpen the libaudit dependencies test Arnaldo Carvalho de Melo
2013-09-19 18:40 ` [PATCH 2/9] perf tools: Fill in new definitions for madvise()/mmap() flags Arnaldo Carvalho de Melo
@ 2013-09-19 18:40 ` Arnaldo Carvalho de Melo
2013-09-19 18:40 ` [PATCH 4/9] perf tools: Fix buildid cache handling of kallsyms with kcore Arnaldo Carvalho de Melo
` (6 subsequent siblings)
9 siblings, 0 replies; 22+ messages in thread
From: Arnaldo Carvalho de Melo @ 2013-09-19 18:40 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Adrian Hunter, David Ahern, Frederic Weisbecker,
Jiri Olsa, Mike Galbraith, Namhyung Kim, Paul Mackerras,
Peter Zijlstra, Stephane Eranian, Arnaldo Carvalho de Melo
From: Adrian Hunter <adrian.hunter@intel.com>
When parsing lines from objdump a line containing source code starting
with a numeric label is mistaken for a line of disassembly starting with
a memory address.
Current validation fails to recognise that the "memory address" is out
of range and calculates an invalid offset which later causes this
segfault:
Program received signal SIGSEGV, Segmentation fault.
0x0000000000457315 in disasm__calc_percent (notes=0xc98970, evidx=0, offset=143705, end=2127526177, path=0x7fffffffbf50)
at util/annotate.c:631
631 hits += h->addr[offset++];
(gdb) bt
#0 0x0000000000457315 in disasm__calc_percent (notes=0xc98970, evidx=0, offset=143705, end=2127526177, path=0x7fffffffbf50)
at util/annotate.c:631
#1 0x00000000004d65e3 in annotate_browser__calc_percent (browser=0x7fffffffd130, evsel=0xa01da0) at ui/browsers/annotate.c:364
#2 0x00000000004d7433 in annotate_browser__run (browser=0x7fffffffd130, evsel=0xa01da0, hbt=0x0) at ui/browsers/annotate.c:672
#3 0x00000000004d80c9 in symbol__tui_annotate (sym=0xc989a0, map=0xa02660, evsel=0xa01da0, hbt=0x0) at ui/browsers/annotate.c:962
#4 0x00000000004d7aa0 in hist_entry__tui_annotate (he=0xdf73f0, evsel=0xa01da0, hbt=0x0) at ui/browsers/annotate.c:823
#5 0x00000000004dd648 in perf_evsel__hists_browse (evsel=0xa01da0, nr_events=1, helpline=
0x58b768 "For a higher level overview, try: perf report --sort comm,dso", ev_name=0xa02cd0 "cycles", left_exits=false, hbt=
0x0, min_pcnt=0, env=0xa011e0) at ui/browsers/hists.c:1659
#6 0x00000000004de372 in perf_evlist__tui_browse_hists (evlist=0xa01520, help=
0x58b768 "For a higher level overview, try: perf report --sort comm,dso", hbt=0x0, min_pcnt=0, env=0xa011e0)
at ui/browsers/hists.c:1950
#7 0x000000000042cf6b in __cmd_report (rep=0x7fffffffd6c0) at builtin-report.c:581
#8 0x000000000042e25d in cmd_report (argc=0, argv=0x7fffffffe4b0, prefix=0x0) at builtin-report.c:965
#9 0x000000000041a0e1 in run_builtin (p=0x801548, argc=1, argv=0x7fffffffe4b0) at perf.c:319
#10 0x000000000041a319 in handle_internal_command (argc=1, argv=0x7fffffffe4b0) at perf.c:376
#11 0x000000000041a465 in run_argv (argcp=0x7fffffffe38c, argv=0x7fffffffe380) at perf.c:420
#12 0x000000000041a707 in main (argc=1, argv=0x7fffffffe4b0) at perf.c:521
After the fix is applied the symbol can be annotated showing the
problematic line "1: rep"
copy_user_generic_string /usr/lib/debug/lib/modules/3.9.10-100.fc17.x86_64/vmlinux
*/
ENTRY(copy_user_generic_string)
CFI_STARTPROC
ASM_STAC
andl %edx,%edx
and %edx,%edx
jz 4f
je 37
cmpl $8,%edx
cmp $0x8,%edx
jb 2f /* less than 8 bytes, go to byte copy loop */
jb 33
ALIGN_DESTINATION
mov %edi,%ecx
and $0x7,%ecx
je 28
sub $0x8,%ecx
neg %ecx
sub %ecx,%edx
1a: mov (%rsi),%al
mov %al,(%rdi)
inc %rsi
inc %rdi
dec %ecx
jne 1a
movl %edx,%ecx
28: mov %edx,%ecx
shrl $3,%ecx
shr $0x3,%ecx
andl $7,%edx
and $0x7,%edx
1: rep
100.00 rep movsq %ds:(%rsi),%es:(%rdi)
movsq
2: movl %edx,%ecx
33: mov %edx,%ecx
3: rep
rep movsb %ds:(%rsi),%es:(%rdi)
movsb
4: xorl %eax,%eax
37: xor %eax,%eax
data32 xchg %ax,%ax
ASM_CLAC
ret
retq
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Namhyung Kim <namhyung@gmail.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/r/1379009721-27667-1-git-send-email-adrian.hunter@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/annotate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
index bfc5a27..7eae548 100644
--- a/tools/perf/util/annotate.c
+++ b/tools/perf/util/annotate.c
@@ -809,7 +809,7 @@ static int symbol__parse_objdump_line(struct symbol *sym, struct map *map,
end = map__rip_2objdump(map, sym->end);
offset = line_ip - start;
- if (offset < 0 || (u64)line_ip > end)
+ if ((u64)line_ip < start || (u64)line_ip > end)
offset = -1;
else
parsed_line = tmp2 + 1;
--
1.8.1.4
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH 4/9] perf tools: Fix buildid cache handling of kallsyms with kcore
2013-09-19 18:40 [GIT PULL 0/9] perf/urgent fixes Arnaldo Carvalho de Melo
` (2 preceding siblings ...)
2013-09-19 18:40 ` [PATCH 3/9] perf annotate: Fix objdump line parsing offset validation Arnaldo Carvalho de Melo
@ 2013-09-19 18:40 ` Arnaldo Carvalho de Melo
2013-09-19 18:40 ` [PATCH 5/9] perf tools: Fix compile with libelf without get_phdrnum Arnaldo Carvalho de Melo
` (5 subsequent siblings)
9 siblings, 0 replies; 22+ messages in thread
From: Arnaldo Carvalho de Melo @ 2013-09-19 18:40 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Adrian Hunter, David Ahern, Frederic Weisbecker,
Jiri Olsa, Mike Galbraith, Namhyung Kim, Paul Mackerras,
Peter Zijlstra, Stephane Eranian, Arnaldo Carvalho de Melo
From: Adrian Hunter <adrian.hunter@intel.com>
When kallsyms is used with kcore the dso long_name becomes the kcore
file name. That prevents the buildid cache from caching kallsyms.
(There is no support at present for caching kcore). Fix by changing it
so that the kallsyms name is used in that case instead.
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Namhyung Kim <namhyung@gmail.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/r/1379009959-28046-1-git-send-email-adrian.hunter@intel.com
[ Kept 'struct foo' pointer as first parameter of foo__ prefixed functions ]
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
| 41 ++++++++++++++++++++++++++++-------------
1 file changed, 28 insertions(+), 13 deletions(-)
--git a/tools/perf/util/header.c b/tools/perf/util/header.c
index 26441d0..ce69901 100644
--- a/tools/perf/util/header.c
+++ b/tools/perf/util/header.c
@@ -199,9 +199,11 @@ static int write_buildid(char *name, size_t name_len, u8 *build_id,
return write_padded(fd, name, name_len + 1, len);
}
-static int __dsos__write_buildid_table(struct list_head *head, pid_t pid,
- u16 misc, int fd)
+static int __dsos__write_buildid_table(struct list_head *head,
+ struct machine *machine,
+ pid_t pid, u16 misc, int fd)
{
+ char nm[PATH_MAX];
struct dso *pos;
dsos__for_each_with_build_id(pos, head) {
@@ -215,6 +217,10 @@ static int __dsos__write_buildid_table(struct list_head *head, pid_t pid,
if (is_vdso_map(pos->short_name)) {
name = (char *) VDSO__MAP_NAME;
name_len = sizeof(VDSO__MAP_NAME) + 1;
+ } else if (dso__is_kcore(pos)) {
+ machine__mmap_name(machine, nm, sizeof(nm));
+ name = nm;
+ name_len = strlen(nm) + 1;
} else {
name = pos->long_name;
name_len = pos->long_name_len + 1;
@@ -240,10 +246,10 @@ static int machine__write_buildid_table(struct machine *machine, int fd)
umisc = PERF_RECORD_MISC_GUEST_USER;
}
- err = __dsos__write_buildid_table(&machine->kernel_dsos, machine->pid,
- kmisc, fd);
+ err = __dsos__write_buildid_table(&machine->kernel_dsos, machine,
+ machine->pid, kmisc, fd);
if (err == 0)
- err = __dsos__write_buildid_table(&machine->user_dsos,
+ err = __dsos__write_buildid_table(&machine->user_dsos, machine,
machine->pid, umisc, fd);
return err;
}
@@ -375,23 +381,31 @@ out_free:
return err;
}
-static int dso__cache_build_id(struct dso *dso, const char *debugdir)
+static int dso__cache_build_id(struct dso *dso, struct machine *machine,
+ const char *debugdir)
{
bool is_kallsyms = dso->kernel && dso->long_name[0] != '/';
bool is_vdso = is_vdso_map(dso->short_name);
+ char *name = dso->long_name;
+ char nm[PATH_MAX];
- return build_id_cache__add_b(dso->build_id, sizeof(dso->build_id),
- dso->long_name, debugdir,
- is_kallsyms, is_vdso);
+ if (dso__is_kcore(dso)) {
+ is_kallsyms = true;
+ machine__mmap_name(machine, nm, sizeof(nm));
+ name = nm;
+ }
+ return build_id_cache__add_b(dso->build_id, sizeof(dso->build_id), name,
+ debugdir, is_kallsyms, is_vdso);
}
-static int __dsos__cache_build_ids(struct list_head *head, const char *debugdir)
+static int __dsos__cache_build_ids(struct list_head *head,
+ struct machine *machine, const char *debugdir)
{
struct dso *pos;
int err = 0;
dsos__for_each_with_build_id(pos, head)
- if (dso__cache_build_id(pos, debugdir))
+ if (dso__cache_build_id(pos, machine, debugdir))
err = -1;
return err;
@@ -399,8 +413,9 @@ static int __dsos__cache_build_ids(struct list_head *head, const char *debugdir)
static int machine__cache_build_ids(struct machine *machine, const char *debugdir)
{
- int ret = __dsos__cache_build_ids(&machine->kernel_dsos, debugdir);
- ret |= __dsos__cache_build_ids(&machine->user_dsos, debugdir);
+ int ret = __dsos__cache_build_ids(&machine->kernel_dsos, machine,
+ debugdir);
+ ret |= __dsos__cache_build_ids(&machine->user_dsos, machine, debugdir);
return ret;
}
--
1.8.1.4
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH 5/9] perf tools: Fix compile with libelf without get_phdrnum
2013-09-19 18:40 [GIT PULL 0/9] perf/urgent fixes Arnaldo Carvalho de Melo
` (3 preceding siblings ...)
2013-09-19 18:40 ` [PATCH 4/9] perf tools: Fix buildid cache handling of kallsyms with kcore Arnaldo Carvalho de Melo
@ 2013-09-19 18:40 ` Arnaldo Carvalho de Melo
2013-09-19 18:40 ` [PATCH 6/9] perf session: Check for SIGINT in more loops Arnaldo Carvalho de Melo
` (4 subsequent siblings)
9 siblings, 0 replies; 22+ messages in thread
From: Arnaldo Carvalho de Melo @ 2013-09-19 18:40 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Adrian Hunter, David Ahern, Frederic Weisbecker,
Jiri Olsa, Mike Galbraith, Namhyung Kim, Paul Mackerras,
Peter Zijlstra, Stephane Eranian, Arnaldo Carvalho de Melo
From: Adrian Hunter <adrian.hunter@intel.com>
Add a feature check for get_phdrnum() and implement a replacement if it
is not present.
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Namhyung Kim <namhyung@gmail.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/r/1379080170-6608-1-git-send-email-adrian.hunter@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/config/Makefile | 3 +++
tools/perf/config/feature-tests.mak | 9 +++++++++
tools/perf/util/symbol-elf.c | 16 ++++++++++++++++
3 files changed, 28 insertions(+)
diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
index 214e17e..346ee92 100644
--- a/tools/perf/config/Makefile
+++ b/tools/perf/config/Makefile
@@ -180,6 +180,9 @@ FLAGS_LIBELF=$(CFLAGS) $(LDFLAGS) $(EXTLIBS)
ifeq ($(call try-cc,$(SOURCE_ELF_MMAP),$(FLAGS_LIBELF),-DLIBELF_MMAP),y)
CFLAGS += -DLIBELF_MMAP
endif
+ifeq ($(call try-cc,$(SOURCE_ELF_GETPHDRNUM),$(FLAGS_LIBELF),-DHAVE_ELF_GETPHDRNUM),y)
+ CFLAGS += -DHAVE_ELF_GETPHDRNUM
+endif
# include ARCH specific config
-include $(src-perf)/arch/$(ARCH)/Makefile
diff --git a/tools/perf/config/feature-tests.mak b/tools/perf/config/feature-tests.mak
index 7f550c1..d5a8dd4 100644
--- a/tools/perf/config/feature-tests.mak
+++ b/tools/perf/config/feature-tests.mak
@@ -61,6 +61,15 @@ int main(void)
}
endef
+define SOURCE_ELF_GETPHDRNUM
+#include <libelf.h>
+int main(void)
+{
+ size_t dst;
+ return elf_getphdrnum(0, &dst);
+}
+endef
+
ifndef NO_SLANG
define SOURCE_SLANG
#include <slang.h>
diff --git a/tools/perf/util/symbol-elf.c b/tools/perf/util/symbol-elf.c
index a7b9ab5..a9c829b 100644
--- a/tools/perf/util/symbol-elf.c
+++ b/tools/perf/util/symbol-elf.c
@@ -8,6 +8,22 @@
#include "symbol.h"
#include "debug.h"
+#ifndef HAVE_ELF_GETPHDRNUM
+static int elf_getphdrnum(Elf *elf, size_t *dst)
+{
+ GElf_Ehdr gehdr;
+ GElf_Ehdr *ehdr;
+
+ ehdr = gelf_getehdr(elf, &gehdr);
+ if (!ehdr)
+ return -1;
+
+ *dst = ehdr->e_phnum;
+
+ return 0;
+}
+#endif
+
#ifndef NT_GNU_BUILD_ID
#define NT_GNU_BUILD_ID 3
#endif
--
1.8.1.4
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH 6/9] perf session: Check for SIGINT in more loops
2013-09-19 18:40 [GIT PULL 0/9] perf/urgent fixes Arnaldo Carvalho de Melo
` (4 preceding siblings ...)
2013-09-19 18:40 ` [PATCH 5/9] perf tools: Fix compile with libelf without get_phdrnum Arnaldo Carvalho de Melo
@ 2013-09-19 18:40 ` Arnaldo Carvalho de Melo
2013-09-19 18:40 ` [PATCH 7/9] perf probe: Fix finder to find lines of given function Arnaldo Carvalho de Melo
` (3 subsequent siblings)
9 siblings, 0 replies; 22+ messages in thread
From: Arnaldo Carvalho de Melo @ 2013-09-19 18:40 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
David Ahern, Frederic Weisbecker, Jiri Olsa, Mike Galbraith,
Paul Mackerras, Peter Zijlstra, Stephane Eranian
From: Arnaldo Carvalho de Melo <acme@redhat.com>
When processing big files we were not checking if session_done was set
by the SIGINT signal handler, for instance in 'perf report'. Fix it.
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/n/tip-pyad42lgrtq7xhg2dpsoauq7@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-inject.c | 2 --
tools/perf/builtin-report.c | 5 +++--
tools/perf/builtin-script.c | 2 --
tools/perf/util/hist.c | 2 ++
tools/perf/util/session.c | 9 +++++++--
tools/perf/util/session.h | 4 ++++
6 files changed, 16 insertions(+), 8 deletions(-)
diff --git a/tools/perf/builtin-inject.c b/tools/perf/builtin-inject.c
index 423875c..afe377b 100644
--- a/tools/perf/builtin-inject.c
+++ b/tools/perf/builtin-inject.c
@@ -321,8 +321,6 @@ found:
return perf_event__repipe(tool, event_sw, &sample_sw, machine);
}
-extern volatile int session_done;
-
static void sig_handler(int sig __maybe_unused)
{
session_done = 1;
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index 8e50d8d..72eae74 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -401,8 +401,6 @@ static int perf_report__setup_sample_type(struct perf_report *rep)
return 0;
}
-extern volatile int session_done;
-
static void sig_handler(int sig __maybe_unused)
{
session_done = 1;
@@ -568,6 +566,9 @@ static int __cmd_report(struct perf_report *rep)
}
}
+ if (session_done())
+ return 0;
+
if (nr_samples == 0) {
ui__error("The %s file has no samples!\n", session->filename);
return 0;
diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
index 7f31a3d..9c333ff 100644
--- a/tools/perf/builtin-script.c
+++ b/tools/perf/builtin-script.c
@@ -553,8 +553,6 @@ static struct perf_tool perf_script = {
.ordering_requires_timestamps = true,
};
-extern volatile int session_done;
-
static void sig_handler(int sig __maybe_unused)
{
session_done = 1;
diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c
index 46a0d35..9ff6cf3 100644
--- a/tools/perf/util/hist.c
+++ b/tools/perf/util/hist.c
@@ -611,6 +611,8 @@ void hists__collapse_resort(struct hists *hists)
next = rb_first(root);
while (next) {
+ if (session_done())
+ break;
n = rb_entry(next, struct hist_entry, rb_node_in);
next = rb_next(&n->rb_node_in);
diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
index 51f5edf..70ffa41 100644
--- a/tools/perf/util/session.c
+++ b/tools/perf/util/session.c
@@ -531,6 +531,9 @@ static int flush_sample_queue(struct perf_session *s,
return 0;
list_for_each_entry_safe(iter, tmp, head, list) {
+ if (session_done())
+ return 0;
+
if (iter->timestamp > limit)
break;
@@ -1160,7 +1163,6 @@ static void perf_session__warn_about_errors(const struct perf_session *session,
}
}
-#define session_done() (*(volatile int *)(&session_done))
volatile int session_done;
static int __perf_session__process_pipe_events(struct perf_session *self,
@@ -1372,10 +1374,13 @@ more:
"Processing events...");
}
+ err = 0;
+ if (session_done())
+ goto out_err;
+
if (file_pos < file_size)
goto more;
- err = 0;
/* do the final flush for ordered samples */
session->ordered_samples.next_flush = ULLONG_MAX;
err = flush_sample_queue(session, tool);
diff --git a/tools/perf/util/session.h b/tools/perf/util/session.h
index 3aa75fb..04bf737 100644
--- a/tools/perf/util/session.h
+++ b/tools/perf/util/session.h
@@ -124,4 +124,8 @@ int __perf_session__set_tracepoints_handlers(struct perf_session *session,
#define perf_session__set_tracepoints_handlers(session, array) \
__perf_session__set_tracepoints_handlers(session, array, ARRAY_SIZE(array))
+
+extern volatile int session_done;
+
+#define session_done() (*(volatile int *)(&session_done))
#endif /* __PERF_SESSION_H */
--
1.8.1.4
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH 7/9] perf probe: Fix finder to find lines of given function
2013-09-19 18:40 [GIT PULL 0/9] perf/urgent fixes Arnaldo Carvalho de Melo
` (5 preceding siblings ...)
2013-09-19 18:40 ` [PATCH 6/9] perf session: Check for SIGINT in more loops Arnaldo Carvalho de Melo
@ 2013-09-19 18:40 ` Arnaldo Carvalho de Melo
2013-09-19 18:40 ` [PATCH 8/9] perf tools: Fix old GCC build error in trace-event-parse.c:parse_proc_kallsyms() Arnaldo Carvalho de Melo
` (2 subsequent siblings)
9 siblings, 0 replies; 22+ messages in thread
From: Arnaldo Carvalho de Melo @ 2013-09-19 18:40 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Masami Hiramatsu, Ananth N Mavinakayanahalli,
Prashanth Nageshappa, Srikar Dronamraju, Steven Rostedt,
yrl.pp-manager.tt, Arnaldo Carvalho de Melo
From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
The commit ba28c59bc9ed8fb7b9a753cd88ee54a2c4f6265b fixed a declaration
entry bug in probe_point_search_cb(). There are same bugs in line
finder and call_probe_finder(). This introduces a new dwarf utility
function to determine given DIE is a function definition, not
declaration.
Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
Cc: Prashanth Nageshappa <prashanth@linux.vnet.ibm.com>
Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: yrl.pp-manager.tt@hitachi.com
Link: http://lkml.kernel.org/r/20120423032435.8737.80064.stgit@localhost.localdomain
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/dwarf-aux.c | 19 +++++++++++++++++++
tools/perf/util/dwarf-aux.h | 3 +++
tools/perf/util/probe-finder.c | 12 +++++-------
3 files changed, 27 insertions(+), 7 deletions(-)
diff --git a/tools/perf/util/dwarf-aux.c b/tools/perf/util/dwarf-aux.c
index 3e5f543..e23bde1 100644
--- a/tools/perf/util/dwarf-aux.c
+++ b/tools/perf/util/dwarf-aux.c
@@ -263,6 +263,21 @@ bool die_is_signed_type(Dwarf_Die *tp_die)
}
/**
+ * die_is_func_def - Ensure that this DIE is a subprogram and definition
+ * @dw_die: a DIE
+ *
+ * Ensure that this DIE is a subprogram and NOT a declaration. This
+ * returns true if @dw_die is a function definition.
+ **/
+bool die_is_func_def(Dwarf_Die *dw_die)
+{
+ Dwarf_Attribute attr;
+
+ return (dwarf_tag(dw_die) == DW_TAG_subprogram &&
+ dwarf_attr(dw_die, DW_AT_declaration, &attr) == NULL);
+}
+
+/**
* die_get_data_member_location - Get the data-member offset
* @mb_die: a DIE of a member of a data structure
* @offs: The offset of the member in the data structure
@@ -392,6 +407,10 @@ static int __die_search_func_cb(Dwarf_Die *fn_die, void *data)
{
struct __addr_die_search_param *ad = data;
+ /*
+ * Since a declaration entry doesn't has given pc, this always returns
+ * function definition entry.
+ */
if (dwarf_tag(fn_die) == DW_TAG_subprogram &&
dwarf_haspc(fn_die, ad->addr)) {
memcpy(ad->die_mem, fn_die, sizeof(Dwarf_Die));
diff --git a/tools/perf/util/dwarf-aux.h b/tools/perf/util/dwarf-aux.h
index 6ce1717..8658d41 100644
--- a/tools/perf/util/dwarf-aux.h
+++ b/tools/perf/util/dwarf-aux.h
@@ -38,6 +38,9 @@ extern int cu_find_lineinfo(Dwarf_Die *cudie, unsigned long addr,
extern int cu_walk_functions_at(Dwarf_Die *cu_die, Dwarf_Addr addr,
int (*callback)(Dwarf_Die *, void *), void *data);
+/* Ensure that this DIE is a subprogram and definition (not declaration) */
+extern bool die_is_func_def(Dwarf_Die *dw_die);
+
/* Compare diename and tname */
extern bool die_compare_name(Dwarf_Die *dw_die, const char *tname);
diff --git a/tools/perf/util/probe-finder.c b/tools/perf/util/probe-finder.c
index be03293..20c7299 100644
--- a/tools/perf/util/probe-finder.c
+++ b/tools/perf/util/probe-finder.c
@@ -734,7 +734,7 @@ static int call_probe_finder(Dwarf_Die *sc_die, struct probe_finder *pf)
}
/* If not a real subprogram, find a real one */
- if (dwarf_tag(sc_die) != DW_TAG_subprogram) {
+ if (!die_is_func_def(sc_die)) {
if (!die_find_realfunc(&pf->cu_die, pf->addr, &pf->sp_die)) {
pr_warning("Failed to find probe point in any "
"functions.\n");
@@ -980,12 +980,10 @@ static int probe_point_search_cb(Dwarf_Die *sp_die, void *data)
struct dwarf_callback_param *param = data;
struct probe_finder *pf = param->data;
struct perf_probe_point *pp = &pf->pev->point;
- Dwarf_Attribute attr;
/* Check tag and diename */
- if (dwarf_tag(sp_die) != DW_TAG_subprogram ||
- !die_compare_name(sp_die, pp->function) ||
- dwarf_attr(sp_die, DW_AT_declaration, &attr))
+ if (!die_is_func_def(sp_die) ||
+ !die_compare_name(sp_die, pp->function))
return DWARF_CB_OK;
/* Check declared file */
@@ -1474,7 +1472,7 @@ static int line_range_inline_cb(Dwarf_Die *in_die, void *data)
return 0;
}
-/* Search function from function name */
+/* Search function definition from function name */
static int line_range_search_cb(Dwarf_Die *sp_die, void *data)
{
struct dwarf_callback_param *param = data;
@@ -1485,7 +1483,7 @@ static int line_range_search_cb(Dwarf_Die *sp_die, void *data)
if (lr->file && strtailcmp(lr->file, dwarf_decl_file(sp_die)))
return DWARF_CB_OK;
- if (dwarf_tag(sp_die) == DW_TAG_subprogram &&
+ if (die_is_func_def(sp_die) &&
die_compare_name(sp_die, lr->function)) {
lf->fname = dwarf_decl_file(sp_die);
dwarf_decl_line(sp_die, &lr->offset);
--
1.8.1.4
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH 8/9] perf tools: Fix old GCC build error in trace-event-parse.c:parse_proc_kallsyms()
2013-09-19 18:40 [GIT PULL 0/9] perf/urgent fixes Arnaldo Carvalho de Melo
` (6 preceding siblings ...)
2013-09-19 18:40 ` [PATCH 7/9] perf probe: Fix finder to find lines of given function Arnaldo Carvalho de Melo
@ 2013-09-19 18:40 ` Arnaldo Carvalho de Melo
2013-09-19 18:40 ` [PATCH 9/9] tools lib lk: Uninclude linux/magic.h in debugfs.c Arnaldo Carvalho de Melo
2013-09-20 5:15 ` [GIT PULL 0/9] perf/urgent fixes Ingo Molnar
9 siblings, 0 replies; 22+ messages in thread
From: Arnaldo Carvalho de Melo @ 2013-09-19 18:40 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Adrian Hunter, David Ahern, Frederic Weisbecker,
H. Peter Anvin, Jiri Olsa, Mike Galbraith, Namhyung Kim,
Paul Mackerras, Peter Zijlstra, Stephane Eranian, Thomas Gleixner,
Arnaldo Carvalho de Melo
From: Ingo Molnar <mingo@kernel.org>
Old GCC (4.1) does not see through the code flow of parse_proc_kallsyms()
and gets confused about the status of 'fmt':
util/trace-event-parse.c: In function ‘parse_proc_kallsyms’:
util/trace-event-parse.c:189: warning: ‘fmt’ may be used uninitialized in this function
make: *** [util/trace-event-parse.o] Error 1
Help out GCC by initializing 'fmt' to NULL.
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Namhyung Kim <namhyung@gmail.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/20130912131649.GC23826@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/trace-event-parse.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/trace-event-parse.c b/tools/perf/util/trace-event-parse.c
index fe7a27d..e9e1c03 100644
--- a/tools/perf/util/trace-event-parse.c
+++ b/tools/perf/util/trace-event-parse.c
@@ -186,7 +186,7 @@ void parse_proc_kallsyms(struct pevent *pevent,
char *next = NULL;
char *addr_str;
char *mod;
- char *fmt;
+ char *fmt = NULL;
line = strtok_r(file, "\n", &next);
while (line) {
--
1.8.1.4
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH 9/9] tools lib lk: Uninclude linux/magic.h in debugfs.c
2013-09-19 18:40 [GIT PULL 0/9] perf/urgent fixes Arnaldo Carvalho de Melo
` (7 preceding siblings ...)
2013-09-19 18:40 ` [PATCH 8/9] perf tools: Fix old GCC build error in trace-event-parse.c:parse_proc_kallsyms() Arnaldo Carvalho de Melo
@ 2013-09-19 18:40 ` Arnaldo Carvalho de Melo
2013-09-20 5:15 ` [GIT PULL 0/9] perf/urgent fixes Ingo Molnar
9 siblings, 0 replies; 22+ messages in thread
From: Arnaldo Carvalho de Melo @ 2013-09-19 18:40 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Vinson Lee, Borislav Petkov, Vinson Lee, stable,
Arnaldo Carvalho de Melo
From: Vinson Lee <vlee@twitter.com>
The compilation only looks for linux/magic.h from the default include
paths, which does not include the source tree. This results in a build
error if linux/magic.h is not available or not installed.
For example, this build error occurs on CentOS 5.
$ make -C tools/lib/lk V=1
[...]
gcc -o debugfs.o -c -ggdb3 -Wall -Wextra -std=gnu99 -Werror -O6
-D_FORTIFY_SOURCE=2 -Wbad-function-cast -Wdeclaration-after-statement
-Wformat-security -Wformat-y2k -Winit-self -Wmissing-declarations
-Wmissing-prototypes -Wnested-externs -Wno-system-headers
-Wold-style-definition -Wpacked -Wredundant-decls -Wshadow
-Wstrict-aliasing=3 -Wstrict-prototypes -Wswitch-default -Wswitch-enum
-Wundef -Wwrite-strings -Wformat -fPIC -D_LARGEFILE64_SOURCE
-D_FILE_OFFSET_BITS=64 debugfs.c
debugfs.c:8:25: error: linux/magic.h: No such file or directory
The only symbol from linux/magic.h needed by debugfs.c is DEBUGFS_MAGIC,
and that is already defined in debugfs.h. linux/magic.h isn't providing
any extra symbols and can unincluded. This is similar to the approach by
perf, which has its own magic.h wrapper at
tools/perf/util/include/linux/magic.h
Signed-off-by: Vinson Lee <vlee@twitter.com>
Acked-by: Borislav Petkov <bp@suse.de>
Cc: Borislav Petkov <bp@suse.de>
Cc: Vinson Lee <vlee@freedesktop.org>
Cc: stable@vger.kernel.org
Link: http://lkml.kernel.org/r/1379546200-17028-1-git-send-email-vlee@freedesktop.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/lib/lk/debugfs.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/lib/lk/debugfs.c b/tools/lib/lk/debugfs.c
index 099e7cd..7c43479 100644
--- a/tools/lib/lk/debugfs.c
+++ b/tools/lib/lk/debugfs.c
@@ -5,7 +5,6 @@
#include <stdbool.h>
#include <sys/vfs.h>
#include <sys/mount.h>
-#include <linux/magic.h>
#include <linux/kernel.h>
#include "debugfs.h"
--
1.8.1.4
^ permalink raw reply related [flat|nested] 22+ messages in thread
* Re: [GIT PULL 0/9] perf/urgent fixes
2013-09-19 18:40 [GIT PULL 0/9] perf/urgent fixes Arnaldo Carvalho de Melo
` (8 preceding siblings ...)
2013-09-19 18:40 ` [PATCH 9/9] tools lib lk: Uninclude linux/magic.h in debugfs.c Arnaldo Carvalho de Melo
@ 2013-09-20 5:15 ` Ingo Molnar
9 siblings, 0 replies; 22+ messages in thread
From: Ingo Molnar @ 2013-09-20 5:15 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Ananth N Mavinakayanahalli, Borislav Petkov, David Ahern,
Frederic Weisbecker, H. Peter Anvin, Jiri Olsa, Masami Hiramatsu,
Mike Galbraith, Namhyung Kim, Paul Mackerras, Peter Zijlstra,
Prashanth Nageshappa, Srikar Dronamraju, Stephane Eranian,
Steven Rostedt, Thomas Gleixner, Vinson Lee, Vinson Lee,
yrl.pp-manager.tt, Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:
> From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
>
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> The following changes since commit a8e0108cac181a7b141dacaa99ea52efaf9b5f07:
>
> perf: Fix UAPI export of PERF_EVENT_IOC_ID (2013-09-18 11:29:07 +0200)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-urgent-for-mingo
>
> for you to fetch changes up to ce7eebe5c3deef8e19c177c24ee75843256e69ca:
>
> tools lib lk: Uninclude linux/magic.h in debugfs.c (2013-09-19 15:08:53 -0300)
>
> ----------------------------------------------------------------
> perf/urgent fixes:
>
> . Check for SIGINT in more loops, allowing tools such as 'perf report' to
> react faster to control+C.
>
> . Fix objdump line parsing offset validation in the annotate code,
> from Adrian Hunter.
>
> . Fix buildid cache handling of kallsyms with kcore, from Adrian Hunter.
>
> . Fix compile with libelf without get_phdrnum, from Adrian Hunter.
>
> . Sharpen the libaudit dependencies test, refusing to build with older
> libraries that doesn't have all the functions used by 'perf trace", fix
> from Ingo Molnar.
>
> . Fill in new definitions for madvise()/mmap() flags to fix the build in
> older systems, from Ingo Molnar.
>
> . Fix old GCC build error in older systems in the kallsyms parsing code in
> trace-event-parse.c, from Ingo Molnar.
>
> . Ignore DWARF declaration tags, allowing, for instance, that the
>
> $ perf probe -L getname
>
> command succeeds in showing the source code for the 'getname' kernel
> function, telling in which lines probes can be inserted, fix from
> Masami Hiramatsu.
>
> . Fix linux/magic.h related build breakage in some systems, fix from
> Vinson Lee.
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Adrian Hunter (3):
> perf annotate: Fix objdump line parsing offset validation
> perf tools: Fix buildid cache handling of kallsyms with kcore
> perf tools: Fix compile with libelf without get_phdrnum
>
> Arnaldo Carvalho de Melo (1):
> perf session: Check for SIGINT in more loops
>
> Ingo Molnar (3):
> perf tools: Sharpen the libaudit dependencies test
> perf tools: Fill in new definitions for madvise()/mmap() flags
> perf tools: Fix old GCC build error in trace-event-parse.c:parse_proc_kallsyms()
>
> Masami Hiramatsu (1):
> perf probe: Fix finder to find lines of given function
>
> Vinson Lee (1):
> tools lib lk: Uninclude linux/magic.h in debugfs.c
>
> tools/lib/lk/debugfs.c | 1 -
> tools/perf/builtin-inject.c | 2 --
> tools/perf/builtin-report.c | 5 +++--
> tools/perf/builtin-script.c | 2 --
> tools/perf/builtin-trace.c | 17 +++++++++++++++
> tools/perf/config/Makefile | 3 +++
> tools/perf/config/feature-tests.mak | 10 +++++++++
> tools/perf/util/annotate.c | 2 +-
> tools/perf/util/dwarf-aux.c | 19 +++++++++++++++++
> tools/perf/util/dwarf-aux.h | 3 +++
> tools/perf/util/header.c | 41 +++++++++++++++++++++++++------------
> tools/perf/util/hist.c | 2 ++
> tools/perf/util/probe-finder.c | 12 +++++------
> tools/perf/util/session.c | 9 ++++++--
> tools/perf/util/session.h | 4 ++++
> tools/perf/util/symbol-elf.c | 16 +++++++++++++++
> tools/perf/util/trace-event-parse.c | 2 +-
> 17 files changed, 119 insertions(+), 31 deletions(-)
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 22+ messages in thread
* [GIT PULL 0/9] perf/urgent fixes
@ 2015-01-21 15:01 Arnaldo Carvalho de Melo
2015-01-28 14:42 ` Ingo Molnar
0 siblings, 1 reply; 22+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-01-21 15:01 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Borislav Petkov, David Ahern, Don Zickus, Frederic Weisbecker,
Jiri Olsa, Li Zefan, Masami Hiramatsu, Mike Galbraith,
Namhyung Kim, Paul Mackerras, Peter Zijlstra, Rabin Vincent,
Stephane Eranian, Wang Nan, Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit d01de2389c0190f5959f0a1258a2e87d2fe4ca82:
Merge tag 'perf-urgent-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent (2015-01-17 11:04:35 +0100)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-urgent-for-mingo
for you to fetch changes up to 25dd9171f51c482eb7c4dc8618766ae733756e2d:
perf probe: Fix probing kretprobes (2015-01-21 10:06:24 -0300)
----------------------------------------------------------------
perf/urgent fixes:
User visible:
- Fix probing at function return (Namhyumg Kim)
Developer stuff:
- Symbol processing changes necessary for fixing support for
kretprobes in 'perf probe' (Namhyung Kim, Arnaldo Carvalho de Melo)
- Annotation memory leaks and instruction parsing fixes (Rabin Vincent)
- Fix perl build on ARM64 (Wang Nam)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Arnaldo Carvalho de Melo (3):
perf evlist: Remove extraneous 'was' on error message
perf symbols: Introduce method to iterate symbols ordered by name
perf symbols: Introduce 'for' method to iterate over the symbols with a given name
Namhyung Kim (3):
perf symbols: Return the first entry with a given name in find_by_name method
perf probe: Do not rely on map__load() filter to find symbols
perf probe: Fix probing kretprobes
Rabin Vincent (2):
perf annotate: Handle ins parsing failures
perf annotate: Fix memory leaks in LOCK handling
Wang Nan (1):
perf scripting perl: Force to use stdbool
tools/perf/scripts/perl/Perf-Trace-Util/Context.c | 5 +++-
tools/perf/util/annotate.c | 18 +++++++++---
tools/perf/util/evlist.c | 2 +-
tools/perf/util/map.h | 16 +++++++++++
tools/perf/util/probe-event.c | 34 +++++++++++------------
tools/perf/util/symbol.c | 31 +++++++++++++++++++--
tools/perf/util/symbol.h | 1 +
7 files changed, 80 insertions(+), 27 deletions(-)
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [GIT PULL 0/9] perf/urgent fixes
2015-01-21 15:01 Arnaldo Carvalho de Melo
@ 2015-01-28 14:42 ` Ingo Molnar
0 siblings, 0 replies; 22+ messages in thread
From: Ingo Molnar @ 2015-01-28 14:42 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Adrian Hunter, Borislav Petkov, David Ahern,
Don Zickus, Frederic Weisbecker, Jiri Olsa, Li Zefan,
Masami Hiramatsu, Mike Galbraith, Namhyung Kim, Paul Mackerras,
Peter Zijlstra, Rabin Vincent, Stephane Eranian, Wang Nan,
Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> The following changes since commit d01de2389c0190f5959f0a1258a2e87d2fe4ca82:
>
> Merge tag 'perf-urgent-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent (2015-01-17 11:04:35 +0100)
>
> are available in the git repository at:
>
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-urgent-for-mingo
>
> for you to fetch changes up to 25dd9171f51c482eb7c4dc8618766ae733756e2d:
>
> perf probe: Fix probing kretprobes (2015-01-21 10:06:24 -0300)
>
> ----------------------------------------------------------------
> perf/urgent fixes:
>
> User visible:
>
> - Fix probing at function return (Namhyumg Kim)
>
> Developer stuff:
>
> - Symbol processing changes necessary for fixing support for
> kretprobes in 'perf probe' (Namhyung Kim, Arnaldo Carvalho de Melo)
>
> - Annotation memory leaks and instruction parsing fixes (Rabin Vincent)
>
> - Fix perl build on ARM64 (Wang Nam)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (3):
> perf evlist: Remove extraneous 'was' on error message
> perf symbols: Introduce method to iterate symbols ordered by name
> perf symbols: Introduce 'for' method to iterate over the symbols with a given name
>
> Namhyung Kim (3):
> perf symbols: Return the first entry with a given name in find_by_name method
> perf probe: Do not rely on map__load() filter to find symbols
> perf probe: Fix probing kretprobes
>
> Rabin Vincent (2):
> perf annotate: Handle ins parsing failures
> perf annotate: Fix memory leaks in LOCK handling
>
> Wang Nan (1):
> perf scripting perl: Force to use stdbool
>
> tools/perf/scripts/perl/Perf-Trace-Util/Context.c | 5 +++-
> tools/perf/util/annotate.c | 18 +++++++++---
> tools/perf/util/evlist.c | 2 +-
> tools/perf/util/map.h | 16 +++++++++++
> tools/perf/util/probe-event.c | 34 +++++++++++------------
> tools/perf/util/symbol.c | 31 +++++++++++++++++++--
> tools/perf/util/symbol.h | 1 +
> 7 files changed, 80 insertions(+), 27 deletions(-)
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 22+ messages in thread
* [GIT PULL 0/9] perf/urgent fixes
@ 2017-09-12 19:24 Arnaldo Carvalho de Melo
2017-09-13 7:26 ` Ingo Molnar
0 siblings, 1 reply; 22+ messages in thread
From: Arnaldo Carvalho de Melo @ 2017-09-12 19:24 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, linux-perf-users, Arnaldo Carvalho de Melo,
Adrian Hunter, David Ahern, Jiri Olsa, Milian Wolff, Namhyung Kim,
Peter Zijlstra, Taeung Song, Wang Nan, Yao Jin,
Arnaldo Carvalho de Melo
Hi Ingo,
So here it is the fixes in perf-core-for-mingo-4.14-20170912, as
requested, plus one last minute fix from Milian Wolff that helps with
using perf as an AppImage[1].
- Arnaldo
[1] http://appimage.org/
Test results at the end of this message, as usual.
The following changes since commit 770e96125515daf1c7bc179323f2e0d488dfe6ac:
Merge tag 'perf-core-for-mingo-4.14-20170901' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent (2017-09-05 07:14:28 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-urgent-for-mingo-4.14-20170912
for you to fetch changes up to dfc9eec7716cc0a9f7eb743c703d74cd2d6085a0:
perf stat: Wait for the correct child (2017-09-12 12:49:13 -0300)
----------------------------------------------------------------
perf/urgent fixes:
- Fix TUI progress bar when delta from new total from that of the
previous update is greater than the progress "step" (screen width
progress bar block)) (Jiri Olsa)
- Make tools/lib/api make DEBUG=1 build use -D_FORTIFY_SOURCE=2 not
to cripple debuginfo, just like tools/perf/ does (Jiri Olsa)
- Avoid leaking the 'perf.data' file to workloads started from the
'perf record' command line by using the O_CLOEXEC open flag (Jiri Olsa)
- Fix building when libunwind's 'unwind.h' file is present in the
include path, clashing with tools/perf/util/unwind.h (Milian Wolff)
- Check per .perfconfig section entry flag, not just per section (Taeung Song)
- Support running perf binaries with a dash in their name, needed to
run perf as an AppImage (Milian Wolff)
- Wait for the right child by using waitpid() when running workloads
from 'perf stat', also to fix using perf as an AppImage (Milian Wolff)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Arnaldo Carvalho de Melo (1):
tools include linux: Guard against redefinition of some macros
Jiri Olsa (4):
tools lib api: Fix make DEBUG=1 build
perf tools: Open perf.data with O_CLOEXEC flag
perf ui progress: Make sure we always define step value
perf ui progress: Fix progress update
Milian Wolff (3):
perf tests: Fix compile when libunwind's unwind.h is available
perf tools: Support running perf binaries with a dash in their name
perf stat: Wait for the correct child
Taeung Song (1):
perf config: Check not only section->from_system_config but also item's
tools/include/linux/compiler-gcc.h | 9 ++++++---
tools/lib/api/Makefile | 8 +++++++-
tools/perf/builtin-config.c | 2 +-
tools/perf/builtin-stat.c | 2 +-
tools/perf/perf.c | 14 ++++++++++----
tools/perf/tests/dwarf-unwind.c | 2 +-
tools/perf/ui/progress.c | 9 +++++++--
tools/perf/util/data.c | 13 ++++++++++++-
8 files changed, 45 insertions(+), 14 deletions(-)
Test results:
The first ones are container (docker) based builds of tools/perf with and
without libelf support, objtool where it is supported and samples/bpf/, ditto.
Where clang is available, it is also used to build perf with/without libelf.
Several are cross builds, the ones with -x-ARCH, and the android one, and those
may not have all the features built, due to lack of multi-arch devel packages,
available and being used so far on just a few, like
debian:experimental-x-{arm64,mipsel}.
The 'perf test' one will perform a variety of tests exercising
tools/perf/util/, tools/lib/{bpf,traceevent,etc}, as well as run perf
commands with a variety of command line event specifications to then
intercept the sys_perf_event syscall to check that the perf_event_attr
fields are set up as expected, among a variety of other unit tests.
The 'perf test' also runs shell scripts exercising the tools, checking
if they affect the system in certain ways, like setting up kprobes and
uprobes, request callchains for well known programs and check that they
are the expected ones, see if 'perf trace' beautifies system call
arguments correctly, etc.
Additionally, a new set of tests, script based, runs the tools in a live system,
setting probes in place that then gets used by 'perf trace', with its output
compared against expected results.
Then there is the 'make -C tools/perf build-test' ones, that build tools/perf/
with a variety of feature sets, exercising the build with an incomplete set of
features as well as with a complete one. It is planned to have it run on each
of the containers mentioned above, using some container orchestration
infrastructure. Get in contact if interested in helping having this in place.
# dm
1 alpine:3.4: Ok
2 alpine:3.5: Ok
3 alpine:3.6: Ok
4 alpine:edge: Ok
5 android-ndk:r12b-arm: Ok
6 android-ndk:r15c-arm: Ok
7 archlinux:latest: Ok
8 centos:5: Ok
9 centos:6: Ok
10 centos:7: Ok
11 debian:7: Ok
12 debian:8: Ok
13 debian:9: Ok
14 debian:experimental: Ok
15 debian:experimental-x-arm64: Ok
16 debian:experimental-x-mips: Ok
17 debian:experimental-x-mips64: Ok
18 debian:experimental-x-mipsel: Ok
19 fedora:20: Ok
20 fedora:21: Ok
21 fedora:22: Ok
22 fedora:23: Ok
23 fedora:24: Ok
24 fedora:24-x-ARC-uClibc: Ok
25 fedora:25: Ok
26 fedora:26: Ok
27 fedora:rawhide: Ok
28 mageia:5: Ok
29 opensuse:13.2: Ok
30 opensuse:42.1: Ok
31 opensuse:42.2: Ok
32 opensuse:42.3: Ok
33 opensuse:tumbleweed: Ok
34 oraclelinux:6: Ok
35 oraclelinux:7: Ok
36 ubuntu:12.04.5: Ok
37 ubuntu:14.04.4: Ok
38 ubuntu:14.04.4-x-linaro-arm64: Ok
39 ubuntu:15.10: Ok
40 ubuntu:16.04: Ok
41 ubuntu:16.04-x-arm: Ok
42 ubuntu:16.04-x-arm64: Ok
43 ubuntu:16.04-x-powerpc: Ok
44 ubuntu:16.04-x-powerpc64: Ok
45 ubuntu:16.04-x-powerpc64el: Ok
46 ubuntu:16.04-x-s390: Ok
47 ubuntu:16.10: Ok
48 ubuntu:17.04: Ok
49 ubuntu:17.10: Ok
#
# uname -a
Linux jouet 4.13.0-rc7+ #3 SMP Sat Sep 2 09:04:44 -03 2017 x86_64 x86_64 x86_64 GNU/Linux
# perf test
1: vmlinux symtab matches kallsyms : Ok
2: Detect openat syscall event : Ok
3: Detect openat syscall event on all cpus : Ok
4: Read samples using the mmap interface : Ok
5: Test data source output : Ok
6: Parse event definition strings : Ok
7: Simple expression parser : Ok
8: PERF_RECORD_* events & perf_sample fields : Ok
9: Parse perf pmu format : Ok
10: DSO data read : Ok
11: DSO data cache : Ok
12: DSO data reopen : Ok
13: Roundtrip evsel->name : Ok
14: Parse sched tracepoints fields : Ok
15: syscalls:sys_enter_openat event fields : Ok
16: Setup struct perf_event_attr : Ok
17: Match and link multiple hists : Ok
18: 'import perf' in python : Ok
19: Breakpoint overflow signal handler : Ok
20: Breakpoint overflow sampling : Ok
21: Number of exit events of a simple workload : Ok
22: Software clock events period values : Ok
23: Object code reading : Ok
24: Sample parsing : Ok
25: Use a dummy software event to keep tracking : Ok
26: Parse with no sample_id_all bit set : Ok
27: Filter hist entries : Ok
28: Lookup mmap thread : Ok
29: Share thread mg : Ok
30: Sort output of hist entries : Ok
31: Cumulate child hist entries : Ok
32: Track with sched_switch : Ok
33: Filter fds with revents mask in a fdarray : Ok
34: Add fd to a fdarray, making it autogrow : Ok
35: kmod_path__parse : Ok
36: Thread map : Ok
37: LLVM search and compile :
37.1: Basic BPF llvm compile : Ok
37.2: kbuild searching : Ok
37.3: Compile source for BPF prologue generation : Ok
37.4: Compile source for BPF relocation : Ok
38: Session topology : Ok
39: BPF filter :
39.1: Basic BPF filtering : Ok
39.2: BPF pinning : Ok
39.3: BPF prologue generation : Ok
39.4: BPF relocation checker : Ok
40: Synthesize thread map : Ok
41: Remove thread map : Ok
42: Synthesize cpu map : Ok
43: Synthesize stat config : Ok
44: Synthesize stat : Ok
45: Synthesize stat round : Ok
46: Synthesize attr update : Ok
47: Event times : Ok
48: Read backward ring buffer : Ok
49: Print cpu map : Ok
50: Probe SDT events : Ok
51: is_printable_array : Ok
52: Print bitmap : Ok
53: perf hooks : Ok
54: builtin clang support : Skip (not compiled in)
55: unit_number__scnprintf : Ok
56: x86 rdpmc : Ok
57: Convert perf time to TSC : Ok
58: DWARF unwind : Ok
59: x86 instruction decoder - new instructions : Ok
60: Intel cqm nmi context read : Skip
61: Use vfs_getname probe to get syscall args filenames : Ok
62: probe libc's inet_pton & backtrace it with ping : Ok
63: Check open filename arg using perf trace + vfs_getname: Ok
64: Add vfs_getname probe to get syscall args filenames : Ok
#
$ make -C tools/perf build-test
make: Entering directory '/home/acme/git/linux/tools/perf'
- tarpkg: ./tests/perf-targz-src-pkg .
make_util_map_o_O: make util/map.o
make_no_demangle_O: make NO_DEMANGLE=1
make_doc_O: make doc
make_no_libperl_O: make NO_LIBPERL=1
make_clean_all_O: make clean all
make_tags_O: make tags
make_util_pmu_bison_o_O: make util/pmu-bison.o
make_no_libelf_O: make NO_LIBELF=1
make_with_babeltrace_O: make LIBBABELTRACE=1
make_no_libbpf_O: make NO_LIBBPF=1
make_no_libpython_O: make NO_LIBPYTHON=1
make_no_newt_O: make NO_NEWT=1
make_debug_O: make DEBUG=1
make_no_libbionic_O: make NO_LIBBIONIC=1
make_with_clangllvm_O: make LIBCLANGLLVM=1
make_static_O: make LDFLAGS=-static
make_perf_o_O: make perf.o
make_no_ui_O: make NO_NEWT=1 NO_SLANG=1 NO_GTK2=1
make_install_O: make install
make_no_libunwind_O: make NO_LIBUNWIND=1
make_install_prefix_slash_O: make install prefix=/tmp/krava/
make_no_gtk2_O: make NO_GTK2=1
make_no_libaudit_O: make NO_LIBAUDIT=1
make_no_libnuma_O: make NO_LIBNUMA=1
make_no_backtrace_O: make NO_BACKTRACE=1
make_install_prefix_O: make install prefix=/tmp/krava
make_no_scripts_O: make NO_LIBPYTHON=1 NO_LIBPERL=1
make_no_libdw_dwarf_unwind_O: make NO_LIBDW_DWARF_UNWIND=1
make_no_slang_O: make NO_SLANG=1
make_no_auxtrace_O: make NO_AUXTRACE=1
make_minimal_O: make NO_LIBPERL=1 NO_LIBPYTHON=1 NO_NEWT=1 NO_GTK2=1 NO_DEMANGLE=1 NO_LIBELF=1 NO_LIBUNWIND=1 NO_BACKTRACE=1 NO_LIBNUMA=1 NO_LIBAUDIT=1 NO_LIBBIONIC=1 NO_LIBDW_DWARF_UNWIND=1 NO_AUXTRACE=1 NO_LIBBPF=1 NO_LIBCRYPTO=1 NO_SDT=1 NO_JVMTI=1
make_pure_O: make
make_install_bin_O: make install-bin
make_help_O: make help
OK
make: Leaving directory '/home/acme/git/linux/tools/perf'
$
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [GIT PULL 0/9] perf/urgent fixes
2017-09-12 19:24 Arnaldo Carvalho de Melo
@ 2017-09-13 7:26 ` Ingo Molnar
0 siblings, 0 replies; 22+ messages in thread
From: Ingo Molnar @ 2017-09-13 7:26 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, linux-perf-users, Adrian Hunter, David Ahern,
Jiri Olsa, Milian Wolff, Namhyung Kim, Peter Zijlstra,
Taeung Song, Wang Nan, Yao Jin, Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> So here it is the fixes in perf-core-for-mingo-4.14-20170912, as
> requested, plus one last minute fix from Milian Wolff that helps with
> using perf as an AppImage[1].
>
> - Arnaldo
>
> [1] http://appimage.org/
>
> Test results at the end of this message, as usual.
>
> The following changes since commit 770e96125515daf1c7bc179323f2e0d488dfe6ac:
>
> Merge tag 'perf-core-for-mingo-4.14-20170901' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent (2017-09-05 07:14:28 +0200)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-urgent-for-mingo-4.14-20170912
>
> for you to fetch changes up to dfc9eec7716cc0a9f7eb743c703d74cd2d6085a0:
>
> perf stat: Wait for the correct child (2017-09-12 12:49:13 -0300)
>
> ----------------------------------------------------------------
> perf/urgent fixes:
>
> - Fix TUI progress bar when delta from new total from that of the
> previous update is greater than the progress "step" (screen width
> progress bar block)) (Jiri Olsa)
>
> - Make tools/lib/api make DEBUG=1 build use -D_FORTIFY_SOURCE=2 not
> to cripple debuginfo, just like tools/perf/ does (Jiri Olsa)
>
> - Avoid leaking the 'perf.data' file to workloads started from the
> 'perf record' command line by using the O_CLOEXEC open flag (Jiri Olsa)
>
> - Fix building when libunwind's 'unwind.h' file is present in the
> include path, clashing with tools/perf/util/unwind.h (Milian Wolff)
>
> - Check per .perfconfig section entry flag, not just per section (Taeung Song)
>
> - Support running perf binaries with a dash in their name, needed to
> run perf as an AppImage (Milian Wolff)
>
> - Wait for the right child by using waitpid() when running workloads
> from 'perf stat', also to fix using perf as an AppImage (Milian Wolff)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (1):
> tools include linux: Guard against redefinition of some macros
>
> Jiri Olsa (4):
> tools lib api: Fix make DEBUG=1 build
> perf tools: Open perf.data with O_CLOEXEC flag
> perf ui progress: Make sure we always define step value
> perf ui progress: Fix progress update
>
> Milian Wolff (3):
> perf tests: Fix compile when libunwind's unwind.h is available
> perf tools: Support running perf binaries with a dash in their name
> perf stat: Wait for the correct child
>
> Taeung Song (1):
> perf config: Check not only section->from_system_config but also item's
>
> tools/include/linux/compiler-gcc.h | 9 ++++++---
> tools/lib/api/Makefile | 8 +++++++-
> tools/perf/builtin-config.c | 2 +-
> tools/perf/builtin-stat.c | 2 +-
> tools/perf/perf.c | 14 ++++++++++----
> tools/perf/tests/dwarf-unwind.c | 2 +-
> tools/perf/ui/progress.c | 9 +++++++--
> tools/perf/util/data.c | 13 ++++++++++++-
> 8 files changed, 45 insertions(+), 14 deletions(-)
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 22+ messages in thread
* [GIT PULL 0/9] perf/urgent fixes
@ 2018-03-06 17:23 Arnaldo Carvalho de Melo
2018-03-07 8:22 ` Ingo Molnar
0 siblings, 1 reply; 22+ messages in thread
From: Arnaldo Carvalho de Melo @ 2018-03-06 17:23 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, linux-perf-users, Arnaldo Carvalho de Melo,
Adrian Hunter, Alexander Shishkin, Andi Kleen, Cong Wang,
David Ahern, David Woodhouse, Ilya Pronin, Jin Yao, Jiri Olsa,
Kan Liang, Linus Torvalds, Namhyung Kim, Peter Zijlstra,
Radim Krčmář, Sangwon Hong, stable, Taeung Song,
Tom Lendacky, Wang Nan, Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
Test results at the end of this message, as usual.
The following changes since commit 58bdf601c2de6071d0386a7a6fa707bd04761c47:
Merge branch 'i2c/for-current-fixed' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux (2018-03-03 14:55:20 -0800)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-urgent-for-mingo-4.16-20180306
for you to fetch changes up to 8f2c9efabe1ed212b88ce1c5cf5e768385c9222e:
perf record: Combine some auxtrace initialization into a single function (2018-03-06 12:03:39 -0300)
----------------------------------------------------------------
perf/urgent fixes:
- Be more robust when drawing arrows in the annotation TUI, avoiding a
segfault when jump instructions have as a target addresses in functions
other that the one currently being annotated. The full fix will come in
the following days, when jumping to other functions will work as call
instructions (Arnaldo Carvalho de Melo)
- Prevent auxtrace_queues__process_index() from queuing AUX area data for
decoding when the --no-itrace option has been used (Adrian Hunter)
- Sync copy of kvm UAPI headers and x86's cpufeatures.h (Arnaldo Carvalho de Melo)
- Fix 'perf stat' CVS output format for non-supported counters (Ilya Pronin)
- Fix crash in 'perf record|perf report' pipe mode (Jiri Olsa)
- Fix annoying 'perf top' overwrite fallback message on older kernels (Kan Liang)
- Fix the usage on the 'perf kallsyms' man page (Sangwon Hong)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
The following changes since commit 317660940fd9dddd3201c2f92e25c27902c753fa:
perf/x86/intel/uncore: Fix Skylake UPI event format (2018-03-04 09:59:00 +0100)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-urgent-for-mingo-4.16-20180306
for you to fetch changes up to de19e5c3c51fdb1ff20d0f61d099db902ff7494b:
perf tools: Fix trigger class trigger_on() (2018-03-06 11:31:14 -0300)
----------------------------------------------------------------
perf/urgent fixes:
- Be more robust when drawing arrows in the annotation TUI, avoiding a
segfault when jump instructions have as a target addresses in functions
other that the one currently being annotated. The full fix will come in
the following days, when jumping to other functions will work as call
instructions (Arnaldo Carvalho de Melo)
- Prevent auxtrace_queues__process_index() from queuing AUX area data for
decoding when the --no-itrace option has been used (Adrian Hunter)
- Sync copy of kvm UAPI headers and x86's cpufeatures.h (Arnaldo Carvalho de Melo)
- Fix 'perf stat' CSV output format for non-supported counters (Ilya Pronin)
- Fix crash in 'perf record|perf report' pipe mode (Jiri Olsa)
- Fix annoying 'perf top' overwrite fallback message on older kernels (Kan Liang)
- Fix the usage on the 'perf kallsyms' man page (Sangwon Hong)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Adrian Hunter (2):
perf auxtrace: Prevent decoding when --no-itrace
perf tools: Fix trigger class trigger_on()
Arnaldo Carvalho de Melo (3):
perf annotate browser: Be more robust when drawing jump arrows
tools headers: Sync copy of kvm UAPI headers
tools headers: Sync x86's cpufeatures.h
Ilya Pronin (1):
perf stat: Fix CVS output format for non-supported counters
Jiri Olsa (1):
perf record: Fix crash in pipe mode
Kan Liang (1):
perf top: Fix annoying fallback message on older kernels
Sangwon Hong (1):
perf kallsyms: Fix the usage on the man page
tools/arch/x86/include/asm/cpufeatures.h | 1 +
tools/include/uapi/linux/kvm.h | 2 ++
tools/perf/Documentation/perf-kallsyms.txt | 2 +-
tools/perf/builtin-record.c | 9 +++++++++
tools/perf/builtin-stat.c | 2 +-
tools/perf/builtin-top.c | 2 +-
tools/perf/perf.h | 1 +
tools/perf/ui/browsers/annotate.c | 25 +++++++++++++++++++++++++
tools/perf/util/auxtrace.c | 15 +++++++++------
tools/perf/util/record.c | 8 ++++++--
tools/perf/util/trigger.h | 9 +++++----
11 files changed, 61 insertions(+), 15 deletions(-)
Test results:
The first ones are container (docker) based builds of tools/perf with and
without libelf support. Where clang is available, it is also used to build
perf with/without libelf.
The objtool and samples/bpf/ builds are disabled now that I'm switching from
using the sources in a local volume to fetching them from a http server to
build it inside the container, to make it easier to build in a container cluster.
Those will come back later.
Several are cross builds, the ones with -x-ARCH and the android one, and those
may not have all the features built, due to lack of multi-arch devel packages,
available and being used so far on just a few, like
debian:experimental-x-{arm64,mipsel}.
The 'perf test' one will perform a variety of tests exercising
tools/perf/util/, tools/lib/{bpf,traceevent,etc}, as well as run perf commands
with a variety of command line event specifications to then intercept the
sys_perf_event syscall to check that the perf_event_attr fields are set up as
expected, among a variety of other unit tests.
Then there is the 'make -C tools/perf build-test' ones, that build tools/perf/
with a variety of feature sets, exercising the build with an incomplete set of
features as well as with a complete one. It is planned to have it run on each
of the containers mentioned above, using some container orchestration
infrastructure. Get in contact if interested in helping having this in place.
# dm
1 alpine:3.4 : Ok gcc (Alpine 5.3.0) 5.3.0
2 alpine:3.5 : Ok gcc (Alpine 6.2.1) 6.2.1 20160822
3 alpine:3.6 : Ok gcc (Alpine 6.3.0) 6.3.0
4 alpine:edge : Ok gcc (Alpine 6.4.0) 6.4.0
5 amazonlinux:1 : Ok gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-11)
6 amazonlinux:2 : Ok gcc (GCC) 7.2.1 20170915 (Red Hat 7.2.1-2)
7 android-ndk:r12b-arm : Ok arm-linux-androideabi-gcc (GCC) 4.9.x 20150123 (prerelease)
8 android-ndk:r15c-arm : Ok arm-linux-androideabi-gcc (GCC) 4.9.x 20150123 (prerelease)
9 centos:5 : Ok gcc (GCC) 4.1.2 20080704 (Red Hat 4.1.2-55)
10 centos:6 : Ok gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-18)
11 centos:7 : Ok gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-16)
12 debian:7 : Ok gcc (Debian 4.7.2-5) 4.7.2
13 debian:8 : Ok gcc (Debian 4.9.2-10+deb8u1) 4.9.2
14 debian:9 : Ok gcc (Debian 6.3.0-18) 6.3.0 20170516
15 debian:experimental : Ok gcc (Debian 7.2.0-17) 7.2.1 20171205
16 debian:experimental-x-arm64 : Ok aarch64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
17 debian:experimental-x-mips : Ok mips-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
18 debian:experimental-x-mips64 : Ok mips64-linux-gnuabi64-gcc (Debian 7.2.0-11) 7.2.0
19 debian:experimental-x-mipsel : Ok mipsel-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
20 fedora:20 : Ok gcc (GCC) 4.8.3 20140911 (Red Hat 4.8.3-7)
21 fedora:21 : Ok gcc (GCC) 4.9.2 20150212 (Red Hat 4.9.2-6)
22 fedora:22 : Ok gcc (GCC) 5.3.1 20160406 (Red Hat 5.3.1-6)
23 fedora:23 : Ok gcc (GCC) 5.3.1 20160406 (Red Hat 5.3.1-6)
24 fedora:24 : Ok gcc (GCC) 6.3.1 20161221 (Red Hat 6.3.1-1)
25 fedora:24-x-ARC-uClibc : Ok arc-linux-gcc (ARCompact ISA Linux uClibc toolchain 2017.09-rc2) 7.1.1 20170710
26 fedora:25 : Ok gcc (GCC) 6.4.1 20170727 (Red Hat 6.4.1-1)
27 fedora:26 : Ok gcc (GCC) 7.2.1 20170915 (Red Hat 7.2.1-2)
28 fedora:27 : Ok gcc (GCC) 7.2.1 20170915 (Red Hat 7.2.1-2)
29 fedora:rawhide : Ok gcc (GCC) 7.2.1 20170829 (Red Hat 7.2.1-1)
30 gentoo-stage3-amd64:latest : Ok gcc (Gentoo 6.4.0-r1 p1.3) 6.4.0
31 mageia:5 : Ok gcc (GCC) 4.9.2
32 mageia:6 : Ok gcc (Mageia 5.4.0-5.mga6) 5.4.0
33 opensuse:42.1 : Ok gcc (SUSE Linux) 4.8.5
34 opensuse:42.2 : Ok gcc (SUSE Linux) 4.8.5
35 opensuse:42.3 : Ok gcc (SUSE Linux) 4.8.5
36 opensuse:tumbleweed : Ok gcc (SUSE Linux) 7.3.0
37 oraclelinux:6 : Ok gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-18)
38 oraclelinux:7 : Ok gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-16)
39 ubuntu:12.04.5 : Ok gcc (Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3
40 ubuntu:14.04.4 : Ok gcc (Ubuntu 4.8.4-2ubuntu1~14.04.3) 4.8.4
41 ubuntu:14.04.4-x-linaro-arm64 : Ok aarch64-linux-gnu-gcc (Linaro GCC 5.4-2017.05) 5.4.1 20170404
42 ubuntu:15.04 : Ok gcc (Ubuntu 4.9.2-10ubuntu13) 4.9.2
43 ubuntu:16.04 : Ok gcc (Ubuntu 5.4.0-6ubuntu1~16.04.5) 5.4.0 20160609
44 ubuntu:16.04-x-arm : Ok arm-linux-gnueabihf-gcc (Ubuntu/Linaro 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609
45 ubuntu:16.04-x-arm64 : Ok aarch64-linux-gnu-gcc (Ubuntu/Linaro 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609
46 ubuntu:16.04-x-powerpc : Ok powerpc-linux-gnu-gcc (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609
47 ubuntu:16.04-x-powerpc64 : Ok powerpc64-linux-gnu-gcc (Ubuntu/IBM 5.4.0-6ubuntu1~16.04.1) 5.4.0 20160609
48 ubuntu:16.04-x-powerpc64el : Ok powerpc64le-linux-gnu-gcc (Ubuntu/IBM 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609
49 ubuntu:16.04-x-s390 : Ok s390x-linux-gnu-gcc (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609
50 ubuntu:16.10 : Ok gcc (Ubuntu 6.2.0-5ubuntu12) 6.2.0 20161005
51 ubuntu:17.04 : Ok gcc (Ubuntu 6.3.0-12ubuntu2) 6.3.0 20170406
52 ubuntu:17.10 : Ok gcc (Ubuntu 7.2.0-8ubuntu3) 7.2.0
53 ubuntu:18.04 : Ok gcc (Ubuntu 7.2.0-16ubuntu1) 7.2.0
# uname -a
Linux jouet 4.16.0-rc4 #1 SMP Mon Mar 5 12:18:05 -03 2018 x86_64 x86_64 x86_64 GNU/Linux
# perf test
1: vmlinux symtab matches kallsyms : Ok
2: Detect openat syscall event : Ok
3: Detect openat syscall event on all cpus : Ok
4: Read samples using the mmap interface : Ok
5: Test data source output : Ok
6: Parse event definition strings : Ok
7: Simple expression parser : Ok
8: PERF_RECORD_* events & perf_sample fields : Ok
9: Parse perf pmu format : Ok
10: DSO data read : Ok
11: DSO data cache : Ok
12: DSO data reopen : Ok
13: Roundtrip evsel->name : Ok
14: Parse sched tracepoints fields : Ok
15: syscalls:sys_enter_openat event fields : Ok
16: Setup struct perf_event_attr : Ok
17: Match and link multiple hists : Ok
18: 'import perf' in python : Ok
19: Breakpoint overflow signal handler : Ok
20: Breakpoint overflow sampling : Ok
21: Number of exit events of a simple workload : Ok
22: Software clock events period values : Ok
23: Object code reading : Ok
24: Sample parsing : Ok
25: Use a dummy software event to keep tracking : Ok
26: Parse with no sample_id_all bit set : Ok
27: Filter hist entries : Ok
28: Lookup mmap thread : Ok
29: Share thread mg : Ok
30: Sort output of hist entries : Ok
31: Cumulate child hist entries : Ok
32: Track with sched_switch : Ok
33: Filter fds with revents mask in a fdarray : Ok
34: Add fd to a fdarray, making it autogrow : Ok
35: kmod_path__parse : Ok
36: Thread map : Ok
37: LLVM search and compile :
37.1: Basic BPF llvm compile : Ok
37.2: kbuild searching : Ok
37.3: Compile source for BPF prologue generation : Ok
37.4: Compile source for BPF relocation : Ok
38: Session topology : Ok
39: BPF filter :
39.1: Basic BPF filtering : Ok
39.2: BPF pinning : Ok
39.3: BPF prologue generation : Ok
39.4: BPF relocation checker : Ok
40: Synthesize thread map : Ok
41: Remove thread map : Ok
42: Synthesize cpu map : Ok
43: Synthesize stat config : Ok
44: Synthesize stat : Ok
45: Synthesize stat round : Ok
46: Synthesize attr update : Ok
47: Event times : Ok
48: Read backward ring buffer : Ok
49: Print cpu map : Ok
50: Probe SDT events : Ok
51: is_printable_array : Ok
52: Print bitmap : Ok
53: perf hooks : Ok
54: builtin clang support : Skip (not compiled in)
55: unit_number__scnprintf : Ok
56: x86 rdpmc : Ok
57: Convert perf time to TSC : Ok
58: DWARF unwind : Ok
59: x86 instruction decoder - new instructions : Ok
60: Use vfs_getname probe to get syscall args filenames : Ok
61: probe libc's inet_pton & backtrace it with ping : Ok
62: Check open filename arg using perf trace + vfs_getname: Ok
63: probe libc's inet_pton & backtrace it with ping : Ok
64: Add vfs_getname probe to get syscall args filenames : Ok
#
$ make -C tools/perf build-test
make: Entering directory '/home/acme/git/perf/tools/perf'
- tarpkg: ./tests/perf-targz-src-pkg .
make_no_auxtrace_O: make NO_AUXTRACE=1
make_debug_O: make DEBUG=1
make_no_gtk2_O: make NO_GTK2=1
make_install_bin_O: make install-bin
make_no_slang_O: make NO_SLANG=1
make_no_newt_O: make NO_NEWT=1
make_no_scripts_O: make NO_LIBPYTHON=1 NO_LIBPERL=1
make_no_ui_O: make NO_NEWT=1 NO_SLANG=1 NO_GTK2=1
make_perf_o_O: make perf.o
make_util_map_o_O: make util/map.o
make_pure_O: make
make_install_prefix_O: make install prefix=/tmp/krava
make_with_clangllvm_O: make LIBCLANGLLVM=1
make_util_pmu_bison_o_O: make util/pmu-bison.o
make_no_libpython_O: make NO_LIBPYTHON=1
make_no_libelf_O: make NO_LIBELF=1
make_install_O: make install
make_help_O: make help
make_clean_all_O: make clean all
make_no_libaudit_O: make NO_LIBAUDIT=1
make_doc_O: make doc
make_tags_O: make tags
make_no_libdw_dwarf_unwind_O: make NO_LIBDW_DWARF_UNWIND=1
make_install_prefix_slash_O: make install prefix=/tmp/krava/
make_no_backtrace_O: make NO_BACKTRACE=1
make_no_demangle_O: make NO_DEMANGLE=1
make_no_libbionic_O: make NO_LIBBIONIC=1
make_no_libnuma_O: make NO_LIBNUMA=1
make_with_babeltrace_O: make LIBBABELTRACE=1
make_no_libunwind_O: make NO_LIBUNWIND=1
make_minimal_O: make NO_LIBPERL=1 NO_LIBPYTHON=1 NO_NEWT=1 NO_GTK2=1 NO_DEMANGLE=1 NO_LIBELF=1 NO_LIBUNWIND=1 NO_BACKTRACE=1 NO_LIBNUMA=1 NO_LIBAUDIT=1 NO_LIBBIONIC=1 NO_LIBDW_DWARF_UNWIND=1 NO_AUXTRACE=1 NO_LIBBPF=1 NO_LIBCRYPTO=1 NO_SDT=1 NO_JVMTI=1
make_no_libperl_O: make NO_LIBPERL=1
make_no_libbpf_O: make NO_LIBBPF=1
make_static_O: make LDFLAGS=-static
OK
make: Leaving directory '/home/acme/git/perf/tools/perf'
$
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [GIT PULL 0/9] perf/urgent fixes
2018-03-06 17:23 Arnaldo Carvalho de Melo
@ 2018-03-07 8:22 ` Ingo Molnar
2018-03-07 14:23 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 22+ messages in thread
From: Ingo Molnar @ 2018-03-07 8:22 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, linux-perf-users, Adrian Hunter, Alexander Shishkin,
Andi Kleen, Cong Wang, David Ahern, David Woodhouse, Ilya Pronin,
Jin Yao, Jiri Olsa, Kan Liang, Linus Torvalds, Namhyung Kim,
Peter Zijlstra, Radim Krčmář, Sangwon Hong, stable,
Taeung Song, Tom Lendacky, Wang Nan, Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> Test results at the end of this message, as usual.
>
> The following changes since commit 58bdf601c2de6071d0386a7a6fa707bd04761c47:
>
> Merge branch 'i2c/for-current-fixed' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux (2018-03-03 14:55:20 -0800)
>
> are available in the Git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-urgent-for-mingo-4.16-20180306
>
> for you to fetch changes up to 8f2c9efabe1ed212b88ce1c5cf5e768385c9222e:
>
> perf record: Combine some auxtrace initialization into a single function (2018-03-06 12:03:39 -0300)
>
> ----------------------------------------------------------------
> perf/urgent fixes:
>
> - Be more robust when drawing arrows in the annotation TUI, avoiding a
> segfault when jump instructions have as a target addresses in functions
> other that the one currently being annotated. The full fix will come in
> the following days, when jumping to other functions will work as call
> instructions (Arnaldo Carvalho de Melo)
>
> - Prevent auxtrace_queues__process_index() from queuing AUX area data for
> decoding when the --no-itrace option has been used (Adrian Hunter)
>
> - Sync copy of kvm UAPI headers and x86's cpufeatures.h (Arnaldo Carvalho de Melo)
>
> - Fix 'perf stat' CVS output format for non-supported counters (Ilya Pronin)
>
> - Fix crash in 'perf record|perf report' pipe mode (Jiri Olsa)
>
> - Fix annoying 'perf top' overwrite fallback message on older kernels (Kan Liang)
>
> - Fix the usage on the 'perf kallsyms' man page (Sangwon Hong)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> The following changes since commit 317660940fd9dddd3201c2f92e25c27902c753fa:
>
> perf/x86/intel/uncore: Fix Skylake UPI event format (2018-03-04 09:59:00 +0100)
>
> are available in the Git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-urgent-for-mingo-4.16-20180306
>
> for you to fetch changes up to de19e5c3c51fdb1ff20d0f61d099db902ff7494b:
>
> perf tools: Fix trigger class trigger_on() (2018-03-06 11:31:14 -0300)
>
> ----------------------------------------------------------------
> perf/urgent fixes:
>
> - Be more robust when drawing arrows in the annotation TUI, avoiding a
> segfault when jump instructions have as a target addresses in functions
> other that the one currently being annotated. The full fix will come in
> the following days, when jumping to other functions will work as call
> instructions (Arnaldo Carvalho de Melo)
>
> - Prevent auxtrace_queues__process_index() from queuing AUX area data for
> decoding when the --no-itrace option has been used (Adrian Hunter)
>
> - Sync copy of kvm UAPI headers and x86's cpufeatures.h (Arnaldo Carvalho de Melo)
>
> - Fix 'perf stat' CSV output format for non-supported counters (Ilya Pronin)
>
> - Fix crash in 'perf record|perf report' pipe mode (Jiri Olsa)
>
> - Fix annoying 'perf top' overwrite fallback message on older kernels (Kan Liang)
>
> - Fix the usage on the 'perf kallsyms' man page (Sangwon Hong)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Adrian Hunter (2):
> perf auxtrace: Prevent decoding when --no-itrace
> perf tools: Fix trigger class trigger_on()
>
> Arnaldo Carvalho de Melo (3):
> perf annotate browser: Be more robust when drawing jump arrows
> tools headers: Sync copy of kvm UAPI headers
> tools headers: Sync x86's cpufeatures.h
>
> Ilya Pronin (1):
> perf stat: Fix CVS output format for non-supported counters
>
> Jiri Olsa (1):
> perf record: Fix crash in pipe mode
>
> Kan Liang (1):
> perf top: Fix annoying fallback message on older kernels
>
> Sangwon Hong (1):
> perf kallsyms: Fix the usage on the man page
>
> tools/arch/x86/include/asm/cpufeatures.h | 1 +
> tools/include/uapi/linux/kvm.h | 2 ++
> tools/perf/Documentation/perf-kallsyms.txt | 2 +-
> tools/perf/builtin-record.c | 9 +++++++++
> tools/perf/builtin-stat.c | 2 +-
> tools/perf/builtin-top.c | 2 +-
> tools/perf/perf.h | 1 +
> tools/perf/ui/browsers/annotate.c | 25 +++++++++++++++++++++++++
> tools/perf/util/auxtrace.c | 15 +++++++++------
> tools/perf/util/record.c | 8 ++++++--
> tools/perf/util/trigger.h | 9 +++++----
> 11 files changed, 61 insertions(+), 15 deletions(-)
Pulled, thanks a lot Arnaldo!
Note that there's a new, minor conflict between perf/core and perf/urgent - I
resolved it and merged perf/urgent into perf/core, please double check my
resolution.
Ingo
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [GIT PULL 0/9] perf/urgent fixes
2018-03-07 8:22 ` Ingo Molnar
@ 2018-03-07 14:23 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 22+ messages in thread
From: Arnaldo Carvalho de Melo @ 2018-03-07 14:23 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, linux-perf-users, Adrian Hunter, Alexander Shishkin,
Andi Kleen, Cong Wang, David Ahern, David Woodhouse, Ilya Pronin,
Jin Yao, Jiri Olsa, Kan Liang, Linus Torvalds, Namhyung Kim,
Peter Zijlstra, Radim Krčmář, Sangwon Hong, stable,
Taeung Song, Tom Lendacky, Wang Nan, Arnaldo Carvalho de Melo
Em Wed, Mar 07, 2018 at 09:22:58AM +0100, Ingo Molnar escreveu:
> Pulled, thanks a lot Arnaldo!
> Note that there's a new, minor conflict between perf/core and perf/urgent - I
> resolved it and merged perf/urgent into perf/core, please double check my
> resolution.
Thanks, everything seems well and dandy,
- Arnaldo
^ permalink raw reply [flat|nested] 22+ messages in thread
* [GIT PULL 0/9] perf/urgent fixes
@ 2019-12-16 20:47 Arnaldo Carvalho de Melo
2019-12-17 11:28 ` Ingo Molnar
0 siblings, 1 reply; 22+ messages in thread
From: Arnaldo Carvalho de Melo @ 2019-12-16 20:47 UTC (permalink / raw)
To: Ingo Molnar, Thomas Gleixner
Cc: Jiri Olsa, Namhyung Kim, Clark Williams, linux-kernel,
linux-perf-users, Arnaldo Carvalho de Melo, Ed Maste, John Garry,
Kajol Jain, Mark Rutland, Michael Petlan, Ravi Bangoria,
Sudipm Mukherjee, Arnaldo Carvalho de Melo
Hi Ingo/Thomas,
Please consider pulling,
Best regards,
- Arnaldo
The following changes since commit 761bfc33dd7504de951aa7b9db27a3cc5df1fde6:
Merge remote-tracking branch 'torvalds/master' into perf/urgent (2019-12-11 09:58:16 -0300)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-urgent-for-mingo-5.5-20191216
for you to fetch changes up to 58b3bafff8257c6946df5d6aeb215b8ac839ed2a:
perf vendor events s390: Remove name from L1D_RO_EXCL_WRITES description (2019-12-16 13:40:26 -0300)
----------------------------------------------------------------
perf/urgent fixes:
perf top:
Arnaldo Carvalho de Melo:
- Do not bail out when perf_env__read_cpuid() returns ENOSYS, which
has been reported happening on aarch64.
perf metricgroup:
Kajol Jain:
- Fix printing event names of metric group with multiple events
vendor events:
x86:
Ravi Bangoria:
- Fix Kernel_Utilization metric.
s390:
Ed Maste:
- Fix counter long description for DTLB1_GPAGE_WRITES and L1D_RO_EXCL_WRITES.
perf header:
Michael Petlan:
- Fix false warning when there are no duplicate cache entries
libtraceevent:
Sudip Mukherjee:
- Allow custom libdir path
API headers:
Arnaldo Carvalho de Melo:
- Sync linux/kvm.h with the kernel sources.
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Arnaldo Carvalho de Melo (3):
tools headers kvm: Sync linux/kvm.h with the kernel sources
perf arch: Make the default get_cpuid() return compatible error
perf top: Do not bail out when perf_env__read_cpuid() returns ENOSYS
Ed Maste (2):
perf vendor events s390: Fix counter long description for DTLB1_GPAGE_WRITES
perf vendor events s390: Remove name from L1D_RO_EXCL_WRITES description
Kajol Jain (1):
perf metricgroup: Fix printing event names of metric group with multiple events
Michael Petlan (1):
perf header: Fix false warning when there are no duplicate cache entries
Ravi Bangoria (1):
perf/x86/pmu-events: Fix Kernel_Utilization metric
Sudip Mukherjee (1):
libtraceevent: Allow custom libdir path
tools/include/uapi/linux/kvm.h | 1 +
tools/lib/traceevent/Makefile | 5 +++--
tools/lib/traceevent/plugins/Makefile | 5 +++--
tools/perf/builtin-top.c | 10 +++++++---
.../perf/pmu-events/arch/s390/cf_z13/extended.json | 2 +-
.../perf/pmu-events/arch/s390/cf_z14/extended.json | 2 +-
.../pmu-events/arch/x86/broadwell/bdw-metrics.json | 2 +-
.../arch/x86/broadwellde/bdwde-metrics.json | 2 +-
.../arch/x86/broadwellx/bdx-metrics.json | 2 +-
.../arch/x86/cascadelakex/clx-metrics.json | 2 +-
.../pmu-events/arch/x86/haswell/hsw-metrics.json | 2 +-
.../pmu-events/arch/x86/haswellx/hsx-metrics.json | 2 +-
.../pmu-events/arch/x86/ivybridge/ivb-metrics.json | 2 +-
.../pmu-events/arch/x86/ivytown/ivt-metrics.json | 2 +-
.../pmu-events/arch/x86/jaketown/jkt-metrics.json | 2 +-
.../arch/x86/sandybridge/snb-metrics.json | 2 +-
.../pmu-events/arch/x86/skylake/skl-metrics.json | 2 +-
.../pmu-events/arch/x86/skylakex/skx-metrics.json | 2 +-
tools/perf/util/header.c | 23 +++++++---------------
tools/perf/util/metricgroup.c | 7 +++++--
20 files changed, 40 insertions(+), 39 deletions(-)
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [GIT PULL 0/9] perf/urgent fixes
2019-12-16 20:47 Arnaldo Carvalho de Melo
@ 2019-12-17 11:28 ` Ingo Molnar
0 siblings, 0 replies; 22+ messages in thread
From: Ingo Molnar @ 2019-12-17 11:28 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: Thomas Gleixner, Jiri Olsa, Namhyung Kim, Clark Williams,
linux-kernel, linux-perf-users, Ed Maste, John Garry, Kajol Jain,
Mark Rutland, Michael Petlan, Ravi Bangoria, Sudipm Mukherjee,
Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo/Thomas,
>
> Please consider pulling,
>
> Best regards,
>
> - Arnaldo
>
>
> The following changes since commit 761bfc33dd7504de951aa7b9db27a3cc5df1fde6:
>
> Merge remote-tracking branch 'torvalds/master' into perf/urgent (2019-12-11 09:58:16 -0300)
>
> are available in the Git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-urgent-for-mingo-5.5-20191216
>
> for you to fetch changes up to 58b3bafff8257c6946df5d6aeb215b8ac839ed2a:
>
> perf vendor events s390: Remove name from L1D_RO_EXCL_WRITES description (2019-12-16 13:40:26 -0300)
>
> ----------------------------------------------------------------
> perf/urgent fixes:
>
> perf top:
>
> Arnaldo Carvalho de Melo:
>
> - Do not bail out when perf_env__read_cpuid() returns ENOSYS, which
> has been reported happening on aarch64.
>
> perf metricgroup:
>
> Kajol Jain:
>
> - Fix printing event names of metric group with multiple events
>
> vendor events:
>
> x86:
>
> Ravi Bangoria:
>
> - Fix Kernel_Utilization metric.
>
> s390:
>
> Ed Maste:
>
> - Fix counter long description for DTLB1_GPAGE_WRITES and L1D_RO_EXCL_WRITES.
>
> perf header:
>
> Michael Petlan:
>
> - Fix false warning when there are no duplicate cache entries
>
> libtraceevent:
>
> Sudip Mukherjee:
>
> - Allow custom libdir path
>
> API headers:
>
> Arnaldo Carvalho de Melo:
>
> - Sync linux/kvm.h with the kernel sources.
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (3):
> tools headers kvm: Sync linux/kvm.h with the kernel sources
> perf arch: Make the default get_cpuid() return compatible error
> perf top: Do not bail out when perf_env__read_cpuid() returns ENOSYS
>
> Ed Maste (2):
> perf vendor events s390: Fix counter long description for DTLB1_GPAGE_WRITES
> perf vendor events s390: Remove name from L1D_RO_EXCL_WRITES description
>
> Kajol Jain (1):
> perf metricgroup: Fix printing event names of metric group with multiple events
>
> Michael Petlan (1):
> perf header: Fix false warning when there are no duplicate cache entries
>
> Ravi Bangoria (1):
> perf/x86/pmu-events: Fix Kernel_Utilization metric
>
> Sudip Mukherjee (1):
> libtraceevent: Allow custom libdir path
>
> tools/include/uapi/linux/kvm.h | 1 +
> tools/lib/traceevent/Makefile | 5 +++--
> tools/lib/traceevent/plugins/Makefile | 5 +++--
> tools/perf/builtin-top.c | 10 +++++++---
> .../perf/pmu-events/arch/s390/cf_z13/extended.json | 2 +-
> .../perf/pmu-events/arch/s390/cf_z14/extended.json | 2 +-
> .../pmu-events/arch/x86/broadwell/bdw-metrics.json | 2 +-
> .../arch/x86/broadwellde/bdwde-metrics.json | 2 +-
> .../arch/x86/broadwellx/bdx-metrics.json | 2 +-
> .../arch/x86/cascadelakex/clx-metrics.json | 2 +-
> .../pmu-events/arch/x86/haswell/hsw-metrics.json | 2 +-
> .../pmu-events/arch/x86/haswellx/hsx-metrics.json | 2 +-
> .../pmu-events/arch/x86/ivybridge/ivb-metrics.json | 2 +-
> .../pmu-events/arch/x86/ivytown/ivt-metrics.json | 2 +-
> .../pmu-events/arch/x86/jaketown/jkt-metrics.json | 2 +-
> .../arch/x86/sandybridge/snb-metrics.json | 2 +-
> .../pmu-events/arch/x86/skylake/skl-metrics.json | 2 +-
> .../pmu-events/arch/x86/skylakex/skx-metrics.json | 2 +-
> tools/perf/util/header.c | 23 +++++++---------------
> tools/perf/util/metricgroup.c | 7 +++++--
> 20 files changed, 40 insertions(+), 39 deletions(-)
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 22+ messages in thread
end of thread, other threads:[~2019-12-17 11:28 UTC | newest]
Thread overview: 22+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-19 18:40 [GIT PULL 0/9] perf/urgent fixes Arnaldo Carvalho de Melo
2013-09-19 18:40 ` [PATCH 1/9] perf tools: Sharpen the libaudit dependencies test Arnaldo Carvalho de Melo
2013-09-19 18:40 ` [PATCH 2/9] perf tools: Fill in new definitions for madvise()/mmap() flags Arnaldo Carvalho de Melo
2013-09-19 18:40 ` [PATCH 3/9] perf annotate: Fix objdump line parsing offset validation Arnaldo Carvalho de Melo
2013-09-19 18:40 ` [PATCH 4/9] perf tools: Fix buildid cache handling of kallsyms with kcore Arnaldo Carvalho de Melo
2013-09-19 18:40 ` [PATCH 5/9] perf tools: Fix compile with libelf without get_phdrnum Arnaldo Carvalho de Melo
2013-09-19 18:40 ` [PATCH 6/9] perf session: Check for SIGINT in more loops Arnaldo Carvalho de Melo
2013-09-19 18:40 ` [PATCH 7/9] perf probe: Fix finder to find lines of given function Arnaldo Carvalho de Melo
2013-09-19 18:40 ` [PATCH 8/9] perf tools: Fix old GCC build error in trace-event-parse.c:parse_proc_kallsyms() Arnaldo Carvalho de Melo
2013-09-19 18:40 ` [PATCH 9/9] tools lib lk: Uninclude linux/magic.h in debugfs.c Arnaldo Carvalho de Melo
2013-09-20 5:15 ` [GIT PULL 0/9] perf/urgent fixes Ingo Molnar
-- strict thread matches above, loose matches on Subject: below --
2019-12-16 20:47 Arnaldo Carvalho de Melo
2019-12-17 11:28 ` Ingo Molnar
2018-03-06 17:23 Arnaldo Carvalho de Melo
2018-03-07 8:22 ` Ingo Molnar
2018-03-07 14:23 ` Arnaldo Carvalho de Melo
2017-09-12 19:24 Arnaldo Carvalho de Melo
2017-09-13 7:26 ` Ingo Molnar
2015-01-21 15:01 Arnaldo Carvalho de Melo
2015-01-28 14:42 ` Ingo Molnar
2012-03-30 16:09 Arnaldo Carvalho de Melo
2012-03-31 7:31 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox