From: Dan Carpenter <dan.carpenter@oracle.com>
To: Thomas Meyer <thomas@m3y3r.de>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 9/10] staging: r8188eu: Cocci spatch "noderef"
Date: Fri, 20 Sep 2013 13:44:57 +0300 [thread overview]
Message-ID: <20130920104457.GB6192@mwanda> (raw)
In-Reply-To: <1379604755854-737294623-9-diffsplit-thomas@m3y3r.de>
On Thu, Sep 19, 2013 at 11:45:46PM +0200, Thomas Meyer wrote:
> sizeof when applied to a pointer typed expression gives the size of the
> pointer.
> Found by coccinelle spatch "misc/noderef.cocci"
>
> Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
> ---
>
> diff -u -p a/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c b/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
> --- a/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
> +++ b/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
> @@ -6973,7 +6973,7 @@ static int rtw_mp_ctx(struct net_device
> stop = strncmp(extra, "stop", 4);
> sscanf(extra, "count =%d, pkt", &count);
>
> - _rtw_memset(extra, '\0', sizeof(extra));
> + _rtw_memset(extra, '\0', sizeof(*extra));
Do:
extra[0] = '\0';
regards,
dan carpenter
next prev parent reply other threads:[~2013-09-20 10:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-19 21:45 [PATCH 0/10] Cocci spatch "noderef" - v3.11-7547-g44598f9 Thomas Meyer
2013-09-19 21:42 ` [PATCH 2/10] xtensa: Cocci spatch "noderef" Thomas Meyer
2013-09-19 22:10 ` Joe Perches
2013-09-19 21:42 ` [PATCH 3/10] iio: at91_adc: " Thomas Meyer
2013-09-20 7:26 ` Nicolas Ferre
2013-09-20 18:36 ` Jonathan Cameron
2013-09-20 18:42 ` Jonathan Cameron
2013-09-23 12:16 ` Nicolas Ferre
2013-09-19 21:45 ` [PATCH 8/10] staging: r8188eu: Add files for new drive: " Thomas Meyer
2013-09-19 21:45 ` [PATCH 5/10] staging: lustre: " Thomas Meyer
2013-09-19 21:45 ` [PATCH 9/10] staging: r8188eu: " Thomas Meyer
2013-09-20 10:44 ` Dan Carpenter [this message]
2013-09-19 21:45 ` [PATCH 4/10] [SCSI] csiostor: " Thomas Meyer
2013-09-19 21:45 ` [PATCH 6/10] staging: octeon-usb: " Thomas Meyer
2013-09-19 21:45 ` [PATCH 7/10] staging: r8188eu: Add files for new drive: " Thomas Meyer
2013-09-20 10:43 ` Dan Carpenter
2013-09-19 21:45 ` [PATCH 1/10] MIPS: BCM47XX: " Thomas Meyer
2013-09-19 21:08 ` Hauke Mehrtens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130920104457.GB6192@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas@m3y3r.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox