From: Tony Lindgren <tony@atomide.com>
To: "Pali Rohár" <pali.rohar@gmail.com>
Cc: Matt Mackall <mpm@selenic.com>,
Herbert Xu <herbert@gondor.hengli.com.au>,
Russell King <linux@arm.linux.org.uk>,
Joe Perches <joe@perches.com>,
Aaro Koskinen <aaro.koskinen@iki.fi>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] omap2: Change clk dev id for rng to omap3-rom-rng
Date: Fri, 20 Sep 2013 09:23:43 -0700 [thread overview]
Message-ID: <20130920162342.GS9994@atomide.com> (raw)
In-Reply-To: <1379683507-30793-2-git-send-email-pali.rohar@gmail.com>
* Pali Rohár <pali.rohar@gmail.com> [130920 06:33]:
> Name omap_rng is already used by omap_rng driver which is for omap2 and omap4.
> For omap3 HS devices there is new driver omap3-rom-rng which needs that clk.
> And because there cannot be two drivers with same name, rename omap3 clk dev id.
>
> Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
> ---
> arch/arm/mach-omap2/cclock3xxx_data.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/cclock3xxx_data.c b/arch/arm/mach-omap2/cclock3xxx_data.c
> index 334b767..5059338 100644
> --- a/arch/arm/mach-omap2/cclock3xxx_data.c
> +++ b/arch/arm/mach-omap2/cclock3xxx_data.c
> @@ -3274,7 +3274,7 @@ static struct omap_clk omap36xx_clks[] = {
> */
> static struct omap_clk omap34xx_omap36xx_clks[] = {
> CLK(NULL, "aes1_ick", &aes1_ick),
> - CLK("omap_rng", "ick", &rng_ick),
> + CLK("omap3-rom-rng", "ick", &rng_ick),
> CLK(NULL, "sha11_ick", &sha11_ick),
> CLK(NULL, "des1_ick", &des1_ick),
> CLK(NULL, "cam_mclk", &cam_mclk),
Hmm are you sure the omap_rng is not available on
any of the omap3 GP versions? If so, the omap_rng
alias should be kept as well.
Regards,
Tony
next prev parent reply other threads:[~2013-09-20 16:23 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-28 18:05 [PATCH] OMAP3 ROM Random Number Generator support Pali Rohár
2013-03-24 14:15 ` Pali Rohár
2013-03-27 21:09 ` Tony Lindgren
2013-03-27 22:03 ` Pali Rohár
2013-03-27 22:25 ` Tony Lindgren
2013-03-28 17:54 ` Pali Rohár
2013-03-28 21:44 ` Tony Lindgren
2013-03-31 9:28 ` Pali Rohár
2013-04-01 16:25 ` Tony Lindgren
2013-09-18 20:05 ` [PATCH 0/2] " Pali Rohár
2013-09-18 20:05 ` [PATCH 1/2] hwrng: " Pali Rohár
2013-09-18 20:22 ` Joe Perches
2013-09-18 20:50 ` Aaro Koskinen
2013-09-18 20:05 ` [PATCH 2/2] RX-51: Add support for OMAP3 ROM Random Number Generator Pali Rohár
2013-09-18 20:39 ` Tony Lindgren
2013-09-20 13:25 ` [PATCH v2 0/3] OMAP3 ROM Random Number Generator support Pali Rohár
2013-09-20 13:25 ` [PATCH v2 1/3] omap2: Change clk dev id for rng to omap3-rom-rng Pali Rohár
2013-09-20 16:23 ` Tony Lindgren [this message]
2013-09-20 16:41 ` Pali Rohár
2013-09-20 17:46 ` Tony Lindgren
2013-09-20 18:24 ` Pali Rohár
2013-09-20 18:31 ` Tony Lindgren
2013-09-20 13:25 ` [PATCH v2 2/3] hwrng: OMAP3 ROM Random Number Generator support Pali Rohár
2013-10-08 19:04 ` Tony Lindgren
2013-10-16 12:57 ` Herbert Xu
2013-11-18 21:51 ` Pali Rohár
2013-11-19 2:14 ` Herbert Xu
2013-11-23 9:37 ` Pali Rohár
2013-11-23 12:09 ` Sebastian Reichel
2013-09-20 13:25 ` [PATCH v2 3/3] RX-51: Add support for OMAP3 ROM Random Number Generator Pali Rohár
2013-10-08 19:06 ` Tony Lindgren
2013-03-28 9:52 ` [PATCH] OMAP3 ROM Random Number Generator support Russell King - ARM Linux
2013-03-28 17:24 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130920162342.GS9994@atomide.com \
--to=tony@atomide.com \
--cc=aaro.koskinen@iki.fi \
--cc=herbert@gondor.hengli.com.au \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mpm@selenic.com \
--cc=pali.rohar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).