From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sonic Zhang <sonic.adi@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
LKML <linux-kernel@vger.kernel.org>,
adi-buildroot-devel@lists.sourceforge.net,
Sonic Zhang <sonic.zhang@analog.com>
Subject: Re: [PATCH] pinctrl: pinctrl-adi2: Remove nested lock+irqsave that resue flags.
Date: Mon, 23 Sep 2013 15:38:22 +0300 [thread overview]
Message-ID: <20130923123822.GG6247@mwanda> (raw)
In-Reply-To: <1379928588-12627-1-git-send-email-sonic.adi@gmail.com>
On Mon, Sep 23, 2013 at 05:29:48PM +0800, Sonic Zhang wrote:
> @@ -323,12 +323,12 @@ static unsigned int adi_gpio_irq_startup(struct irq_data *d)
> struct gpio_pint_regs *regs = port->pint->regs;
^^^^^^^^^^^^^^^^
Dereference.
>
> if (!port) {
^^^^^
Too late to check here.
> - dev_err(port->dev, "GPIO IRQ %d :Not exist\n", d->irq);
> + pr_err("GPIO IRQ %d :Not exist\n", d->irq);
> return -ENODEV;
> }
regards,
dan carpenter
>
next prev parent reply other threads:[~2013-09-23 12:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-23 9:29 [PATCH] pinctrl: pinctrl-adi2: Remove nested lock+irqsave that resue flags Sonic Zhang
2013-09-23 12:38 ` Dan Carpenter [this message]
2013-09-27 12:22 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130923123822.GG6247@mwanda \
--to=dan.carpenter@oracle.com \
--cc=adi-buildroot-devel@lists.sourceforge.net \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sonic.adi@gmail.com \
--cc=sonic.zhang@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox