From: Jiri Olsa <jolsa@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Namhyung Kim <namhyung@kernel.org>,
Corey Ashford <cjashfor@linux.vnet.ibm.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [PATCH 4/4] perf tools: Make kmem work for non numa machines
Date: Mon, 23 Sep 2013 15:50:31 +0200 [thread overview]
Message-ID: <20130923135031.GD3488@krava.brq.redhat.com> (raw)
In-Reply-To: <1379003976-5839-5-git-send-email-jolsa@redhat.com>
On Thu, Sep 12, 2013 at 06:39:36PM +0200, Jiri Olsa wrote:
> The commit '2814eb0 perf kmem: Remove die() calls' disabled
> kmem command for machines without numa support. It made the
> command fail if '/sys/devices/system/node' dir wasn't found.
>
> Skipping the numa based initialization in case the directory
> is not found and continue execution.
>
> Signed-off-by: Jiri Olsa <jolsa@redhat.com>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
> Cc: Frederic Weisbecker <fweisbec@gmail.com>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
ping
thanks,
jirka
> ---
> tools/perf/builtin-kmem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/builtin-kmem.c b/tools/perf/builtin-kmem.c
> index c2dff9c..9b5f077 100644
> --- a/tools/perf/builtin-kmem.c
> +++ b/tools/perf/builtin-kmem.c
> @@ -101,7 +101,7 @@ static int setup_cpunode_map(void)
>
> dir1 = opendir(PATH_SYS_NODE);
> if (!dir1)
> - return -1;
> + return 0;
>
> while ((dent1 = readdir(dir1)) != NULL) {
> if (dent1->d_type != DT_DIR ||
> --
> 1.7.11.7
>
next prev parent reply other threads:[~2013-09-23 13:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-12 16:39 [PATCH 0/4] perf tools: Misc fixies Jiri Olsa
2013-09-12 16:39 ` [PATCH 1/4] perf tools: Fix 'make install prefix=...' build rule Jiri Olsa
2013-09-12 16:39 ` [PATCH 2/4] perf tools: Remove unused trace-event-* code Jiri Olsa
2013-10-15 5:23 ` [tip:perf/core] " tip-bot for Jiri Olsa
2013-09-12 16:39 ` [PATCH 3/4] perf tools: Unify page_size usage Jiri Olsa
2013-10-15 5:23 ` [tip:perf/core] " tip-bot for Jiri Olsa
2013-09-12 16:39 ` [PATCH 4/4] perf tools: Make kmem work for non numa machines Jiri Olsa
2013-09-23 13:50 ` Jiri Olsa [this message]
2013-09-23 17:15 ` Arnaldo Carvalho de Melo
2013-09-23 17:21 ` Jiri Olsa
2013-09-25 18:30 ` [tip:perf/urgent] perf kmem: Make it work again on non NUMA machines tip-bot for Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130923135031.GD3488@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox