From: Christoph Hellwig <hch@infradead.org>
To: Lubomir Rintel <lkundrak@v3.sk>
Cc: linux-kernel@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH] sysv: Add forgotten superblock lock init for v7 fs
Date: Tue, 24 Sep 2013 01:50:22 -0700 [thread overview]
Message-ID: <20130924085022.GD11858@infradead.org> (raw)
In-Reply-To: <1379457556-8902-1-git-send-email-lkundrak@v3.sk>
On Wed, Sep 18, 2013 at 12:39:16AM +0200, Lubomir Rintel wrote:
> Superblock lock was replaced with (un)lock_super() removal, but left
> uninitialized for Seventh Edition UNIX filesystem in the following commit (3.7):
> c07cb01 sysv: drop lock/unlock super
>
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
Looks good.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Al, can you add this to the next VFS pile?
> ---
> fs/sysv/super.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/fs/sysv/super.c b/fs/sysv/super.c
> index d0c6a00..eda1095 100644
> --- a/fs/sysv/super.c
> +++ b/fs/sysv/super.c
> @@ -487,6 +487,7 @@ static int v7_fill_super(struct super_block *sb, void *data, int silent)
> sbi->s_sb = sb;
> sbi->s_block_base = 0;
> sbi->s_type = FSTYPE_V7;
> + mutex_init(&sbi->s_lock);
> sb->s_fs_info = sbi;
>
> sb_set_blocksize(sb, 512);
> --
> 1.7.1
>
---end quoted text---
next prev parent reply other threads:[~2013-09-24 8:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-17 22:39 [PATCH] sysv: Add forgotten superblock lock init for v7 fs Lubomir Rintel
2013-09-24 8:50 ` Christoph Hellwig [this message]
2013-09-24 16:49 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130924085022.GD11858@infradead.org \
--to=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkundrak@v3.sk \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).