* [PATCH] sysv: Add forgotten superblock lock init for v7 fs
@ 2013-09-17 22:39 Lubomir Rintel
2013-09-24 8:50 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Lubomir Rintel @ 2013-09-17 22:39 UTC (permalink / raw)
To: linux-kernel; +Cc: Christoph Hellwig, Lubomir Rintel
Superblock lock was replaced with (un)lock_super() removal, but left
uninitialized for Seventh Edition UNIX filesystem in the following commit (3.7):
c07cb01 sysv: drop lock/unlock super
Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
---
fs/sysv/super.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/fs/sysv/super.c b/fs/sysv/super.c
index d0c6a00..eda1095 100644
--- a/fs/sysv/super.c
+++ b/fs/sysv/super.c
@@ -487,6 +487,7 @@ static int v7_fill_super(struct super_block *sb, void *data, int silent)
sbi->s_sb = sb;
sbi->s_block_base = 0;
sbi->s_type = FSTYPE_V7;
+ mutex_init(&sbi->s_lock);
sb->s_fs_info = sbi;
sb_set_blocksize(sb, 512);
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] sysv: Add forgotten superblock lock init for v7 fs
2013-09-17 22:39 [PATCH] sysv: Add forgotten superblock lock init for v7 fs Lubomir Rintel
@ 2013-09-24 8:50 ` Christoph Hellwig
2013-09-24 16:49 ` Al Viro
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2013-09-24 8:50 UTC (permalink / raw)
To: Lubomir Rintel; +Cc: linux-kernel, Al Viro
On Wed, Sep 18, 2013 at 12:39:16AM +0200, Lubomir Rintel wrote:
> Superblock lock was replaced with (un)lock_super() removal, but left
> uninitialized for Seventh Edition UNIX filesystem in the following commit (3.7):
> c07cb01 sysv: drop lock/unlock super
>
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
Looks good.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Al, can you add this to the next VFS pile?
> ---
> fs/sysv/super.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/fs/sysv/super.c b/fs/sysv/super.c
> index d0c6a00..eda1095 100644
> --- a/fs/sysv/super.c
> +++ b/fs/sysv/super.c
> @@ -487,6 +487,7 @@ static int v7_fill_super(struct super_block *sb, void *data, int silent)
> sbi->s_sb = sb;
> sbi->s_block_base = 0;
> sbi->s_type = FSTYPE_V7;
> + mutex_init(&sbi->s_lock);
> sb->s_fs_info = sbi;
>
> sb_set_blocksize(sb, 512);
> --
> 1.7.1
>
---end quoted text---
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-09-24 16:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-17 22:39 [PATCH] sysv: Add forgotten superblock lock init for v7 fs Lubomir Rintel
2013-09-24 8:50 ` Christoph Hellwig
2013-09-24 16:49 ` Al Viro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).