* [PATCH 1/2] drivers: edac: octeon: fix lack of opstate_init
@ 2013-09-20 22:46 Daniel Walker
2013-09-24 12:32 ` Ralf Baechle
0 siblings, 1 reply; 2+ messages in thread
From: Daniel Walker @ 2013-09-20 22:46 UTC (permalink / raw)
To: Ralf Baechle, David Daney, Doug Thompson
Cc: linux-edac, linux-mips, linux-kernel
If the opstate_init() isn't called the driver won't start properly.
I just added it in what appears to be an appropriate place.
Signed-off-by: Daniel Walker <dwalker@fifo99.com>
---
drivers/edac/octeon_edac-lmc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/edac/octeon_edac-lmc.c b/drivers/edac/octeon_edac-lmc.c
index 93412d6..4881ad0 100644
--- a/drivers/edac/octeon_edac-lmc.c
+++ b/drivers/edac/octeon_edac-lmc.c
@@ -92,6 +92,8 @@ static int octeon_lmc_edac_probe(struct platform_device *pdev)
struct edac_mc_layer layers[1];
int mc = pdev->id;
+ opstate_init();
+
layers[0].type = EDAC_MC_LAYER_CHANNEL;
layers[0].size = 1;
layers[0].is_virt_csrow = false;
--
1.8.1.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/2] drivers: edac: octeon: fix lack of opstate_init
2013-09-20 22:46 [PATCH 1/2] drivers: edac: octeon: fix lack of opstate_init Daniel Walker
@ 2013-09-24 12:32 ` Ralf Baechle
0 siblings, 0 replies; 2+ messages in thread
From: Ralf Baechle @ 2013-09-24 12:32 UTC (permalink / raw)
To: Daniel Walker
Cc: David Daney, Doug Thompson, linux-edac, linux-mips, linux-kernel
On Fri, Sep 20, 2013 at 03:46:40PM -0700, Daniel Walker wrote:
> If the opstate_init() isn't called the driver won't start properly.
>
> I just added it in what appears to be an appropriate place.
>
> Signed-off-by: Daniel Walker <dwalker@fifo99.com>
Makes sense. Unfortunately :-)
Acked-by: Ralf Baechle <ralf@linux-mips.org>
EDAC folks - I can funnel this patch through my tree or leave that to you,
whatever you prefer. Same for Daniel's other patch.
Ralf
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-24 12:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-20 22:46 [PATCH 1/2] drivers: edac: octeon: fix lack of opstate_init Daniel Walker
2013-09-24 12:32 ` Ralf Baechle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).