[PATCH] iommu: remove unnecessary platform_set_drvdata()

[PATCH] iommu: remove unnecessary platform_set_drvdata()

[Jingoo Han]

The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/iommu/msm_iommu_dev.c |    2 --
 drivers/iommu/omap-iommu.c    |    2 --
 2 files changed, 4 deletions(-)

diff --git a/drivers/iommu/msm_iommu_dev.c b/drivers/iommu/msm_iommu_dev.c
index 0a1c962..08ba497 100644
--- a/drivers/iommu/msm_iommu_dev.c
+++ b/drivers/iommu/msm_iommu_dev.c
@@ -282,7 +282,6 @@ static int msm_iommu_remove(struct platform_device *pdev)
 		clk_put(drv->pclk);
 		memset(drv, 0, sizeof(*drv));
 		kfree(drv);
-		platform_set_drvdata(pdev, NULL);
 	}
 	return 0;
 }
@@ -366,7 +365,6 @@ static int msm_iommu_ctx_remove(struct platform_device *pdev)
 	if (drv) {
 		memset(drv, 0, sizeof(struct msm_iommu_ctx_drvdata));
 		kfree(drv);
-		platform_set_drvdata(pdev, NULL);
 	}
 	return 0;
 }
diff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu/omap-iommu.c
index 0ba3766..bcd78a7 100644
--- a/drivers/iommu/omap-iommu.c
+++ b/drivers/iommu/omap-iommu.c
@@ -1008,8 +1008,6 @@ static int omap_iommu_remove(struct platform_device *pdev)
 	struct resource *res;
 	struct omap_iommu *obj = platform_get_drvdata(pdev);
 
-	platform_set_drvdata(pdev, NULL);
-
 	iopgtable_clear_entry_all(obj);
 
 	irq = platform_get_irq(pdev, 0);
-- 
1.7.10.4

Re: [PATCH] iommu: remove unnecessary platform_set_drvdata()

[Libo Chen]

On 2013/8/22 9:53, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure. Thus, it is not needed to manually clear the
> device driver data to NULL.
> 
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---

It looks good.

Acked-by: Libo Chen <libo.chen@huawei.com>


>  drivers/iommu/msm_iommu_dev.c |    2 --
>  drivers/iommu/omap-iommu.c    |    2 --
>  2 files changed, 4 deletions(-)
> 
> diff --git a/drivers/iommu/msm_iommu_dev.c b/drivers/iommu/msm_iommu_dev.c
> index 0a1c962..08ba497 100644
> --- a/drivers/iommu/msm_iommu_dev.c
> +++ b/drivers/iommu/msm_iommu_dev.c
> @@ -282,7 +282,6 @@ static int msm_iommu_remove(struct platform_device *pdev)
>  		clk_put(drv->pclk);
>  		memset(drv, 0, sizeof(*drv));
>  		kfree(drv);
> -		platform_set_drvdata(pdev, NULL);
>  	}
>  	return 0;
>  }
> @@ -366,7 +365,6 @@ static int msm_iommu_ctx_remove(struct platform_device *pdev)
>  	if (drv) {
>  		memset(drv, 0, sizeof(struct msm_iommu_ctx_drvdata));
>  		kfree(drv);
> -		platform_set_drvdata(pdev, NULL);
>  	}
>  	return 0;
>  }
> diff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu/omap-iommu.c
> index 0ba3766..bcd78a7 100644
> --- a/drivers/iommu/omap-iommu.c
> +++ b/drivers/iommu/omap-iommu.c
> @@ -1008,8 +1008,6 @@ static int omap_iommu_remove(struct platform_device *pdev)
>  	struct resource *res;
>  	struct omap_iommu *obj = platform_get_drvdata(pdev);
>  
> -	platform_set_drvdata(pdev, NULL);
> -
>  	iopgtable_clear_entry_all(obj);
>  
>  	irq = platform_get_irq(pdev, 0);
> 

Re: [PATCH] iommu: remove unnecessary platform_set_drvdata()

['Joerg Roedel']

On Thu, Aug 22, 2013 at 10:53:01AM +0900, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure. Thus, it is not needed to manually clear the
> device driver data to NULL.

Please split that into two patches, one for msm and one for omap so that
I can put them into their respective topic-branches. Also add the
Acked-by while you are at it, please.

Thanks,

	Joerg

Re: [PATCH] iommu: remove unnecessary platform_set_drvdata()

[David Brown]

On Thu, Aug 22, 2013 at 10:53:01AM +0900, Jingoo Han wrote:
>The driver core clears the driver data to NULL after device_release
>or on probe failure. Thus, it is not needed to manually clear the
>device driver data to NULL.
>
>Signed-off-by: Jingoo Han <jg1.han@samsung.com>
>---
> drivers/iommu/msm_iommu_dev.c |    2 --

With the splitting:

Acked-by: David Brown <davidb@codeaurora.org>

-- 
sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation

Re: [PATCH] iommu: remove unnecessary platform_set_drvdata()

[Jingoo Han]

On Tuesday, September 24, 2013 9:42 PM, Joerg Roedel wrote:
> On Thu, Aug 22, 2013 at 10:53:01AM +0900, Jingoo Han wrote:
> > The driver core clears the driver data to NULL after device_release
> > or on probe failure. Thus, it is not needed to manually clear the
> > device driver data to NULL.
> 
> Please split that into two patches, one for msm and one for omap so that
> I can put them into their respective topic-branches. Also add the
> Acked-by while you are at it, please.
> 

Hi Joerg Roedel,

This patch was already merged to v3.12-rc1 through mm-tree.
Commit: 5e42781 "drivers/iommu: remove unnecessary platform_set_drvdata()"

Thank you for caring. :-)

Best regards,
Jingoo Han