* [PATCH] iommu: remove unnecessary platform_set_drvdata()
@ 2013-08-22 1:53 Jingoo Han
2013-08-22 2:03 ` Libo Chen
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Jingoo Han @ 2013-08-22 1:53 UTC (permalink / raw)
To: Andrew Morton
Cc: linux-kernel, 'David Brown', 'Stephen Boyd',
'Joerg Roedel', 'Suman Anna',
'Jingoo Han'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/iommu/msm_iommu_dev.c | 2 --
drivers/iommu/omap-iommu.c | 2 --
2 files changed, 4 deletions(-)
diff --git a/drivers/iommu/msm_iommu_dev.c b/drivers/iommu/msm_iommu_dev.c
index 0a1c962..08ba497 100644
--- a/drivers/iommu/msm_iommu_dev.c
+++ b/drivers/iommu/msm_iommu_dev.c
@@ -282,7 +282,6 @@ static int msm_iommu_remove(struct platform_device *pdev)
clk_put(drv->pclk);
memset(drv, 0, sizeof(*drv));
kfree(drv);
- platform_set_drvdata(pdev, NULL);
}
return 0;
}
@@ -366,7 +365,6 @@ static int msm_iommu_ctx_remove(struct platform_device *pdev)
if (drv) {
memset(drv, 0, sizeof(struct msm_iommu_ctx_drvdata));
kfree(drv);
- platform_set_drvdata(pdev, NULL);
}
return 0;
}
diff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu/omap-iommu.c
index 0ba3766..bcd78a7 100644
--- a/drivers/iommu/omap-iommu.c
+++ b/drivers/iommu/omap-iommu.c
@@ -1008,8 +1008,6 @@ static int omap_iommu_remove(struct platform_device *pdev)
struct resource *res;
struct omap_iommu *obj = platform_get_drvdata(pdev);
- platform_set_drvdata(pdev, NULL);
-
iopgtable_clear_entry_all(obj);
irq = platform_get_irq(pdev, 0);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] iommu: remove unnecessary platform_set_drvdata()
2013-08-22 1:53 [PATCH] iommu: remove unnecessary platform_set_drvdata() Jingoo Han
@ 2013-08-22 2:03 ` Libo Chen
2013-09-24 12:41 ` 'Joerg Roedel'
2013-09-24 19:28 ` David Brown
2 siblings, 0 replies; 5+ messages in thread
From: Libo Chen @ 2013-08-22 2:03 UTC (permalink / raw)
To: Jingoo Han
Cc: Andrew Morton, linux-kernel, 'David Brown',
'Stephen Boyd', 'Joerg Roedel',
'Suman Anna'
On 2013/8/22 9:53, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure. Thus, it is not needed to manually clear the
> device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
It looks good.
Acked-by: Libo Chen <libo.chen@huawei.com>
> drivers/iommu/msm_iommu_dev.c | 2 --
> drivers/iommu/omap-iommu.c | 2 --
> 2 files changed, 4 deletions(-)
>
> diff --git a/drivers/iommu/msm_iommu_dev.c b/drivers/iommu/msm_iommu_dev.c
> index 0a1c962..08ba497 100644
> --- a/drivers/iommu/msm_iommu_dev.c
> +++ b/drivers/iommu/msm_iommu_dev.c
> @@ -282,7 +282,6 @@ static int msm_iommu_remove(struct platform_device *pdev)
> clk_put(drv->pclk);
> memset(drv, 0, sizeof(*drv));
> kfree(drv);
> - platform_set_drvdata(pdev, NULL);
> }
> return 0;
> }
> @@ -366,7 +365,6 @@ static int msm_iommu_ctx_remove(struct platform_device *pdev)
> if (drv) {
> memset(drv, 0, sizeof(struct msm_iommu_ctx_drvdata));
> kfree(drv);
> - platform_set_drvdata(pdev, NULL);
> }
> return 0;
> }
> diff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu/omap-iommu.c
> index 0ba3766..bcd78a7 100644
> --- a/drivers/iommu/omap-iommu.c
> +++ b/drivers/iommu/omap-iommu.c
> @@ -1008,8 +1008,6 @@ static int omap_iommu_remove(struct platform_device *pdev)
> struct resource *res;
> struct omap_iommu *obj = platform_get_drvdata(pdev);
>
> - platform_set_drvdata(pdev, NULL);
> -
> iopgtable_clear_entry_all(obj);
>
> irq = platform_get_irq(pdev, 0);
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] iommu: remove unnecessary platform_set_drvdata()
2013-08-22 1:53 [PATCH] iommu: remove unnecessary platform_set_drvdata() Jingoo Han
2013-08-22 2:03 ` Libo Chen
@ 2013-09-24 12:41 ` 'Joerg Roedel'
2013-09-25 1:36 ` Jingoo Han
2013-09-24 19:28 ` David Brown
2 siblings, 1 reply; 5+ messages in thread
From: 'Joerg Roedel' @ 2013-09-24 12:41 UTC (permalink / raw)
To: Jingoo Han
Cc: Andrew Morton, linux-kernel, 'David Brown',
'Stephen Boyd', 'Suman Anna'
On Thu, Aug 22, 2013 at 10:53:01AM +0900, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure. Thus, it is not needed to manually clear the
> device driver data to NULL.
Please split that into two patches, one for msm and one for omap so that
I can put them into their respective topic-branches. Also add the
Acked-by while you are at it, please.
Thanks,
Joerg
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] iommu: remove unnecessary platform_set_drvdata()
2013-09-24 12:41 ` 'Joerg Roedel'
@ 2013-09-25 1:36 ` Jingoo Han
0 siblings, 0 replies; 5+ messages in thread
From: Jingoo Han @ 2013-09-25 1:36 UTC (permalink / raw)
To: 'Joerg Roedel'
Cc: 'Andrew Morton', linux-kernel, 'David Brown',
'Stephen Boyd', 'Suman Anna',
'Jingoo Han'
On Tuesday, September 24, 2013 9:42 PM, Joerg Roedel wrote:
> On Thu, Aug 22, 2013 at 10:53:01AM +0900, Jingoo Han wrote:
> > The driver core clears the driver data to NULL after device_release
> > or on probe failure. Thus, it is not needed to manually clear the
> > device driver data to NULL.
>
> Please split that into two patches, one for msm and one for omap so that
> I can put them into their respective topic-branches. Also add the
> Acked-by while you are at it, please.
>
Hi Joerg Roedel,
This patch was already merged to v3.12-rc1 through mm-tree.
Commit: 5e42781 "drivers/iommu: remove unnecessary platform_set_drvdata()"
Thank you for caring. :-)
Best regards,
Jingoo Han
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] iommu: remove unnecessary platform_set_drvdata()
2013-08-22 1:53 [PATCH] iommu: remove unnecessary platform_set_drvdata() Jingoo Han
2013-08-22 2:03 ` Libo Chen
2013-09-24 12:41 ` 'Joerg Roedel'
@ 2013-09-24 19:28 ` David Brown
2 siblings, 0 replies; 5+ messages in thread
From: David Brown @ 2013-09-24 19:28 UTC (permalink / raw)
To: Jingoo Han
Cc: Andrew Morton, linux-kernel, 'Stephen Boyd',
'Joerg Roedel', 'Suman Anna'
On Thu, Aug 22, 2013 at 10:53:01AM +0900, Jingoo Han wrote:
>The driver core clears the driver data to NULL after device_release
>or on probe failure. Thus, it is not needed to manually clear the
>device driver data to NULL.
>
>Signed-off-by: Jingoo Han <jg1.han@samsung.com>
>---
> drivers/iommu/msm_iommu_dev.c | 2 --
With the splitting:
Acked-by: David Brown <davidb@codeaurora.org>
--
sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-09-25 1:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-22 1:53 [PATCH] iommu: remove unnecessary platform_set_drvdata() Jingoo Han
2013-08-22 2:03 ` Libo Chen
2013-09-24 12:41 ` 'Joerg Roedel'
2013-09-25 1:36 ` Jingoo Han
2013-09-24 19:28 ` David Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).