From: Nishanth Menon <nm@ti.com>
To: Jingoo Han <jg1.han@samsung.com>
Cc: "'Mark Brown'" <broonie@kernel.org>,
"'Liam Girdwood'" <lgirdwood@gmail.com>,
<linux-kernel@vger.kernel.org>, "'Balaji T K'" <balajitk@ti.com>
Subject: Re: [PATCH 19/20] regulator: twl: use devm_regulator_register()
Date: Wed, 25 Sep 2013 07:59:42 -0500 [thread overview]
Message-ID: <20130925125942.GA21425@kahuna> (raw)
In-Reply-To: <001c01ceb9c7$72a353e0$57e9fba0$%han@samsung.com>
On 17:15-20130925, Jingoo Han wrote:
> Use devm_regulator_register() to make cleanup paths simpler.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/regulator/twl-regulator.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/regulator/twl-regulator.c b/drivers/regulator/twl-regulator.c
> index 78aae4c..8ebd785 100644
> --- a/drivers/regulator/twl-regulator.c
> +++ b/drivers/regulator/twl-regulator.c
> @@ -1188,7 +1188,7 @@ static int twlreg_probe(struct platform_device *pdev)
> config.driver_data = info;
> config.of_node = pdev->dev.of_node;
>
> - rdev = regulator_register(&info->desc, &config);
> + rdev = devm_regulator_register(&pdev->dev, &info->desc, &config);
> if (IS_ERR(rdev)) {
> dev_err(&pdev->dev, "can't register %s, %ld\n",
> info->desc.name, PTR_ERR(rdev));
> @@ -1217,7 +1217,6 @@ static int twlreg_remove(struct platform_device *pdev)
> struct regulator_dev *rdev = platform_get_drvdata(pdev);
> struct twlreg_info *info = rdev->reg_data;
>
> - regulator_unregister(rdev);
> kfree(info);
> return 0;
> }
> --
> 1.7.10.4
>
>
Acked-by: Nishanth Menon <nm@ti.com>
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2013-09-25 12:59 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-25 7:48 [PATCH 01/20] regulator: ab3100: use devm_regulator_register() Jingoo Han
2013-09-25 7:51 ` [PATCH 02/20] regulator: ab8500: " Jingoo Han
2013-09-25 10:20 ` Sachin Kamat
2013-09-26 1:25 ` Jingoo Han
2013-09-25 7:52 ` [PATCH 03/20] regulator: ab8500-ext: " Jingoo Han
2013-09-25 7:55 ` [PATCH 04/20] regulator: da9063: " Jingoo Han
2013-09-25 7:56 ` [PATCH 05/20] regulator: da9210: " Jingoo Han
2013-09-25 7:58 ` [PATCH 06/20] regulator: fixed: " Jingoo Han
2013-09-25 8:00 ` [PATCH 07/20] regulator: gpio-regulator: " Jingoo Han
2013-09-25 8:01 ` [PATCH 08/20] regulator: lp3971: " Jingoo Han
2013-09-25 8:02 ` [PATCH 09/20] regulator: lp3972: " Jingoo Han
2013-09-25 10:17 ` Sachin Kamat
2013-09-26 1:17 ` Jingoo Han
2013-09-25 8:03 ` [PATCH 10/20] regulator: lp872x: " Jingoo Han
2013-09-25 8:04 ` [PATCH 11/20] regulator: lp8788-buck: " Jingoo Han
2013-09-25 8:05 ` [PATCH 12/20] regulator: lp8788-ldo: " Jingoo Han
2013-09-25 8:06 ` [PATCH 13/20] regulator: max8925: " Jingoo Han
2013-09-25 8:08 ` [PATCH 14/20] regulator: max8952: " Jingoo Han
2013-09-25 8:09 ` [PATCH 15/20] regulator: pcap: " Jingoo Han
2013-09-25 8:11 ` [PATCH 16/20] regulator: pcf50633: " Jingoo Han
2013-09-25 8:12 ` [PATCH 17/20] regulator: tps6105x: " Jingoo Han
2013-09-27 12:42 ` Linus Walleij
2013-09-25 8:13 ` [PATCH 18/20] regulator: tps6524x: " Jingoo Han
2013-09-25 8:15 ` [PATCH 19/20] regulator: twl: " Jingoo Han
2013-09-25 12:59 ` Nishanth Menon [this message]
2013-09-25 8:17 ` [PATCH 20/20] regulator: vexpress: " Jingoo Han
2013-09-25 10:56 ` Pawel Moll
2013-09-27 12:41 ` [PATCH 01/20] regulator: ab3100: " Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130925125942.GA21425@kahuna \
--to=nm@ti.com \
--cc=balajitk@ti.com \
--cc=broonie@kernel.org \
--cc=jg1.han@samsung.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox