From: Josh Triplett <josh@joshtriplett.org>
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, mingo@kernel.org,
laijs@cn.fujitsu.com, dipankar@in.ibm.com,
akpm@linux-foundation.org, mathieu.desnoyers@efficios.com,
niv@us.ibm.com, tglx@linutronix.de, peterz@infradead.org,
rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com,
darren@dvhart.com, fweisbec@gmail.com, sbw@mit.edu,
Michael Opdenacker <michael.opdenacker@free-electrons.com>
Subject: Re: [PATCH tip/core/rcu 3/3] rcu: Fix occurrence of "the the" in checklist.txt
Date: Wed, 25 Sep 2013 08:33:21 -0700 [thread overview]
Message-ID: <20130925153321.GA6269@leaf> (raw)
In-Reply-To: <20130925135527.GS9093@linux.vnet.ibm.com>
On Wed, Sep 25, 2013 at 06:55:27AM -0700, Paul E. McKenney wrote:
> On Tue, Sep 24, 2013 at 08:47:39PM -0700, Josh Triplett wrote:
> > On Tue, Sep 24, 2013 at 06:17:23PM -0700, Paul E. McKenney wrote:
> > > From: Michael Opdenacker <michael.opdenacker@free-electrons.com>
> > >
> > > Signed-off-by: Michael Opdenacker <michael.opdenacker@free-electrons.com>
> > > Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> > > ---
> >
> > See comment below.
> >
> > > Documentation/RCU/checklist.txt | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/Documentation/RCU/checklist.txt b/Documentation/RCU/checklist.txt
> > > index 7703ec7..ad6cba4 100644
> > > --- a/Documentation/RCU/checklist.txt
> > > +++ b/Documentation/RCU/checklist.txt
> > > @@ -203,7 +203,7 @@ over a rather long period of time, but improvements are always welcome!
> > > the corresponding readers must disable preemption, possibly
> > > by calling rcu_read_lock_sched() and rcu_read_unlock_sched().
> > > If the updater uses synchronize_srcu() or call_srcu(),
> > > - the the corresponding readers must use srcu_read_lock() and
> > > + the corresponding readers must use srcu_read_lock() and
> >
> > I think this may have actually been a typo for "then", as in "If the
> > updater uses ..., then the corresponding readers must use ...".
>
> Good point -- that would make the sentence construction parallel with
> the surrounding sentences. Updated patch below.
>
> Thanx, Paul
>
> rcu: Fix occurrence of "the the" in checklist.txt
>
> Signed-off-by: Michael Opdenacker <michael.opdenacker@free-electrons.com>
> Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> [ paulmck: Add "then" as suggested by Josh Triplett. ]
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> diff --git a/Documentation/RCU/checklist.txt b/Documentation/RCU/checklist.txt
> index 7703ec7..9126619 100644
> --- a/Documentation/RCU/checklist.txt
> +++ b/Documentation/RCU/checklist.txt
> @@ -202,8 +202,8 @@ over a rather long period of time, but improvements are always welcome!
> updater uses call_rcu_sched() or synchronize_sched(), then
> the corresponding readers must disable preemption, possibly
> by calling rcu_read_lock_sched() and rcu_read_unlock_sched().
> - If the updater uses synchronize_srcu() or call_srcu(),
> - the the corresponding readers must use srcu_read_lock() and
> + If the updater uses synchronize_srcu() or call_srcu(), then
> + the corresponding readers must use srcu_read_lock() and
> srcu_read_unlock(), and with the same srcu_struct. The rules for
> the expedited primitives are the same as for their non-expedited
> counterparts. Mixing things up will result in confusion and
>
next prev parent reply other threads:[~2013-09-25 15:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-25 1:16 [PATCH tip/core/rcu 0/3] Documentation updates for 3.13 Paul E. McKenney
2013-09-25 1:17 ` [PATCH tip/core/rcu 1/3] rcu: Update stall-warning documentation Paul E. McKenney
2013-09-25 1:17 ` [PATCH tip/core/rcu 2/3] kthread: Add pointer to vmstat-avoidance patch Paul E. McKenney
2013-09-25 1:17 ` [PATCH tip/core/rcu 3/3] rcu: Fix occurrence of "the the" in checklist.txt Paul E. McKenney
2013-09-25 3:47 ` Josh Triplett
2013-09-25 13:55 ` Paul E. McKenney
2013-09-25 15:33 ` Josh Triplett [this message]
2013-09-25 17:13 ` Paul E. McKenney
2013-09-25 18:22 ` Michael Opdenacker
2013-09-25 3:48 ` [PATCH tip/core/rcu 0/3] Documentation updates for 3.13 Josh Triplett
2013-09-25 13:55 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130925153321.GA6269@leaf \
--to=josh@joshtriplett.org \
--cc=akpm@linux-foundation.org \
--cc=darren@dvhart.com \
--cc=dhowells@redhat.com \
--cc=dipankar@in.ibm.com \
--cc=edumazet@google.com \
--cc=fweisbec@gmail.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=michael.opdenacker@free-electrons.com \
--cc=mingo@kernel.org \
--cc=niv@us.ibm.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sbw@mit.edu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox