From: Al Viro <viro@ZenIV.linux.org.uk>
To: Joe Perches <joe@perches.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andy Whitcroft <apw@shadowen.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] checkpatch: Find CamelCase definitions of struct/union/enum
Date: Wed, 25 Sep 2013 17:19:49 +0100 [thread overview]
Message-ID: <20130925161949.GZ13318@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1380123344.17366.5.camel@joe-AO722>
On Wed, Sep 25, 2013 at 08:35:44AM -0700, Joe Perches wrote:
> We disagree.
Obviously.
> I think Propercase should be discouraged.
> ie: Qdisc et al.
Excuse me, but "Joe happens to think that something should be discouraged"
is not a problem. "Joe uses checkpatch.pl as force multiplier, recruiting
hundreds of monkeys to enforce his personal preferences", OTOH, very much is.
You are calling for ban on any mixed-case identifiers. I see at least three
cases where they can be legitimate:
* labels a-la Enomem, etc. I've been using those and I will
keep doing so, checkpatch.pl and its users be damned.
* enum members, to distinguish those from defines (first letter
capitalized vs. all-caps).
* (local) typedefs for structs; I really don't like their use for
anything non-local, but IMO they have their uses in cases like e.g.
fs/binfmt_misc.c
next prev parent reply other threads:[~2013-09-25 16:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-24 18:38 [PATCH] checkpatch: Find CamelCase definitions of struct/union/enum Joe Perches
2013-09-25 15:24 ` Al Viro
2013-09-25 15:35 ` Joe Perches
2013-09-25 16:19 ` Al Viro [this message]
2013-09-25 17:27 ` Alexander Holler
2013-09-25 19:22 ` Joe Perches
2013-09-25 19:30 ` Theodore Ts'o
2013-09-25 19:48 ` Joe Perches
2013-09-25 19:54 ` Alexander Holler
2013-09-25 20:03 ` Andrew Morton
2013-09-25 20:23 ` Al Viro
2013-09-26 1:10 ` Theodore Ts'o
2013-09-26 1:13 ` Andrew Morton
2013-09-25 20:11 ` Al Viro
2013-09-26 0:38 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130925161949.GZ13318@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=apw@shadowen.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox