From: Ingo Molnar <mingo@kernel.org>
To: Borislav Petkov <bp@alien8.de>
Cc: hpa@zytor.com, linux-kernel@vger.kernel.org,
huawei.libin@huawei.com, wangyijing@huawei.com,
fenghua.yu@intel.com, tglx@linutronix.de, guohanjun@huawei.com,
paul.gortmaker@windriver.com, linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/urgent] x86/smpboot: Fix announce_cpu() to printk() the last "OK" properly
Date: Wed, 25 Sep 2013 20:29:36 +0200 [thread overview]
Message-ID: <20130925182936.GD16693@gmail.com> (raw)
In-Reply-To: <20130925100722.GB3433@nazgul.tnic>
* Borislav Petkov <bp@alien8.de> wrote:
> On Thu, Sep 05, 2013 at 10:52:15AM -0700, tip-bot for Libin wrote:
> > Commit-ID: 52239484bf8aec031afa84ae08aa88224d819b93
> > Gitweb: http://git.kernel.org/tip/52239484bf8aec031afa84ae08aa88224d819b93
> > Author: Libin <huawei.libin@huawei.com>
> > AuthorDate: Thu, 5 Sep 2013 18:57:56 +0800
> > Committer: Ingo Molnar <mingo@kernel.org>
> > CommitDate: Thu, 5 Sep 2013 15:05:37 +0200
> >
> > x86/smpboot: Fix announce_cpu() to printk() the last "OK" properly
> >
> > When booting secondary CPUs, announce_cpu() is called to show which cpu has
> > been brought up. For example:
> >
> > [ 0.402751] smpboot: Booting Node 0, Processors #1 #2 #3 #4 #5 OK
> > [ 0.525667] smpboot: Booting Node 1, Processors #6 #7 #8 #9 #10 #11 OK
> > [ 0.755592] smpboot: Booting Node 0, Processors #12 #13 #14 #15 #16 #17 OK
> > [ 0.890495] smpboot: Booting Node 1, Processors #18 #19 #20 #21 #22 #23
> >
> > But the last "OK" is lost, because 'nr_cpu_ids-1' represents the maximum
> > possible cpu id. It should use the maximum present cpu id in case not all
> > CPUs booted up.
> >
> > Signed-off-by: Libin <huawei.libin@huawei.com>
> > Cc: <guohanjun@huawei.com>
> > Cc: <wangyijing@huawei.com>
> > Cc: <fenghua.yu@intel.com>
> > Cc: <paul.gortmaker@windriver.com>
> > Link: http://lkml.kernel.org/r/1378378676-18276-1-git-send-email-huawei.libin@huawei.com
> > [ tweaked the changelog, removed unnecessary line break, tweaked the format to align the fields vertically. ]
> > Signed-off-by: Ingo Molnar <mingo@kernel.org>
>
> Hmm, this one kinda funnied up output on smaller boxes:
>
> [ 0.089340] smpboot: Booting Node 0, Processors # 1
> [ 0.105930] SMP alternatives: lockdep: fixing up alternatives
> [ 0.106073] # 2
> [ 0.122237] SMP alternatives: lockdep: fixing up alternatives
> [ 0.122384] # 3 OK
> [ 0.136464] Brought up 4 CPUs
> [ 0.136539] smpboot: Total of 4 processors activated (23146.40 BogoMIPS)
Indeed, that should be fixed.
Thanks,
Ingo
next prev parent reply other threads:[~2013-09-25 18:29 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-05 10:57 [PATCH] x86, smpboot: fix announce_cpu() to print the last OK Libin
2013-09-05 17:52 ` [tip:x86/urgent] x86/smpboot: Fix announce_cpu() to printk() the last "OK" properly tip-bot for Libin
2013-09-25 10:07 ` Borislav Petkov
2013-09-25 18:29 ` Ingo Molnar [this message]
2013-09-26 23:15 ` Borislav Petkov
2013-09-27 6:51 ` Ingo Molnar
2013-09-27 10:38 ` Borislav Petkov
2013-09-27 14:32 ` Borislav Petkov
2013-09-27 14:34 ` [PATCH 1/2] x86, alternatives: Drop ancient lockdep fixup message Borislav Petkov
2013-09-28 8:28 ` [tip:core/locking] lockdep, x86/alternatives: " tip-bot for Borislav Petkov
2013-09-27 14:35 ` [PATCH 2/2] x86: Cleanup boot CPUs table Borislav Petkov
2013-09-28 8:25 ` Ingo Molnar
2013-09-28 10:23 ` Borislav Petkov
2013-09-28 13:44 ` Ingo Molnar
2013-09-28 17:47 ` [PATCH] x86, boot: Further compress CPUs bootup message Borislav Petkov
2013-09-28 17:54 ` Ingo Molnar
2013-09-28 18:04 ` [PATCH -v1.1] " Borislav Petkov
2013-09-28 18:12 ` Ingo Molnar
2013-09-28 19:15 ` Borislav Petkov
2013-09-28 19:25 ` Ingo Molnar
2013-09-28 19:36 ` [PATCH -v1.3] " Borislav Petkov
2013-09-28 19:42 ` [PATCH -v1.1] " H. Peter Anvin
2013-09-28 19:49 ` Borislav Petkov
2013-09-28 19:54 ` Borislav Petkov
2013-09-28 19:58 ` Ingo Molnar
2013-09-28 20:08 ` Borislav Petkov
2013-09-28 23:13 ` H. Peter Anvin
2013-09-29 9:14 ` Borislav Petkov
2013-09-29 15:17 ` [PATCH -v1.4] " Borislav Petkov
2013-09-29 15:44 ` [PATCH -v1.1] " H. Peter Anvin
2013-09-30 6:28 ` Ingo Molnar
2013-09-30 9:56 ` Borislav Petkov
2013-10-01 8:53 ` Ingo Molnar
2013-10-01 9:10 ` [tip:x86/boot] x86/boot: " tip-bot for Borislav Petkov
2013-10-02 11:52 ` Peter Zijlstra
2013-10-02 12:18 ` Ingo Molnar
2013-10-02 12:20 ` Peter Zijlstra
2013-10-02 13:55 ` Borislav Petkov
2013-09-28 19:58 ` [PATCH -v1.1] x86, boot: " Ingo Molnar
2013-09-28 20:10 ` Borislav Petkov
2013-09-29 5:10 ` H. Peter Anvin
2013-09-29 2:55 ` [PATCH 2/2] x86: Cleanup boot CPUs table Mike Galbraith
2013-09-28 8:28 ` [tip:x86/boot] x86: Improve the printout of the SMP bootup CPU table tip-bot for Borislav Petkov
2013-09-29 4:25 ` Yinghai Lu
2013-09-27 12:48 ` [tip:x86/urgent] x86/smpboot: Fix announce_cpu() to printk() the last "OK" properly Borislav Petkov
2013-09-27 13:33 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130925182936.GD16693@gmail.com \
--to=mingo@kernel.org \
--cc=bp@alien8.de \
--cc=fenghua.yu@intel.com \
--cc=guohanjun@huawei.com \
--cc=hpa@zytor.com \
--cc=huawei.libin@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=tglx@linutronix.de \
--cc=wangyijing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).