Re: [PATCH 6/7] irq: Optimize softirq stack selection in irq exit

Frederic Weisbecker
2013-09-26T07:12:17Z

On Wed, Sep 25, 2013 at 04:04:28PM -0700, Linus Torvalds wrote:
> On Wed, Sep 25, 2013 at 9:18 AM, Frederic Weisbecker <fweisbec@gmail.com> wrote:
> > +#ifdef __ARCH_IRQ_EXIT_ON_IRQ_STACK
>
> Please don't introduce anymore of these insane ad-hoc crazy architecture macros.
>
> Just make it a regular config option, which makes it much easier for
> architectures to just select it at config time.
>
> So make it something like CONFIG_IRQ_EXIT_ON_IRQ_STACK, and then
> x86-64 (and now Power) can just do
>
> select IRQ_EXIT_ON_IRQ_STACK
>
> in their arch/*/Kconfig files.
>
> Basically, we really should strive to get rid of all those insane
> [__]ARCH_xyzzy flags. We have too many of them, and they are insane.

Ok, I'll convert that and x86,powerpc along.

Thanks.

>
> Linus