From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Bill Pemberton <wfp5p@virginia.edu>
Subject: Re: [PATCH] staging: dgrp: Convert to use device_create_with_groups
Date: Wed, 25 Sep 2013 16:02:44 -0700 [thread overview]
Message-ID: <20130925230244.GA4740@kroah.com> (raw)
In-Reply-To: <1377989766-7462-1-git-send-email-linux@roeck-us.net>
On Sat, Aug 31, 2013 at 03:56:06PM -0700, Guenter Roeck wrote:
> Use device_create_with_groups to create sysfs attributes together with device.
> Also create class attribute together with class registration.
> This simplifies the code and ensures that attribute files exist when udev
> events are generated.
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> I suspect that the 'register_with_sysfs' attribute exists to work around
> the problem solved with this patch. It doesn't make much sense otherwise.
> Can it be removed ?
All of these sysfs files can be removed, they shouldn't be there, as it
looks like they are used for odd configuration things.
And a single tty driver shouldn't be a "class" at all.
sorry,
greg k-h
next prev parent reply other threads:[~2013-09-25 23:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-31 22:56 [PATCH] staging: dgrp: Convert to use device_create_with_groups Guenter Roeck
2013-09-25 23:02 ` Greg Kroah-Hartman [this message]
2013-09-25 23:06 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130925230244.GA4740@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wfp5p@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox