From: Greg KH <gregkh@linuxfoundation.org>
To: Iker Pedrosa <ikerpedrosam@gmail.com>
Cc: pavel@ucw.cz, devel@driverdev.osuosl.org, harsh1kumar@gmail.com,
linux-kernel@vger.kernel.org, mujeeb.adil@gmail.com,
dan.carpenter@oracle.com
Subject: Re: [PATCH v2 08/24] Staging: winbond: reg: changed sleep function from msleep to usleep
Date: Wed, 25 Sep 2013 16:44:03 -0700 [thread overview]
Message-ID: <20130925234403.GA4242@kroah.com> (raw)
In-Reply-To: <1379339024-12157-9-git-send-email-ikerpedrosam@gmail.com>
On Mon, Sep 16, 2013 at 03:43:28PM +0200, Iker Pedrosa wrote:
> According to the documentation it is not recommended to use msleep for 1ms - 20ms because it may sleep longer than 20ms. So, it is recommended to use usleep instead.
>
> In the first revision Greg KH pointed out that this change broke the build. In my computer it builds properly so if someone has the same problem please copy the output so that I can figure out what is the problem.
Please wrap your changelog comments.
The error is:
drivers/staging/winbond/reg.c: In function ‘Uxx_power_on_procedure’:
drivers/staging/winbond/reg.c:887:3: error: implicit declaration of function ‘usleep’ [-Werror=implicit-function-declaration]
And I'm still getting it on this patch, so please fix it up, it should
be pretty obvious how to do it...
I've applied the first 7 patches here, but stopped now. Please fix this
up and resend the remaining patches.
thanks,
greg k-h
next prev parent reply other threads:[~2013-09-25 23:44 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-16 13:43 [PATCH v2 00/24] Staging: winbond: Fixed some coding style issues Iker Pedrosa
2013-09-16 13:43 ` [PATCH v2 01/24] Staging: winbond: mto: removed function declaration Iker Pedrosa
2013-09-16 13:43 ` [PATCH v2 02/24] Staging: winbond: mto: avoided use of extern functions Iker Pedrosa
2013-09-16 13:43 ` [PATCH v2 03/24] Staging: winbond: mto: deleted " Iker Pedrosa
2013-09-16 13:43 ` [PATCH v2 04/24] Staging: winbond: phy_calibration: first of the patches that fixes lines over 80 characters Iker Pedrosa
2013-09-16 13:43 ` [PATCH v2 05/24] Staging: winbond: phy_calibration: second " Iker Pedrosa
2013-09-16 13:43 ` [PATCH v2 06/24] Staging: winbond: reg: erased trailing whitespace Iker Pedrosa
2013-09-16 13:43 ` [PATCH v2 07/24] Staging: winbond: reg: white space deleted Iker Pedrosa
2013-09-16 13:43 ` [PATCH v2 08/24] Staging: winbond: reg: changed sleep function from msleep to usleep Iker Pedrosa
2013-09-25 23:44 ` Greg KH [this message]
2013-09-16 13:43 ` [PATCH v2 09/24] Staging: winbond: reg: first of the patches that fixes lines over 80 characters Iker Pedrosa
2013-09-16 13:43 ` [PATCH v2 10/24] Staging: winbond: reg: second " Iker Pedrosa
2013-09-16 13:43 ` [PATCH v2 11/24] Staging: winbond: reg: third " Iker Pedrosa
2013-09-16 13:43 ` [PATCH v2 12/24] Staging: winbond: reg: fourth " Iker Pedrosa
2013-09-16 13:43 ` [PATCH v2 13/24] Staging: winbond: reg: fifth " Iker Pedrosa
2013-09-16 13:43 ` [PATCH v2 14/24] Staging: winbond: reg: sixth " Iker Pedrosa
2013-09-16 13:43 ` [PATCH v2 15/24] Staging: winbond: reg: seventh " Iker Pedrosa
[not found] ` <CANBXnMm7QCab3cU4NMzmA3OjXckcUx5dakyD_TRwfj3j2_02MA@mail.gmail.com>
2013-09-17 9:43 ` Dan Carpenter
2013-09-20 14:45 ` Iker Pedrosa
2013-09-21 9:32 ` Dan Carpenter
2013-09-16 13:43 ` [PATCH v2 16/24] Staging: winbond: wb35reg_f: fixed " Iker Pedrosa
2013-09-16 13:43 ` [PATCH v2 17/24] Staging: winbond: wb35reg_s: deleted space before tabulation Iker Pedrosa
2013-09-16 13:43 ` [PATCH v2 18/24] Staging: winbond: wb35rx: changed sleep function from msleep to usleep Iker Pedrosa
2013-09-16 13:43 ` [PATCH v2 19/24] Staging: winbond: wb35rx: fixed some lines over 80 characters Iker Pedrosa
2013-09-16 13:43 ` [PATCH v2 20/24] Staging: winbond: wb35tx: changed sleep function from msleep to usleep Iker Pedrosa
2013-09-16 13:43 ` [PATCH v2 21/24] Staging: winbond: wb35tx: Replace printk with netdev_err Iker Pedrosa
2013-09-17 16:35 ` Joe Perches
2013-09-25 14:39 ` [PATCH v3 21/24] Staging: winbond: wb35tx: Replace printk with netdev Iker Pedrosa
2013-09-26 0:03 ` Pavel Machek
2013-09-16 13:43 ` [PATCH v2 22/24] Staging: winbond: wb35tx_s: erased the spaces after opening a '[' Iker Pedrosa
2013-09-16 13:43 ` [PATCH v2 23/24] Staging: winbond: wbusb: fixed some lines over 80 characters Iker Pedrosa
2013-09-16 13:43 ` [PATCH v2 24/24] Staging: winbond: wbusb: changed sleep function from msleep to usleep Iker Pedrosa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130925234403.GA4242@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=harsh1kumar@gmail.com \
--cc=ikerpedrosam@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mujeeb.adil@gmail.com \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox