public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@the-dreams.de>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: i2c-dev: Create 'name' attribute automatically
Date: Thu, 26 Sep 2013 10:28:35 +0200	[thread overview]
Message-ID: <20130926082835.GA3057@katana> (raw)
In-Reply-To: <20130925211104.GA2784@roeck-us.net>

[-- Attachment #1: Type: text/plain, Size: 601 bytes --]

Hi,

> > What race condition?
> > 
> 
> Userspace trying to access the name attribute before it is created.
> See http://kroah.com/log/blog/2013/06/26/how-to-create-a-sysfs-file-correctly/

Thanks!

> > Have you tried this with two instances? I don't think it will work since
> > class_register modifies the class struct.
> > 
> Half a dozen instances, actually. Unless I am missing something, seems to be

My bad. Sorry for the noise.

> Anyway, the patch is obsolete; one is supposed to use class->dev_groups now.

Are you willing to update the patch?

Thanks,

   Wolfram


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2013-09-26  8:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-31 16:30 [PATCH] i2c: i2c-dev: Create 'name' attribute automatically Guenter Roeck
2013-09-25 20:20 ` Wolfram Sang
2013-09-25 21:11   ` Guenter Roeck
2013-09-26  8:28     ` Wolfram Sang [this message]
2013-09-26 10:37       ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130926082835.GA3057@katana \
    --to=wsa@the-dreams.de \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox