From: Peter Zijlstra <peterz@infradead.org>
To: Mike Galbraith <bitbucket@online.de>
Cc: Ingo Molnar <mingo@kernel.org>, Paul Turner <pjt@google.com>,
Rik van Riel <riel@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH] sched: Avoid select_idle_sibling() for wake_affine(.sync=true)
Date: Thu, 26 Sep 2013 12:05:11 +0200 [thread overview]
Message-ID: <20130926100511.GJ26785@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20130926095812.GR3081@twins.programming.kicks-ass.net>
On Thu, Sep 26, 2013 at 11:58:12AM +0200, Peter Zijlstra wrote:
> @@ -3429,6 +3440,9 @@ select_task_rq_fair(struct task_struct *p, int sd_flag, int wake_flags)
> int want_affine = 0;
> int sync = wake_flags & WF_SYNC;
>
> + if (sync)
> + p->se.last_sync_wakeup = sched_clock_cpu(cpu);
> +
> if (p->nr_cpus_allowed == 1)
> return prev_cpu;
>
Oh, I suppose something like:
if (sync && !p->se.last_sync_wakeup)
p->se.last_sync_wakeup = sched_clock_cpu(cpu);
is also a nice variation to try..
next prev parent reply other threads:[~2013-09-26 10:05 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-25 7:53 [RFC][PATCH] sched: Avoid select_idle_sibling() for wake_affine(.sync=true) Peter Zijlstra
2013-09-25 8:56 ` Mike Galbraith
2013-09-26 2:50 ` Michael wang
2013-09-26 3:41 ` Mike Galbraith
2013-09-26 5:12 ` Michael wang
2013-09-26 5:34 ` Mike Galbraith
2013-09-26 6:15 ` Mike Galbraith
2013-09-26 6:32 ` Michael wang
2013-09-26 7:09 ` Mike Galbraith
2013-09-26 7:26 ` Michael wang
2013-09-26 9:58 ` Peter Zijlstra
2013-09-26 10:05 ` Peter Zijlstra [this message]
2013-09-26 10:55 ` Paul Turner
2013-09-26 11:16 ` Peter Zijlstra
2013-09-26 11:39 ` Paul Turner
2013-09-26 14:35 ` Peter Zijlstra
2013-09-26 15:43 ` Peter Zijlstra
2013-09-26 13:46 ` Mike Galbraith
2013-09-26 15:09 ` Michael wang
2013-09-26 15:44 ` Peter Zijlstra
2013-09-27 1:19 ` Michael wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130926100511.GJ26785@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bitbucket@online.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=pjt@google.com \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox