From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: David Ahern <dsahern@gmail.com>
Cc: Sonny Rao <sonnyrao@chromium.org>,
linux-kernel@vger.kernel.org,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@redhat.com>, Jiri Olsa <jolsa@redhat.com>,
Namhyung Kim <namhyung@kernel.org>,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH] perf: fix infinite loop with corrupted header
Date: Thu, 26 Sep 2013 10:46:40 -0300 [thread overview]
Message-ID: <20130926134640.GA26159@ghostprotocols.net> (raw)
In-Reply-To: <52443800.5080200@gmail.com>
Em Thu, Sep 26, 2013 at 07:34:56AM -0600, David Ahern escreveu:
> On 9/25/13 11:20 PM, Sonny Rao wrote:
> >We recently ran into a corrupt perf data file which mostly looked okay
> >but the section size for data was set to 0. This caused perf report to
> >get into an infinite loop in __perf_session_process_events(). Let's
> >just avoid this by bailing early and reporting it if there's an
> >invalid header.
>
> Been suggested before:
> https://lkml.org/lkml/2013/5/9/405
Thanks for the pointer (and this latest patch as well), looking at it
now.
- Arnaldo
> Other changes went in around that time as well. Are you still seeing
> the loop on latest source?
>
> David
next prev parent reply other threads:[~2013-09-26 13:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-26 5:20 [PATCH] perf: fix infinite loop with corrupted header Sonny Rao
2013-09-26 13:34 ` David Ahern
2013-09-26 13:46 ` Arnaldo Carvalho de Melo [this message]
2013-09-26 13:59 ` Namhyung Kim
2013-09-26 14:06 ` Arnaldo Carvalho de Melo
2013-09-27 1:33 ` Namhyung Kim
2013-09-26 17:33 ` Sonny Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130926134640.GA26159@ghostprotocols.net \
--to=acme@ghostprotocols.net \
--cc=a.p.zijlstra@chello.nl \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=sonnyrao@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox