From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sudeep Dutt <sudeep.dutt@intel.com>
Cc: Joe Perches <joe@perches.com>,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
Nikhil Rao <nikhil.rao@intel.com>,
Ashutosh Dixit <ashutosh.dixit@intel.com>,
Dasaratharaman Chandramouli
<dasaratharaman.chandramouli@intel.com>,
Harshavardhan R Kharche <harshavardhan.r.kharche@intel.com>,
"Yaozu (Eddie) Dong" <eddie.dong@intel.com>,
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Subject: Re: [PATCH CHAR-MISC-NEXT 2/4] Intel MIC Driver Header File Cleanups.
Date: Thu, 26 Sep 2013 20:16:54 -0700 [thread overview]
Message-ID: <20130927031654.GB13086@kroah.com> (raw)
In-Reply-To: <1db9ec1d28297b01c01f0f4089cb5ce559906ac8.1380241770.git.sudeep.dutt@intel.com>
On Thu, Sep 26, 2013 at 06:10:01PM -0700, Sudeep Dutt wrote:
> Dont use same name for header files in different folders.
>
> These changes were suggested by Greg Kroah-Hartman during the
> code review @ https://lkml.org/lkml/2013/9/6/18
>
> Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
> Signed-off-by: Dasaratharaman Chandramouli <dasaratharaman.chandramouli@intel.com>
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> Signed-off-by: Harshavardhan R Kharche <harshavardhan.r.kharche@intel.com>
> Signed-off-by: Sudeep Dutt <sudeep.dutt@intel.com>
> ---
> drivers/misc/mic/card/mic_debugfs.c | 2 +-
> drivers/misc/mic/card/mic_device.c | 2 +-
> drivers/misc/mic/card/mic_virtio.c | 2 +-
> drivers/misc/mic/card/mic_x100.c | 2 +-
> drivers/misc/mic/common/mic_dev.h | 51 ++++++++++++++++++++++++++++++++++++
> drivers/misc/mic/common/mic_device.h | 51 ------------------------------------
> drivers/misc/mic/host/mic_boot.c | 2 +-
> drivers/misc/mic/host/mic_debugfs.c | 2 +-
> drivers/misc/mic/host/mic_fops.c | 2 +-
> drivers/misc/mic/host/mic_intr.c | 2 +-
> drivers/misc/mic/host/mic_main.c | 2 +-
> drivers/misc/mic/host/mic_smpt.c | 2 +-
> drivers/misc/mic/host/mic_sysfs.c | 2 +-
> drivers/misc/mic/host/mic_virtio.c | 2 +-
> drivers/misc/mic/host/mic_x100.c | 2 +-
> 15 files changed, 64 insertions(+), 64 deletions(-)
> create mode 100644 drivers/misc/mic/common/mic_dev.h
> delete mode 100644 drivers/misc/mic/common/mic_device.h
git should have shown this file being renamed, not added/removed.
Please use the -M option to it when generating patches so it will do the
right thing here.
thanks,
greg k-h
next prev parent reply other threads:[~2013-09-27 3:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-27 1:09 [PATCH CHAR-MISC-NEXT 0/4] Intel MIC Driver Cleanups Sudeep Dutt
2013-09-27 1:09 ` [PATCH CHAR-MISC-NEXT 1/4] Intel MIC Host Driver Sysfs Cleanups Sudeep Dutt
2013-09-27 3:15 ` Greg Kroah-Hartman
2013-09-27 1:10 ` [PATCH CHAR-MISC-NEXT 2/4] Intel MIC Driver Header File Cleanups Sudeep Dutt
2013-09-27 3:16 ` Greg Kroah-Hartman [this message]
2013-09-27 1:10 ` [PATCH CHAR-MISC-NEXT 3/4] Intel MIC Driver Cleanups for "--strict" checkpatch Sudeep Dutt
2013-09-27 1:10 ` [PATCH CHAR-MISC-NEXT 4/4] Intel MIC Header File warning fix Sudeep Dutt
2013-09-27 3:17 ` Greg Kroah-Hartman
2013-09-27 19:37 ` Sudeep Dutt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130927031654.GB13086@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=ashutosh.dixit@intel.com \
--cc=dasaratharaman.chandramouli@intel.com \
--cc=eddie.dong@intel.com \
--cc=harshavardhan.r.kharche@intel.com \
--cc=joe@perches.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nikhil.rao@intel.com \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=sudeep.dutt@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox