From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Aaron Lu <aaron.lu@intel.com>
Cc: linux-acpi@vger.kernel.org, intel-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
"Daniel Vetter" <daniel@ffwll.ch>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
"Matthew Garrett" <matthew.garrett@nebula.com>,
"Seth Forshee" <seth.forshee@canonical.com>,
"Lee Chun-Yi" <joeyli.kernel@gmail.com>,
"Richard Purdie" <rpurdie@rpsys.net>,
"Igor Gnatenko" <i.gnatenko.brain@gmail.com>,
"Yves-Alexis Perez" <corsac@debian.org>,
"Felipe Contreras" <felipe.contreras@gmail.com>,
"Henrique de Moraes Holschuh" <ibm-acpi@hmh.eng.br>,
"Jani Nikula" <jani.nikula@linux.intel.com>,
"Ben Jencks" <ben@bjencks.net>,
"Steven Newbury" <steve@snewbury.org.uk>,
"James Hogan" <james@albanarts.com>,
"Kamal Mostafa" <kamal@canonical.com>,
"Joerg Platte" <jplatte@naasa.net>,
"Kalle Valo" <kvalo@adurom.com>,
"Martin Steigerwald" <Martin@lichtvoll.de>,
"Jörg Otte" <jrg.otte@gmail.com>,
"Mike Galbraith" <bitbucket@online.de>
Subject: Re: [PATCH v3 0/4] Fix Win8 backlight issue
Date: Fri, 27 Sep 2013 14:02:27 +0300 [thread overview]
Message-ID: <20130927110227.GD28875@intel.com> (raw)
In-Reply-To: <1380016052-15315-1-git-send-email-aaron.lu@intel.com>
On Tue, Sep 24, 2013 at 05:47:28PM +0800, Aaron Lu wrote:
> v3:
> 1 Add a new patch 4/4 to fix some problems in thinkpad-acpi module;
> 2 Remove unnecessary function acpi_video_unregister introduced in
> patch 2/3 as pointed out by Jani Nikula.
>
> v2:
> v1 has the subject of "Rework ACPI video driver" and is posted here:
> http://lkml.org/lkml/2013/9/9/74
> Since the objective is really to fix Win8 backlight issues, I changed
> the subject in this version, sorry about that.
>
> This patchset has three patches, the first introduced a new API named
> backlight_device_registered in backlight layer that can be used for
> backlight interface provider module to check if a specific type backlight
> interface has been registered, see changelog for patch 1/3 for details.
> Then patch 2/3 does the cleanup to sepeate the backlight control and
> event delivery functionality in the ACPI video module and patch 3/3
> solves some Win8 backlight control problems by avoiding register ACPI
> video's backlight interface if:
> 1 Kernel cmdline option acpi_backlight=video is not given;
> 2 This is a Win8 system;
> 3 Native backlight control interface exists.
>
> Technically, patch 2/3 is not required to fix the issue here. So if you
> think it is not necessary, I can remove it from the series.
>
> Aaron Lu (4):
> backlight: introduce backlight_device_registered
> ACPI / video: seperate backlight control and event interface
> ACPI / video: Do not register backlight if win8 and native interface
> exists
> thinkpad-acpi: fix handle locate for video and query of _BCL
>
> drivers/acpi/internal.h | 5 +-
> drivers/acpi/video.c | 442 ++++++++++++++++++++---------------
> drivers/acpi/video_detect.c | 14 +-
> drivers/platform/x86/thinkpad_acpi.c | 31 ++-
> drivers/video/backlight/backlight.c | 31 +++
> include/acpi/video.h | 2 +
> include/linux/backlight.h | 4 +
> 7 files changed, 324 insertions(+), 205 deletions(-)
Just tested this series on my HP revolve 810 and this fixes the backlight
issue it had :)
Feel free to add my,
Tested-by: Mika Westerberg <mika.westerberg@linux.intel.com>
prev parent reply other threads:[~2013-09-27 10:57 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-24 9:47 [PATCH v3 0/4] Fix Win8 backlight issue Aaron Lu
2013-09-24 9:47 ` [PATCH v3 1/4] backlight: introduce backlight_device_registered Aaron Lu
2013-09-24 9:47 ` [PATCH v3 2/4] ACPI / video: seperate backlight control and event interface Aaron Lu
2013-09-24 9:54 ` Aaron Lu
2013-10-07 12:09 ` Rafael J. Wysocki
2013-09-24 9:47 ` [PATCH v3 3/4] ACPI / video: Do not register backlight if win8 and native interface exists Aaron Lu
2013-09-25 17:53 ` Rafael J. Wysocki
2013-09-26 5:15 ` Aaron Lu
2013-09-24 9:47 ` [PATCH v3 4/4] thinkpad-acpi: fix handle locate for video and query of _BCL Aaron Lu
2013-09-25 19:58 ` Henrique de Moraes Holschuh
2013-09-26 1:44 ` Aaron Lu
2013-09-27 15:16 ` Henrique de Moraes Holschuh
2013-09-27 15:20 ` Henrique de Moraes Holschuh
2013-09-27 15:33 ` Yves-Alexis Perez
2013-09-27 18:05 ` Henrique de Moraes Holschuh
2013-09-28 12:28 ` Yves-Alexis Perez
2013-09-24 12:42 ` [PATCH v3 0/4] Fix Win8 backlight issue Igor Gnatenko
[not found] ` <CADDKRnCAZ0DtBUUaMfdTF=yk6PDLpbc9jkuvWWO8hYW4TDLxKw@mail.gmail.com>
2013-09-25 9:17 ` Aaron Lu
2013-09-25 10:41 ` Jani Nikula
2013-09-25 15:51 ` Jörg Otte
2013-09-25 16:17 ` Jani Nikula
2013-09-26 7:49 ` Jörg Otte
2013-09-27 0:26 ` Rafael J. Wysocki
2013-09-28 16:34 ` Jörg Otte
2013-09-27 11:02 ` Mika Westerberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130927110227.GD28875@intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=Martin@lichtvoll.de \
--cc=aaron.lu@intel.com \
--cc=ben@bjencks.net \
--cc=bitbucket@online.de \
--cc=corsac@debian.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=felipe.contreras@gmail.com \
--cc=i.gnatenko.brain@gmail.com \
--cc=ibm-acpi@hmh.eng.br \
--cc=intel-gfx@lists.freedesktop.org \
--cc=james@albanarts.com \
--cc=jani.nikula@linux.intel.com \
--cc=joeyli.kernel@gmail.com \
--cc=jplatte@naasa.net \
--cc=jrg.otte@gmail.com \
--cc=kamal@canonical.com \
--cc=kvalo@adurom.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.garrett@nebula.com \
--cc=rjw@sisk.pl \
--cc=rpurdie@rpsys.net \
--cc=seth.forshee@canonical.com \
--cc=steve@snewbury.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).