Re: [PATCH] Staging: sm7xxfb: fixed line break coding style issues

Dan Carpenter
2013-09-27T15:46:47Z

On Fri, Sep 27, 2013 at 05:39:11PM +0200, Martin Berglund wrote:
> On Fri, Sep 27, 2013 at 03:27:29PM +0300, Dan Carpenter wrote:
> > On Fri, Sep 27, 2013 at 02:08:07PM +0200, Martin Berglund wrote:
> > > @@ -508,9 +506,8 @@ static void sm7xx_set_timing(struct smtcfb_info *sfb)
> > >
> > > /* init SEQ register SR30 - SR75 */
> > > for (i = 0; i < SIZE_SR30_SR75; i++)
> > > - if (((i + 0x30) != 0x62) \
> > > - && ((i + 0x30) != 0x6a) \
> > > - && ((i + 0x30) != 0x6b))
> > > + if (((i + 0x30) != 0x62) && ((i + 0x30) != 0x6a)
> > > + && ((i + 0x30) != 0x6b))
> >
> > The prefered way would be to align this like this:
> >
> > if ((i + 0x30) != 0x62 &&
> > (i + 0x30) != 0x6a &&
> > (i + 0x30) != 0x6b)
> >
> > regards,
> > dan carpenter
> >
>
> New patch.

Looks nice, but could you resend it in a way that can be a applied?

Take your original patch and change the subject to:
[PATCH v2] Staging: sm7xxfb: fixed line break coding style issues

Add "v2: minor style change" under the --- line.

regards,
dan carpenter