From: Dan Carpenter <dan.carpenter@oracle.com>
To: Martin Berglund <martin@rogsta.net>
Cc: teddy.wang@siliconmotion.com.cn, gregkh@linuxfoundation.org,
wfp5p@virginia.edu, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: sm7xxfb: fixed line break coding style issues
Date: Fri, 27 Sep 2013 18:46:19 +0300 [thread overview]
Message-ID: <20130927154619.GG6192@mwanda> (raw)
In-Reply-To: <1380296351-18906-1-git-send-email-martin@rogsta.net>
On Fri, Sep 27, 2013 at 05:39:11PM +0200, Martin Berglund wrote:
> On Fri, Sep 27, 2013 at 03:27:29PM +0300, Dan Carpenter wrote:
> > On Fri, Sep 27, 2013 at 02:08:07PM +0200, Martin Berglund wrote:
> > > @@ -508,9 +506,8 @@ static void sm7xx_set_timing(struct smtcfb_info *sfb)
> > >
> > > /* init SEQ register SR30 - SR75 */
> > > for (i = 0; i < SIZE_SR30_SR75; i++)
> > > - if (((i + 0x30) != 0x62) \
> > > - && ((i + 0x30) != 0x6a) \
> > > - && ((i + 0x30) != 0x6b))
> > > + if (((i + 0x30) != 0x62) && ((i + 0x30) != 0x6a)
> > > + && ((i + 0x30) != 0x6b))
> >
> > The prefered way would be to align this like this:
> >
> > if ((i + 0x30) != 0x62 &&
> > (i + 0x30) != 0x6a &&
> > (i + 0x30) != 0x6b)
> >
> > regards,
> > dan carpenter
> >
>
> New patch.
Looks nice, but could you resend it in a way that can be a applied?
Take your original patch and change the subject to:
[PATCH v2] Staging: sm7xxfb: fixed line break coding style issues
Add "v2: minor style change" under the --- line.
regards,
dan carpenter
prev parent reply other threads:[~2013-09-27 15:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-27 12:08 [PATCH] Staging: sm7xxfb: fixed line break coding style issues Martin Berglund
2013-09-27 12:27 ` Dan Carpenter
2013-09-27 15:39 ` Martin Berglund
2013-09-27 15:41 ` Greg KH
2013-09-27 15:46 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130927154619.GG6192@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin@rogsta.net \
--cc=teddy.wang@siliconmotion.com.cn \
--cc=wfp5p@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox