* [PATCH] Staging: sm7xxfb: fixed line break coding style issues
@ 2013-09-27 12:08 Martin Berglund
2013-09-27 12:27 ` Dan Carpenter
0 siblings, 1 reply; 5+ messages in thread
From: Martin Berglund @ 2013-09-27 12:08 UTC (permalink / raw)
To: teddy.wang; +Cc: gregkh, wfp5p, devel, linux-kernel, Martin Berglund
Fixed coding style issues.
Signed-off-by: Martin Berglund <martin@rogsta.net>
---
drivers/staging/sm7xxfb/sm7xxfb.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/sm7xxfb/sm7xxfb.c b/drivers/staging/sm7xxfb/sm7xxfb.c
index 8add64b..57d8145 100644
--- a/drivers/staging/sm7xxfb/sm7xxfb.c
+++ b/drivers/staging/sm7xxfb/sm7xxfb.c
@@ -259,8 +259,7 @@ static int smtc_setcolreg(unsigned regno, unsigned red, unsigned green,
if (sfb->fb.var.bits_per_pixel == 16) {
u32 *pal = sfb->fb.pseudo_palette;
val = chan_to_field(red, &sfb->fb.var.red);
- val |= chan_to_field(green, \
- &sfb->fb.var.green);
+ val |= chan_to_field(green, &sfb->fb.var.green);
val |= chan_to_field(blue, &sfb->fb.var.blue);
#ifdef __BIG_ENDIAN
pal[regno] =
@@ -274,8 +273,7 @@ static int smtc_setcolreg(unsigned regno, unsigned red, unsigned green,
} else {
u32 *pal = sfb->fb.pseudo_palette;
val = chan_to_field(red, &sfb->fb.var.red);
- val |= chan_to_field(green, \
- &sfb->fb.var.green);
+ val |= chan_to_field(green, &sfb->fb.var.green);
val |= chan_to_field(blue, &sfb->fb.var.blue);
#ifdef __BIG_ENDIAN
val =
@@ -508,9 +506,8 @@ static void sm7xx_set_timing(struct smtcfb_info *sfb)
/* init SEQ register SR30 - SR75 */
for (i = 0; i < SIZE_SR30_SR75; i++)
- if (((i + 0x30) != 0x62) \
- && ((i + 0x30) != 0x6a) \
- && ((i + 0x30) != 0x6b))
+ if (((i + 0x30) != 0x62) && ((i + 0x30) != 0x6a)
+ && ((i + 0x30) != 0x6b))
smtc_seqw(i + 0x30,
VGAMode[j].Init_SR30_SR75[i]);
--
1.8.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] Staging: sm7xxfb: fixed line break coding style issues
2013-09-27 12:08 [PATCH] Staging: sm7xxfb: fixed line break coding style issues Martin Berglund
@ 2013-09-27 12:27 ` Dan Carpenter
2013-09-27 15:39 ` Martin Berglund
0 siblings, 1 reply; 5+ messages in thread
From: Dan Carpenter @ 2013-09-27 12:27 UTC (permalink / raw)
To: Martin Berglund; +Cc: teddy.wang, devel, gregkh, wfp5p, linux-kernel
On Fri, Sep 27, 2013 at 02:08:07PM +0200, Martin Berglund wrote:
> @@ -508,9 +506,8 @@ static void sm7xx_set_timing(struct smtcfb_info *sfb)
>
> /* init SEQ register SR30 - SR75 */
> for (i = 0; i < SIZE_SR30_SR75; i++)
> - if (((i + 0x30) != 0x62) \
> - && ((i + 0x30) != 0x6a) \
> - && ((i + 0x30) != 0x6b))
> + if (((i + 0x30) != 0x62) && ((i + 0x30) != 0x6a)
> + && ((i + 0x30) != 0x6b))
The prefered way would be to align this like this:
if ((i + 0x30) != 0x62 &&
(i + 0x30) != 0x6a &&
(i + 0x30) != 0x6b)
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Staging: sm7xxfb: fixed line break coding style issues
2013-09-27 12:27 ` Dan Carpenter
@ 2013-09-27 15:39 ` Martin Berglund
2013-09-27 15:41 ` Greg KH
2013-09-27 15:46 ` Dan Carpenter
0 siblings, 2 replies; 5+ messages in thread
From: Martin Berglund @ 2013-09-27 15:39 UTC (permalink / raw)
To: dan.carpenter; +Cc: teddy.wang, gregkh, wfp5p, devel, linux-kernel, martin
On Fri, Sep 27, 2013 at 03:27:29PM +0300, Dan Carpenter wrote:
> On Fri, Sep 27, 2013 at 02:08:07PM +0200, Martin Berglund wrote:
> > @@ -508,9 +506,8 @@ static void sm7xx_set_timing(struct smtcfb_info *sfb)
> >
> > /* init SEQ register SR30 - SR75 */
> > for (i = 0; i < SIZE_SR30_SR75; i++)
> > - if (((i + 0x30) != 0x62) \
> > - && ((i + 0x30) != 0x6a) \
> > - && ((i + 0x30) != 0x6b))
> > + if (((i + 0x30) != 0x62) && ((i + 0x30) != 0x6a)
> > + && ((i + 0x30) != 0x6b))
>
> The prefered way would be to align this like this:
>
> if ((i + 0x30) != 0x62 &&
> (i + 0x30) != 0x6a &&
> (i + 0x30) != 0x6b)
>
> regards,
> dan carpenter
>
New patch.
Signed-off-by: Martin Berglund <martin@rogsta.net>
---
drivers/staging/sm7xxfb/sm7xxfb.c | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/sm7xxfb/sm7xxfb.c b/drivers/staging/sm7xxfb/sm7xxfb.c
index 8add64b..8ba0097 100644
--- a/drivers/staging/sm7xxfb/sm7xxfb.c
+++ b/drivers/staging/sm7xxfb/sm7xxfb.c
@@ -259,8 +259,7 @@ static int smtc_setcolreg(unsigned regno, unsigned red, unsigned green,
if (sfb->fb.var.bits_per_pixel == 16) {
u32 *pal = sfb->fb.pseudo_palette;
val = chan_to_field(red, &sfb->fb.var.red);
- val |= chan_to_field(green, \
- &sfb->fb.var.green);
+ val |= chan_to_field(green, &sfb->fb.var.green);
val |= chan_to_field(blue, &sfb->fb.var.blue);
#ifdef __BIG_ENDIAN
pal[regno] =
@@ -274,8 +273,7 @@ static int smtc_setcolreg(unsigned regno, unsigned red, unsigned green,
} else {
u32 *pal = sfb->fb.pseudo_palette;
val = chan_to_field(red, &sfb->fb.var.red);
- val |= chan_to_field(green, \
- &sfb->fb.var.green);
+ val |= chan_to_field(green, &sfb->fb.var.green);
val |= chan_to_field(blue, &sfb->fb.var.blue);
#ifdef __BIG_ENDIAN
val =
@@ -508,9 +506,9 @@ static void sm7xx_set_timing(struct smtcfb_info *sfb)
/* init SEQ register SR30 - SR75 */
for (i = 0; i < SIZE_SR30_SR75; i++)
- if (((i + 0x30) != 0x62) \
- && ((i + 0x30) != 0x6a) \
- && ((i + 0x30) != 0x6b))
+ if ((i + 0x30) != 0x62 &&
+ (i + 0x30) != 0x6a &&
+ (i + 0x30) != 0x6b)
smtc_seqw(i + 0x30,
VGAMode[j].Init_SR30_SR75[i]);
--
1.8.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] Staging: sm7xxfb: fixed line break coding style issues
2013-09-27 15:39 ` Martin Berglund
@ 2013-09-27 15:41 ` Greg KH
2013-09-27 15:46 ` Dan Carpenter
1 sibling, 0 replies; 5+ messages in thread
From: Greg KH @ 2013-09-27 15:41 UTC (permalink / raw)
To: Martin Berglund; +Cc: dan.carpenter, teddy.wang, wfp5p, devel, linux-kernel
On Fri, Sep 27, 2013 at 05:39:11PM +0200, Martin Berglund wrote:
> On Fri, Sep 27, 2013 at 03:27:29PM +0300, Dan Carpenter wrote:
> > On Fri, Sep 27, 2013 at 02:08:07PM +0200, Martin Berglund wrote:
> > > @@ -508,9 +506,8 @@ static void sm7xx_set_timing(struct smtcfb_info *sfb)
> > >
> > > /* init SEQ register SR30 - SR75 */
> > > for (i = 0; i < SIZE_SR30_SR75; i++)
> > > - if (((i + 0x30) != 0x62) \
> > > - && ((i + 0x30) != 0x6a) \
> > > - && ((i + 0x30) != 0x6b))
> > > + if (((i + 0x30) != 0x62) && ((i + 0x30) != 0x6a)
> > > + && ((i + 0x30) != 0x6b))
> >
> > The prefered way would be to align this like this:
> >
> > if ((i + 0x30) != 0x62 &&
> > (i + 0x30) != 0x6a &&
> > (i + 0x30) != 0x6b)
> >
> > regards,
> > dan carpenter
> >
>
> New patch.
>
> Signed-off-by: Martin Berglund <martin@rogsta.net>
Can you please resend this in a format I can apply it in, without
needing to edit the patch body by hand? I deal with thousands of
patches every month, and if I have to edit them all, that cuts down my
ability to apply them greatly.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Staging: sm7xxfb: fixed line break coding style issues
2013-09-27 15:39 ` Martin Berglund
2013-09-27 15:41 ` Greg KH
@ 2013-09-27 15:46 ` Dan Carpenter
1 sibling, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2013-09-27 15:46 UTC (permalink / raw)
To: Martin Berglund; +Cc: teddy.wang, gregkh, wfp5p, devel, linux-kernel
On Fri, Sep 27, 2013 at 05:39:11PM +0200, Martin Berglund wrote:
> On Fri, Sep 27, 2013 at 03:27:29PM +0300, Dan Carpenter wrote:
> > On Fri, Sep 27, 2013 at 02:08:07PM +0200, Martin Berglund wrote:
> > > @@ -508,9 +506,8 @@ static void sm7xx_set_timing(struct smtcfb_info *sfb)
> > >
> > > /* init SEQ register SR30 - SR75 */
> > > for (i = 0; i < SIZE_SR30_SR75; i++)
> > > - if (((i + 0x30) != 0x62) \
> > > - && ((i + 0x30) != 0x6a) \
> > > - && ((i + 0x30) != 0x6b))
> > > + if (((i + 0x30) != 0x62) && ((i + 0x30) != 0x6a)
> > > + && ((i + 0x30) != 0x6b))
> >
> > The prefered way would be to align this like this:
> >
> > if ((i + 0x30) != 0x62 &&
> > (i + 0x30) != 0x6a &&
> > (i + 0x30) != 0x6b)
> >
> > regards,
> > dan carpenter
> >
>
> New patch.
Looks nice, but could you resend it in a way that can be a applied?
Take your original patch and change the subject to:
[PATCH v2] Staging: sm7xxfb: fixed line break coding style issues
Add "v2: minor style change" under the --- line.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-09-27 15:46 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-27 12:08 [PATCH] Staging: sm7xxfb: fixed line break coding style issues Martin Berglund
2013-09-27 12:27 ` Dan Carpenter
2013-09-27 15:39 ` Martin Berglund
2013-09-27 15:41 ` Greg KH
2013-09-27 15:46 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox