* Fix apparent cut-n-paste mistake in Dell reboot workaround.
@ 2013-09-25 0:13 Dave Jones
2013-09-25 7:42 ` [tip:x86/urgent] x86/reboot: " tip-bot for Dave Jones
2013-09-27 20:16 ` H. Peter Anvin
0 siblings, 2 replies; 11+ messages in thread
From: Dave Jones @ 2013-09-25 0:13 UTC (permalink / raw)
To: x86; +Cc: Linux Kernel
This seems to have been copied from the Optiplex 990 entry above, but somoene
forgot to change the ident text.
Signed-off-by: Dave Jones <davej@fedoraproject.org>
diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c
index f6835d8..ea2aaca 100644
--- a/arch/x86/kernel/reboot.c
+++ b/arch/x86/kernel/reboot.c
@@ -360,7 +360,7 @@ static struct dmi_system_id __initdata reboot_dmi_table[] = {
},
{ /* Handle problems with rebooting on the Precision M6600. */
.callback = set_pci_reboot,
- .ident = "Dell OptiPlex 990",
+ .ident = "Dell Precision M6600",
.matches = {
DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
DMI_MATCH(DMI_PRODUCT_NAME, "Precision M6600"),
^ permalink raw reply related [flat|nested] 11+ messages in thread* [tip:x86/urgent] x86/reboot: Fix apparent cut-n-paste mistake in Dell reboot workaround
2013-09-25 0:13 Fix apparent cut-n-paste mistake in Dell reboot workaround Dave Jones
@ 2013-09-25 7:42 ` tip-bot for Dave Jones
2013-09-27 20:16 ` H. Peter Anvin
1 sibling, 0 replies; 11+ messages in thread
From: tip-bot for Dave Jones @ 2013-09-25 7:42 UTC (permalink / raw)
To: linux-tip-commits; +Cc: linux-kernel, hpa, mingo, davej, davej, tglx
Commit-ID: 7a20c2fad61aa3624e83c671d36dbd36b2661476
Gitweb: http://git.kernel.org/tip/7a20c2fad61aa3624e83c671d36dbd36b2661476
Author: Dave Jones <davej@redhat.com>
AuthorDate: Tue, 24 Sep 2013 20:13:44 -0400
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Wed, 25 Sep 2013 08:41:10 +0200
x86/reboot: Fix apparent cut-n-paste mistake in Dell reboot workaround
This seems to have been copied from the Optiplex 990 entry
above, but somoene forgot to change the ident text.
Signed-off-by: Dave Jones <davej@fedoraproject.org>
Link: http://lkml.kernel.org/r/20130925001344.GA13554@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/kernel/reboot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c
index 5f4ad27..e643e74 100644
--- a/arch/x86/kernel/reboot.c
+++ b/arch/x86/kernel/reboot.c
@@ -352,7 +352,7 @@ static struct dmi_system_id __initdata reboot_dmi_table[] = {
},
{ /* Handle problems with rebooting on the Precision M6600. */
.callback = set_pci_reboot,
- .ident = "Dell OptiPlex 990",
+ .ident = "Dell Precision M6600",
.matches = {
DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
DMI_MATCH(DMI_PRODUCT_NAME, "Precision M6600"),
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: Fix apparent cut-n-paste mistake in Dell reboot workaround.
2013-09-25 0:13 Fix apparent cut-n-paste mistake in Dell reboot workaround Dave Jones
2013-09-25 7:42 ` [tip:x86/urgent] x86/reboot: " tip-bot for Dave Jones
@ 2013-09-27 20:16 ` H. Peter Anvin
2013-09-27 20:19 ` Dave Jones
2013-09-30 2:57 ` Matthew Garrett
1 sibling, 2 replies; 11+ messages in thread
From: H. Peter Anvin @ 2013-09-27 20:16 UTC (permalink / raw)
To: Dave Jones, x86, Linux Kernel
On 09/24/2013 07:13 PM, Dave Jones wrote:
> This seems to have been copied from the Optiplex 990 entry above, but somoene
> forgot to change the ident text.
>
> Signed-off-by: Dave Jones <davej@fedoraproject.org>
>
> diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c
> index f6835d8..ea2aaca 100644
> --- a/arch/x86/kernel/reboot.c
> +++ b/arch/x86/kernel/reboot.c
> @@ -360,7 +360,7 @@ static struct dmi_system_id __initdata reboot_dmi_table[] = {
> },
> { /* Handle problems with rebooting on the Precision M6600. */
> .callback = set_pci_reboot,
> - .ident = "Dell OptiPlex 990",
> + .ident = "Dell Precision M6600",
> .matches = {
> DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> DMI_MATCH(DMI_PRODUCT_NAME, "Precision M6600"),
>
It really is starting to feel like *ALL* Dell machines need reboot=pci?
-hpa
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: Fix apparent cut-n-paste mistake in Dell reboot workaround.
2013-09-27 20:16 ` H. Peter Anvin
@ 2013-09-27 20:19 ` Dave Jones
2013-09-27 20:34 ` H. Peter Anvin
2013-09-30 2:57 ` Matthew Garrett
1 sibling, 1 reply; 11+ messages in thread
From: Dave Jones @ 2013-09-27 20:19 UTC (permalink / raw)
To: H. Peter Anvin; +Cc: x86, Linux Kernel
On Fri, Sep 27, 2013 at 03:16:49PM -0500, H. Peter Anvin wrote:
> On 09/24/2013 07:13 PM, Dave Jones wrote:
> > This seems to have been copied from the Optiplex 990 entry above, but somoene
> > forgot to change the ident text.
> >
> > Signed-off-by: Dave Jones <davej@fedoraproject.org>
> >
> > diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c
> > index f6835d8..ea2aaca 100644
> > --- a/arch/x86/kernel/reboot.c
> > +++ b/arch/x86/kernel/reboot.c
> > @@ -360,7 +360,7 @@ static struct dmi_system_id __initdata reboot_dmi_table[] = {
> > },
> > { /* Handle problems with rebooting on the Precision M6600. */
> > .callback = set_pci_reboot,
> > - .ident = "Dell OptiPlex 990",
> > + .ident = "Dell Precision M6600",
> > .matches = {
> > DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> > DMI_MATCH(DMI_PRODUCT_NAME, "Precision M6600"),
> >
>
> It really is starting to feel like *ALL* Dell machines need reboot=pci?
Either that or 'bios'. The question I have is, of those marked 'bios', does =pci
work too ? If we knew that was true, I'd probably say yes.
Dave
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: Fix apparent cut-n-paste mistake in Dell reboot workaround.
2013-09-27 20:16 ` H. Peter Anvin
2013-09-27 20:19 ` Dave Jones
@ 2013-09-30 2:57 ` Matthew Garrett
2013-09-30 2:58 ` H. Peter Anvin
1 sibling, 1 reply; 11+ messages in thread
From: Matthew Garrett @ 2013-09-30 2:57 UTC (permalink / raw)
To: H. Peter Anvin; +Cc: Dave Jones, x86, Linux Kernel
On Fri, Sep 27, 2013 at 03:16:49PM -0500, H. Peter Anvin wrote:
>
> It really is starting to feel like *ALL* Dell machines need reboot=pci?
Now that ACPI is default, I'd be surprised if any of them do.
--
Matthew Garrett | mjg59@srcf.ucam.org
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: Fix apparent cut-n-paste mistake in Dell reboot workaround.
2013-09-30 2:57 ` Matthew Garrett
@ 2013-09-30 2:58 ` H. Peter Anvin
2013-09-30 3:06 ` Matthew Garrett
0 siblings, 1 reply; 11+ messages in thread
From: H. Peter Anvin @ 2013-09-30 2:58 UTC (permalink / raw)
To: Matthew Garrett; +Cc: Dave Jones, x86, Linux Kernel
On 09/29/2013 07:57 PM, Matthew Garrett wrote:
> On Fri, Sep 27, 2013 at 03:16:49PM -0500, H. Peter Anvin wrote:
>>
>> It really is starting to feel like *ALL* Dell machines need reboot=pci?
>
> Now that ACPI is default, I'd be surprised if any of them do.
>
Look at the stream of Dell machines we're still getting reboot bug
reports for...
-hpa
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: Fix apparent cut-n-paste mistake in Dell reboot workaround.
2013-09-30 2:58 ` H. Peter Anvin
@ 2013-09-30 3:06 ` Matthew Garrett
2013-09-30 3:15 ` Dave Airlie
0 siblings, 1 reply; 11+ messages in thread
From: Matthew Garrett @ 2013-09-30 3:06 UTC (permalink / raw)
To: H. Peter Anvin; +Cc: Dave Jones, x86, Linux Kernel
On Sun, Sep 29, 2013 at 07:58:10PM -0700, H. Peter Anvin wrote:
> On 09/29/2013 07:57 PM, Matthew Garrett wrote:
> > On Fri, Sep 27, 2013 at 03:16:49PM -0500, H. Peter Anvin wrote:
> >>
> >> It really is starting to feel like *ALL* Dell machines need reboot=pci?
> >
> > Now that ACPI is default, I'd be surprised if any of them do.
> >
>
> Look at the stream of Dell machines we're still getting reboot bug
> reports for...
Likely indicates that our ACPI reboot handling still isn't bug
compatible with Windows. We'd do better fixing that than adding more DMI
entries.
--
Matthew Garrett | mjg59@srcf.ucam.org
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: Fix apparent cut-n-paste mistake in Dell reboot workaround.
2013-09-30 3:06 ` Matthew Garrett
@ 2013-09-30 3:15 ` Dave Airlie
2013-09-30 4:23 ` H. Peter Anvin
2013-09-30 4:32 ` Matthew Garrett
0 siblings, 2 replies; 11+ messages in thread
From: Dave Airlie @ 2013-09-30 3:15 UTC (permalink / raw)
To: Matthew Garrett; +Cc: H. Peter Anvin, Dave Jones, x86, Linux Kernel
On Mon, Sep 30, 2013 at 1:06 PM, Matthew Garrett <mjg59@srcf.ucam.org> wrote:
> On Sun, Sep 29, 2013 at 07:58:10PM -0700, H. Peter Anvin wrote:
>> On 09/29/2013 07:57 PM, Matthew Garrett wrote:
>> > On Fri, Sep 27, 2013 at 03:16:49PM -0500, H. Peter Anvin wrote:
>> >>
>> >> It really is starting to feel like *ALL* Dell machines need reboot=pci?
>> >
>> > Now that ACPI is default, I'd be surprised if any of them do.
>> >
>>
>> Look at the stream of Dell machines we're still getting reboot bug
>> reports for...
>
> Likely indicates that our ACPI reboot handling still isn't bug
> compatible with Windows. We'd do better fixing that than adding more DMI
> entries.
are these only with VTd enabled? I have some Dells that won't reboot
with VTd turned on, I remember you though it was an acpi bug we
couldn't do much with.
Dave.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: Fix apparent cut-n-paste mistake in Dell reboot workaround.
2013-09-30 3:15 ` Dave Airlie
@ 2013-09-30 4:23 ` H. Peter Anvin
2013-09-30 4:32 ` Matthew Garrett
1 sibling, 0 replies; 11+ messages in thread
From: H. Peter Anvin @ 2013-09-30 4:23 UTC (permalink / raw)
To: Dave Airlie; +Cc: Matthew Garrett, Dave Jones, x86, Linux Kernel
On 09/29/2013 08:15 PM, Dave Airlie wrote:
>>
>> Likely indicates that our ACPI reboot handling still isn't bug
>> compatible with Windows. We'd do better fixing that than adding more DMI
>> entries.
>
> are these only with VTd enabled? I have some Dells that won't reboot
> with VTd turned on, I remember you though it was an acpi bug we
> couldn't do much with.
>
It would be very interesting to know what the heck the ACPI reset port
is set to in these machines.
-hpa
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: Fix apparent cut-n-paste mistake in Dell reboot workaround.
2013-09-30 3:15 ` Dave Airlie
2013-09-30 4:23 ` H. Peter Anvin
@ 2013-09-30 4:32 ` Matthew Garrett
1 sibling, 0 replies; 11+ messages in thread
From: Matthew Garrett @ 2013-09-30 4:32 UTC (permalink / raw)
To: Dave Airlie; +Cc: H. Peter Anvin, Dave Jones, x86, Linux Kernel
On Mon, Sep 30, 2013 at 01:15:02PM +1000, Dave Airlie wrote:
> On Mon, Sep 30, 2013 at 1:06 PM, Matthew Garrett <mjg59@srcf.ucam.org> wrote:
> > Likely indicates that our ACPI reboot handling still isn't bug
> > compatible with Windows. We'd do better fixing that than adding more DMI
> > entries.
>
> are these only with VTd enabled? I have some Dells that won't reboot
> with VTd turned on, I remember you though it was an acpi bug we
> couldn't do much with.
Oh, that's true - the ACPI reboot vector on the Dell tables I have to
hand appears to be via the keyboard controller, so there's probably some
SMM involved. I don't know if the VTd thing is still a problem (David
Woodhouse was looking into that at one point), but that would be a
reasonable point to start from.
--
Matthew Garrett | mjg59@srcf.ucam.org
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2013-09-30 4:32 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-25 0:13 Fix apparent cut-n-paste mistake in Dell reboot workaround Dave Jones
2013-09-25 7:42 ` [tip:x86/urgent] x86/reboot: " tip-bot for Dave Jones
2013-09-27 20:16 ` H. Peter Anvin
2013-09-27 20:19 ` Dave Jones
2013-09-27 20:34 ` H. Peter Anvin
2013-09-30 2:57 ` Matthew Garrett
2013-09-30 2:58 ` H. Peter Anvin
2013-09-30 3:06 ` Matthew Garrett
2013-09-30 3:15 ` Dave Airlie
2013-09-30 4:23 ` H. Peter Anvin
2013-09-30 4:32 ` Matthew Garrett
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox