From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Chanwoo Choi <cw00.choi@samsung.com>
Cc: myungjoo.ham@samsung.com, broonie@kernel.org,
patches@opensource.wolfsonmicro.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] extcon: arizona: Get pdata from arizona structure not device
Date: Mon, 30 Sep 2013 10:52:02 +0100 [thread overview]
Message-ID: <20130930095202.GY3635@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <5248B9BA.9020003@samsung.com>
On Mon, Sep 30, 2013 at 08:37:30AM +0900, Chanwoo Choi wrote:
> No, extcon-arizona driver don't currently support DT to get platform data.
> I cannot find some dt function to parse data from dts file.
> You have to implement extcon-arizona driver by using DT binding style
> to get platform data. I think this patch is not necessary.
Currently the Arizona MFD driver reads the device tree
information and populates the pdata structure, this happens in
drivers/mfd/arizona-core.c. Then the various drivers just use the
pdata as normal.
Admittedly, at the moment we don't parse any data for the extcon
driver but without this patch we will attempt to use a NULL
pointer on device tree systems.
I would also be happy to implement this as a NULL check on the
pdata when we use it if that is preferable? But since we have the
cached pdata seems we might as well use it.
Thanks,
Charles
next prev parent reply other threads:[~2013-09-30 9:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-28 14:34 [PATCH] extcon: arizona: Get pdata from arizona structure not device Charles Keepax
2013-09-29 23:37 ` Chanwoo Choi
2013-09-30 9:52 ` Charles Keepax [this message]
2013-09-30 23:04 ` Chanwoo Choi
2013-09-30 23:14 ` Chanwoo Choi
2013-09-30 23:27 ` Mark Brown
2013-09-30 23:25 ` Mark Brown
2013-10-01 8:22 ` Charles Keepax
2013-10-01 8:33 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130930095202.GY3635@opensource.wolfsonmicro.com \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=broonie@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox