public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: linux-kernel@vger.kernel.org, acme@infradead.org,
	mingo@kernel.org, peterz@infradead.org, eranian@google.com
Subject: Re: perf, x86: Add last TSX PMU code for Haswell v2
Date: Mon, 30 Sep 2013 22:17:21 +0200	[thread overview]
Message-ID: <20130930201721.GA1079@krava> (raw)
In-Reply-To: <1379688044-14173-1-git-send-email-andi@firstfloor.org>

On Fri, Sep 20, 2013 at 07:40:38AM -0700, Andi Kleen wrote:
> [This has kernel and user parts, so will need
> review/ack/merges from both perf kernel and user land maintainers]
> [v2: Address Peter's feedback for the kernel parts]
> 
> This is currently the last part of the TSX PMU code,
> just adding the left over bits:
> 
> This adds some changes to the user interfaces.
> I'll send patches for the manpage separately.
> 
> - Report the transaction abort flags to user space
> using a new field, and add the code to display them.
> This is used to classify abort types, also fairly
> important for tuning as it guides the tuning process,
> together with the abort weight that was added earleir.
> 
> [3 patches, generic, x86, user tools]
> 
> - Add support for reporting the two new TSX LBR flags: in_tx
> and abort_tx. The code to handle the LBRs was already
> added earlier, this just adds the code to report,
> filter and display them.

perf tool changes look ok

Reviewed-by: Jiri Olsa <jolsa@redhat.com>

btw, kernel changes didn't apply cleanly on tip tree for me
last week.. I couldn't test on Haswel, but I at least tried
your changes with no data and all seem ok ;-)

jirka

  parent reply	other threads:[~2013-09-30 20:18 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-20 14:40 perf, x86: Add last TSX PMU code for Haswell v2 Andi Kleen
2013-09-20 14:40 ` [PATCH 1/6] perf, core: Add generic transaction flags v5 Andi Kleen
2013-10-04 17:32   ` [tip:perf/core] perf: Add generic transaction flags tip-bot for Andi Kleen
2013-12-13 20:31     ` Vince Weaver
2013-12-13 20:38       ` Andi Kleen
2013-12-13 20:52         ` [patch] perf properly document the new transaction sample type Vince Weaver
2013-12-13 21:04           ` Peter Zijlstra
2013-12-18 10:31           ` [tip:perf/urgent] perf: Document " tip-bot for Vince Weaver
2013-09-20 14:40 ` [PATCH 2/6] perf, x86: Add Haswell specific transaction flag reporting v5 Andi Kleen
2013-10-04 17:32   ` [tip:perf/core] perf/x86: Add Haswell specific transaction flag reporting tip-bot for Andi Kleen
2013-09-20 14:40 ` [PATCH 3/6] perf, tools: Support sorting by in_tx, abort branch flags v3 Andi Kleen
2013-10-04 17:32   ` [tip:perf/core] tools/perf: Support sorting by in_tx or abort branch flags tip-bot for Andi Kleen
2013-09-20 14:40 ` [PATCH 4/6] perf, tools: Add abort_tx,no_tx,in_tx branch filter options to perf record -j v3 Andi Kleen
2013-10-04 17:32   ` [tip:perf/core] tools/perf/record: Add abort_tx,no_tx, in_tx branch filter options to perf record -j tip-bot for Andi Kleen
2013-09-20 14:40 ` [PATCH 5/6] perf, tools: Add support for record transaction flags v5 Andi Kleen
2013-10-04 17:33   ` [tip:perf/core] tools/perf: Add support for record transaction flags tip-bot for Andi Kleen
2013-09-20 14:40 ` [PATCH 6/6] perf, x86: Suppress duplicated abort LBR records v2 Andi Kleen
2013-10-04 17:33   ` [tip:perf/core] perf/x86: Suppress duplicated abort LBR records tip-bot for Andi Kleen
2013-09-26 16:34 ` perf, x86: Add last TSX PMU code for Haswell v2 Jiri Olsa
2013-09-30 20:17 ` Jiri Olsa [this message]
2013-09-30 20:26   ` Jiri Olsa
2013-09-30 20:30     ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130930201721.GA1079@krava \
    --to=jolsa@redhat.com \
    --cc=acme@infradead.org \
    --cc=andi@firstfloor.org \
    --cc=eranian@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox