From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755425Ab3JABim (ORCPT ); Mon, 30 Sep 2013 21:38:42 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:44019 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754816Ab3JABil (ORCPT ); Mon, 30 Sep 2013 21:38:41 -0400 Date: Mon, 30 Sep 2013 18:38:44 -0700 From: Greg Kroah-Hartman To: Jesper Juhl Cc: Forest Bond , Joe Perches , Hema Prathaban , Peter P Waskiewicz Jr , "David S. Miller" , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: vt6655: don't leak when returning -EOPNOTSUPP in vt6655_hostap_ioctl Message-ID: <20131001013844.GA28118@kroah.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 30, 2013 at 10:22:11PM +0200, Jesper Juhl wrote: > Make sure we always free(param); and remove a redundant "goto out;" > just before we'll hit the label anyway. > > Signed-off-by: Jesper Juhl > --- > drivers/staging/vt6655/hostap.c | 25 ++++++++++--------------- > 1 files changed, 10 insertions(+), 15 deletions(-) Applied, thanks. greg k-h