* [BUG] Regression in 2fdac010 drivers/net/ethernet/via/via-velocity.c: update napi implementation
@ 2013-09-30 7:15 Ruslan N. Marchenko
2013-09-30 11:43 ` Julia Lawall
2013-09-30 11:54 ` Julia Lawall
0 siblings, 2 replies; 6+ messages in thread
From: Ruslan N. Marchenko @ 2013-09-30 7:15 UTC (permalink / raw)
To: linux-kernel; +Cc: Julia Lawall
Hi Julia et al.,
With this commit VIA NANO board get CPU lockup in random places on any network activity.
The error is random, most of the times dead locked CPU on boot.
After loading via-velocity module it hangs for a while and then spits kernel mesages
about hanged tasks from varios places - like ata, rcu_preempt or network stack.
Also, if you boot the box with network disconnected - it works, until you plug the network cable.
On some kernel builds (like ubuntu stock) behaviour varies, sometimes the box itself works,
but network stack dies after multiple ICMPv6 skb errors, so box ends up with network disconnected.
Reloading network susbsys helps to recover for some time (depending on how fast eth led is blinking).
Reverting the patch allows me to boot without problems even from latest Linus trunk and send this mail.
Regards,
Ruslan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [BUG] Regression in 2fdac010 drivers/net/ethernet/via/via-velocity.c: update napi implementation
2013-09-30 7:15 [BUG] Regression in 2fdac010 drivers/net/ethernet/via/via-velocity.c: update napi implementation Ruslan N. Marchenko
@ 2013-09-30 11:43 ` Julia Lawall
2013-10-01 22:45 ` Francois Romieu
2013-09-30 11:54 ` Julia Lawall
1 sibling, 1 reply; 6+ messages in thread
From: Julia Lawall @ 2013-09-30 11:43 UTC (permalink / raw)
To: Ruslan N. Marchenko; +Cc: linux-kernel
On Mon, 30 Sep 2013, Ruslan N. Marchenko wrote:
> Hi Julia et al.,
>
> With this commit VIA NANO board get CPU lockup in random places on any network activity.
> The error is random, most of the times dead locked CPU on boot.
>
> After loading via-velocity module it hangs for a while and then spits kernel mesages
> about hanged tasks from varios places - like ata, rcu_preempt or network stack.
> Also, if you boot the box with network disconnected - it works, until you plug the network cable.
>
> On some kernel builds (like ubuntu stock) behaviour varies, sometimes the box itself works,
> but network stack dies after multiple ICMPv6 skb errors, so box ends up with network disconnected.
> Reloading network susbsys helps to recover for some time (depending on how fast eth led is blinking).
>
> Reverting the patch allows me to boot without problems even from latest Linus trunk and send this mail.
There has already been a discussion about this, and a patch has already
been proposed. It has to do with lock managament. I will look for the
email.
julia
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [BUG] Regression in 2fdac010 drivers/net/ethernet/via/via-velocity.c: update napi implementation
2013-09-30 7:15 [BUG] Regression in 2fdac010 drivers/net/ethernet/via/via-velocity.c: update napi implementation Ruslan N. Marchenko
2013-09-30 11:43 ` Julia Lawall
@ 2013-09-30 11:54 ` Julia Lawall
2013-09-30 13:54 ` Ruslan N. Marchenko
1 sibling, 1 reply; 6+ messages in thread
From: Julia Lawall @ 2013-09-30 11:54 UTC (permalink / raw)
To: Ruslan N. Marchenko; +Cc: linux-kernel, Julia Lawall
On Mon, 30 Sep 2013, Ruslan N. Marchenko wrote:
> Hi Julia et al.,
>
> With this commit VIA NANO board get CPU lockup in random places on any network activity.
> The error is random, most of the times dead locked CPU on boot.
>
> After loading via-velocity module it hangs for a while and then spits kernel mesages
> about hanged tasks from varios places - like ata, rcu_preempt or network stack.
> Also, if you boot the box with network disconnected - it works, until you plug the network cable.
>
> On some kernel builds (like ubuntu stock) behaviour varies, sometimes the box itself works,
> but network stack dies after multiple ICMPv6 skb errors, so box ends up with network disconnected.
> Reloading network susbsys helps to recover for some time (depending on how fast eth led is blinking).
>
> Reverting the patch allows me to boot without problems even from latest Linus trunk and send this mail.
You can find the discussion and improved patch in this thread:
http://www.spinics.net/lists/netdev/msg251287.html
Bug - regression - Via velocity interface coming up freezes kernel
From: Dirk Kraft <dirk.kraft@xxxxxxxxx>
Date: Sun, 22 Sep 2013 19:28:52 +0200
julia
>
> Regards,
> Ruslan
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [BUG] Regression in 2fdac010 drivers/net/ethernet/via/via-velocity.c: update napi implementation
2013-09-30 11:54 ` Julia Lawall
@ 2013-09-30 13:54 ` Ruslan N. Marchenko
2013-10-01 6:29 ` Ruslan N. Marchenko
0 siblings, 1 reply; 6+ messages in thread
From: Ruslan N. Marchenko @ 2013-09-30 13:54 UTC (permalink / raw)
To: Julia Lawall; +Cc: linux-kernel
On Mon, Sep 30, 2013 at 01:54:06PM +0200, Julia Lawall wrote:
> On Mon, 30 Sep 2013, Ruslan N. Marchenko wrote:
>
> > Hi Julia et al.,
> >
> > With this commit VIA NANO board get CPU lockup in random places on any network activity.
> > The error is random, most of the times dead locked CPU on boot.
> >
> > After loading via-velocity module it hangs for a while and then spits kernel mesages
> > about hanged tasks from varios places - like ata, rcu_preempt or network stack.
> > Also, if you boot the box with network disconnected - it works, until you plug the network cable.
> >
> > On some kernel builds (like ubuntu stock) behaviour varies, sometimes the box itself works,
> > but network stack dies after multiple ICMPv6 skb errors, so box ends up with network disconnected.
> > Reloading network susbsys helps to recover for some time (depending on how fast eth led is blinking).
> >
> > Reverting the patch allows me to boot without problems even from latest Linus trunk and send this mail.
>
> You can find the discussion and improved patch in this thread:
>
> http://www.spinics.net/lists/netdev/msg251287.html
> Bug - regression - Via velocity interface coming up freezes kernel
> From: Dirk Kraft <dirk.kraft@xxxxxxxxx>
> Date: Sun, 22 Sep 2013 19:28:52 +0200
>
> julia
Oops, sorry, somehow I missed it even though 've been searching for via-velocity regression.
Will give a try to new proposed patch as well.
Thanks,
Ruslan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [BUG] Regression in 2fdac010 drivers/net/ethernet/via/via-velocity.c: update napi implementation
2013-09-30 13:54 ` Ruslan N. Marchenko
@ 2013-10-01 6:29 ` Ruslan N. Marchenko
0 siblings, 0 replies; 6+ messages in thread
From: Ruslan N. Marchenko @ 2013-10-01 6:29 UTC (permalink / raw)
To: Julia Lawall, linux-kernel
On Mon, Sep 30, 2013 at 03:54:27PM +0200, Ruslan N. Marchenko wrote:
> On Mon, Sep 30, 2013 at 01:54:06PM +0200, Julia Lawall wrote:
> > On Mon, 30 Sep 2013, Ruslan N. Marchenko wrote:
> >
> > > Hi Julia et al.,
> > >
> > > With this commit VIA NANO board get CPU lockup in random places on any network activity.
> > > .
> > > Reverting the patch allows me to boot without problems even from latest Linus trunk and send this mail.
> >
> > You can find the discussion and improved patch in this thread:
> >
> > http://www.spinics.net/lists/netdev/msg251287.html
> > Bug - regression - Via velocity interface coming up freezes kernel
> > From: Dirk Kraft <dirk.kraft@xxxxxxxxx>
> > Date: Sun, 22 Sep 2013 19:28:52 +0200
> >
> > julia
>
> Oops, sorry, somehow I missed it even though 've been searching for via-velocity regression.
> Will give a try to new proposed patch as well.
>
and short confirmation adding patch from Francois Romieu works on current -rc3+
Regards,
Ruslan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [BUG] Regression in 2fdac010 drivers/net/ethernet/via/via-velocity.c: update napi implementation
2013-09-30 11:43 ` Julia Lawall
@ 2013-10-01 22:45 ` Francois Romieu
0 siblings, 0 replies; 6+ messages in thread
From: Francois Romieu @ 2013-10-01 22:45 UTC (permalink / raw)
To: Julia Lawall; +Cc: Ruslan N. Marchenko, linux-kernel
Julia Lawall <julia.lawall@lip6.fr> :
[...]
> There has already been a discussion about this, and a patch has already
> been proposed. It has to do with lock managament. I will look for the
> email.
The underlying problem has to do with disabled irq. netif_receive_skb
assumes irq to be enabled. Current via-velocity poll() method should
narrow its (spinlocked) irq disabled section.
What I've done should not require much analysis (aka "what could race
with the rx bh processing in a napi driver ?") and avoids a more intrusive
lockless napi design.
--
Ueimor
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-10-01 22:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-30 7:15 [BUG] Regression in 2fdac010 drivers/net/ethernet/via/via-velocity.c: update napi implementation Ruslan N. Marchenko
2013-09-30 11:43 ` Julia Lawall
2013-10-01 22:45 ` Francois Romieu
2013-09-30 11:54 ` Julia Lawall
2013-09-30 13:54 ` Ruslan N. Marchenko
2013-10-01 6:29 ` Ruslan N. Marchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox