* [PATCH] x86/geode: fix incorrect placement of __initdata tag
@ 2013-09-30 13:21 Bartlomiej Zolnierkiewicz
2013-10-01 6:59 ` Ingo Molnar
2013-10-01 13:00 ` [tip:x86/platform] x86/geode: Fix " tip-bot for Bartlomiej Zolnierkiewicz
0 siblings, 2 replies; 4+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2013-09-30 13:21 UTC (permalink / raw)
To: Thomas Gleixner
Cc: Ingo Molnar, H. Peter Anvin, x86, linux-kernel, Kyungmin Park
__initdata tag should be placed between the variable name and equal
sign for the variable to be placed in the intended .init.data section.
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
arch/x86/platform/geode/alix.c | 2 +-
arch/x86/platform/geode/geos.c | 2 +-
arch/x86/platform/geode/net5501.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/x86/platform/geode/alix.c b/arch/x86/platform/geode/alix.c
index 90e23e7..76b6632 100644
--- a/arch/x86/platform/geode/alix.c
+++ b/arch/x86/platform/geode/alix.c
@@ -98,7 +98,7 @@ static struct platform_device alix_leds_dev = {
.dev.platform_data = &alix_leds_data,
};
-static struct __initdata platform_device *alix_devs[] = {
+static struct platform_device *alix_devs[] __initdata = {
&alix_buttons_dev,
&alix_leds_dev,
};
diff --git a/arch/x86/platform/geode/geos.c b/arch/x86/platform/geode/geos.c
index c2e6d53..aa733fb 100644
--- a/arch/x86/platform/geode/geos.c
+++ b/arch/x86/platform/geode/geos.c
@@ -87,7 +87,7 @@ static struct platform_device geos_leds_dev = {
.dev.platform_data = &geos_leds_data,
};
-static struct __initdata platform_device *geos_devs[] = {
+static struct platform_device *geos_devs[] __initdata = {
&geos_buttons_dev,
&geos_leds_dev,
};
diff --git a/arch/x86/platform/geode/net5501.c b/arch/x86/platform/geode/net5501.c
index 646e3b5..927e38c 100644
--- a/arch/x86/platform/geode/net5501.c
+++ b/arch/x86/platform/geode/net5501.c
@@ -78,7 +78,7 @@ static struct platform_device net5501_leds_dev = {
.dev.platform_data = &net5501_leds_data,
};
-static struct __initdata platform_device *net5501_devs[] = {
+static struct platform_device *net5501_devs[] __initdata = {
&net5501_buttons_dev,
&net5501_leds_dev,
};
--
1.8.2.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] x86/geode: fix incorrect placement of __initdata tag
2013-09-30 13:21 [PATCH] x86/geode: fix incorrect placement of __initdata tag Bartlomiej Zolnierkiewicz
@ 2013-10-01 6:59 ` Ingo Molnar
2013-10-01 10:37 ` Bartlomiej Zolnierkiewicz
2013-10-01 13:00 ` [tip:x86/platform] x86/geode: Fix " tip-bot for Bartlomiej Zolnierkiewicz
1 sibling, 1 reply; 4+ messages in thread
From: Ingo Molnar @ 2013-10-01 6:59 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz
Cc: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, x86, linux-kernel,
Kyungmin Park
* Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> wrote:
> __initdata tag should be placed between the variable name and equal
> sign for the variable to be placed in the intended .init.data section.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> arch/x86/platform/geode/alix.c | 2 +-
> arch/x86/platform/geode/geos.c | 2 +-
> arch/x86/platform/geode/net5501.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
Does this fix have any runtime effects, i.e. should we queue this up as an
urgent fix for v3.12, or does tip:x86/platform with a v3.13 merge suffice?
Thanks,
ingo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86/geode: fix incorrect placement of __initdata tag
2013-10-01 6:59 ` Ingo Molnar
@ 2013-10-01 10:37 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 4+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2013-10-01 10:37 UTC (permalink / raw)
To: Ingo Molnar
Cc: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, x86, linux-kernel,
Kyungmin Park
Hi,
On Tuesday, October 01, 2013 08:59:50 AM Ingo Molnar wrote:
>
> * Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> wrote:
>
> > __initdata tag should be placed between the variable name and equal
> > sign for the variable to be placed in the intended .init.data section.
> >
> > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> > ---
> > arch/x86/platform/geode/alix.c | 2 +-
> > arch/x86/platform/geode/geos.c | 2 +-
> > arch/x86/platform/geode/net5501.c | 2 +-
> > 3 files changed, 3 insertions(+), 3 deletions(-)
>
> Does this fix have any runtime effects, i.e. should we queue this up as an
> urgent fix for v3.12, or does tip:x86/platform with a v3.13 merge suffice?
It has runtime effects as the data now goes into .init.data which was not
a case previously. However it is not an urgent fix so I think that queuing
it for v3.13 is a better option. Thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 4+ messages in thread
* [tip:x86/platform] x86/geode: Fix incorrect placement of __initdata tag
2013-09-30 13:21 [PATCH] x86/geode: fix incorrect placement of __initdata tag Bartlomiej Zolnierkiewicz
2013-10-01 6:59 ` Ingo Molnar
@ 2013-10-01 13:00 ` tip-bot for Bartlomiej Zolnierkiewicz
1 sibling, 0 replies; 4+ messages in thread
From: tip-bot for Bartlomiej Zolnierkiewicz @ 2013-10-01 13:00 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, hpa, mingo, b.zolnierkie, tglx, kyungmin.park
Commit-ID: a6d30e0fffb32ab9e48fa7fc8f463805d5b0bddb
Gitweb: http://git.kernel.org/tip/a6d30e0fffb32ab9e48fa7fc8f463805d5b0bddb
Author: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
AuthorDate: Mon, 30 Sep 2013 15:21:15 +0200
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Tue, 1 Oct 2013 13:21:27 +0200
x86/geode: Fix incorrect placement of __initdata tag
__initdata tag should be placed between the variable name and
equal sign for the variable to be placed in the intended
.init.data section.
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Link: http://lkml.kernel.org/r/18427893.G5JGWn465D@amdc1032
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/platform/geode/alix.c | 2 +-
arch/x86/platform/geode/geos.c | 2 +-
arch/x86/platform/geode/net5501.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/x86/platform/geode/alix.c b/arch/x86/platform/geode/alix.c
index 90e23e7..76b6632 100644
--- a/arch/x86/platform/geode/alix.c
+++ b/arch/x86/platform/geode/alix.c
@@ -98,7 +98,7 @@ static struct platform_device alix_leds_dev = {
.dev.platform_data = &alix_leds_data,
};
-static struct __initdata platform_device *alix_devs[] = {
+static struct platform_device *alix_devs[] __initdata = {
&alix_buttons_dev,
&alix_leds_dev,
};
diff --git a/arch/x86/platform/geode/geos.c b/arch/x86/platform/geode/geos.c
index c2e6d53..aa733fb 100644
--- a/arch/x86/platform/geode/geos.c
+++ b/arch/x86/platform/geode/geos.c
@@ -87,7 +87,7 @@ static struct platform_device geos_leds_dev = {
.dev.platform_data = &geos_leds_data,
};
-static struct __initdata platform_device *geos_devs[] = {
+static struct platform_device *geos_devs[] __initdata = {
&geos_buttons_dev,
&geos_leds_dev,
};
diff --git a/arch/x86/platform/geode/net5501.c b/arch/x86/platform/geode/net5501.c
index 646e3b5..927e38c 100644
--- a/arch/x86/platform/geode/net5501.c
+++ b/arch/x86/platform/geode/net5501.c
@@ -78,7 +78,7 @@ static struct platform_device net5501_leds_dev = {
.dev.platform_data = &net5501_leds_data,
};
-static struct __initdata platform_device *net5501_devs[] = {
+static struct platform_device *net5501_devs[] __initdata = {
&net5501_buttons_dev,
&net5501_leds_dev,
};
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-10-01 13:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-30 13:21 [PATCH] x86/geode: fix incorrect placement of __initdata tag Bartlomiej Zolnierkiewicz
2013-10-01 6:59 ` Ingo Molnar
2013-10-01 10:37 ` Bartlomiej Zolnierkiewicz
2013-10-01 13:00 ` [tip:x86/platform] x86/geode: Fix " tip-bot for Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox