From: Ben Myers <bpm@sgi.com>
To: Mark Tinguely <tinguely@sgi.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Alex Elder <elder@kernel.org>,
linux-kernel@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: Use kmem_free() instead of free()
Date: Tue, 1 Oct 2013 10:22:54 -0500 [thread overview]
Message-ID: <20131001152254.GM10553@sgi.com> (raw)
In-Reply-To: <524AE39B.3040505@sgi.com>
On Tue, Oct 01, 2013 at 10:00:43AM -0500, Mark Tinguely wrote:
> On 10/01/13 09:47, Thierry Reding wrote:
> >This fixes a build failure caused by calling the free() function which
> >does not exist in the Linux kernel.
> >
> >Signed-off-by: Thierry Reding<treding@nvidia.com>
> >---
> > fs/xfs/xfs_log_recover.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/fs/xfs/xfs_log_recover.c b/fs/xfs/xfs_log_recover.c
> >index 4324058..3979749 100644
> >--- a/fs/xfs/xfs_log_recover.c
> >+++ b/fs/xfs/xfs_log_recover.c
> >@@ -1585,7 +1585,7 @@ xlog_recover_add_to_trans(
> > "bad number of regions (%d) in inode log format",
> > in_f->ilf_size);
> > ASSERT(0);
> >- free(ptr);
> >+ kmem_free(ptr);
> > return XFS_ERROR(EIO);
> > }
> >
>
> Looks good. I will remove the other list items in another patch.
>
> Reviewed-by: Mark Tinguely <tinguely@sgi.com>
Gah. Build Fail. Apparently things were getting a little punchy over here.
Applied, and thanks Thierry.
-Ben
prev parent reply other threads:[~2013-10-01 15:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-01 14:47 [PATCH] xfs: Use kmem_free() instead of free() Thierry Reding
2013-10-01 15:00 ` Mark Tinguely
2013-10-01 15:22 ` Ben Myers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131001152254.GM10553@sgi.com \
--to=bpm@sgi.com \
--cc=elder@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=tinguely@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox