* [PATCH] perf, tools: Fix sorting for 64bit entries
@ 2013-09-27 23:39 Andi Kleen
2013-09-30 7:48 ` Namhyung Kim
2013-10-01 17:00 ` Arnaldo Carvalho de Melo
0 siblings, 2 replies; 3+ messages in thread
From: Andi Kleen @ 2013-09-27 23:39 UTC (permalink / raw)
To: acme; +Cc: jolsa, eranian, linux-kernel, namhyung.kim, Andi Kleen
From: Andi Kleen <ak@linux.intel.com>
Some of the node comparisons in hist.c dropped the upper
32bit by using an int variable to store the compare
result. This broke various 64bit fields, causing
incorrect collapsing (found for the TSX transaction field)
Just use int64_t always.
Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
tools/perf/util/hist.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c
index 4714a72..4832b59 100644
--- a/tools/perf/util/hist.c
+++ b/tools/perf/util/hist.c
@@ -350,7 +350,7 @@ static struct hist_entry *add_hist_entry(struct hists *hists,
struct rb_node **p;
struct rb_node *parent = NULL;
struct hist_entry *he;
- int cmp;
+ int64_t cmp;
p = &hists->entries_in->rb_node;
@@ -887,7 +887,7 @@ static struct hist_entry *hists__add_dummy_entry(struct hists *hists,
struct rb_node **p;
struct rb_node *parent = NULL;
struct hist_entry *he;
- int cmp;
+ int64_t cmp;
if (sort__need_collapse)
root = &hists->entries_collapsed;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] perf, tools: Fix sorting for 64bit entries
2013-09-27 23:39 [PATCH] perf, tools: Fix sorting for 64bit entries Andi Kleen
@ 2013-09-30 7:48 ` Namhyung Kim
2013-10-01 17:00 ` Arnaldo Carvalho de Melo
1 sibling, 0 replies; 3+ messages in thread
From: Namhyung Kim @ 2013-09-30 7:48 UTC (permalink / raw)
To: Andi Kleen; +Cc: acme, jolsa, eranian, linux-kernel, namhyung.kim, Andi Kleen
Hi Andi,
On Fri, 27 Sep 2013 16:39:24 -0700, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
>
> Some of the node comparisons in hist.c dropped the upper
> 32bit by using an int variable to store the compare
> result. This broke various 64bit fields, causing
> incorrect collapsing (found for the TSX transaction field)
>
> Just use int64_t always.
Acked-by: Namhyung Kim <namhyung@kernel.org>
Thanks,
Namhyung
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] perf, tools: Fix sorting for 64bit entries
2013-09-27 23:39 [PATCH] perf, tools: Fix sorting for 64bit entries Andi Kleen
2013-09-30 7:48 ` Namhyung Kim
@ 2013-10-01 17:00 ` Arnaldo Carvalho de Melo
1 sibling, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2013-10-01 17:00 UTC (permalink / raw)
To: Andi Kleen; +Cc: jolsa, eranian, linux-kernel, namhyung.kim, Andi Kleen
Em Fri, Sep 27, 2013 at 04:39:24PM -0700, Andi Kleen escreveu:
> From: Andi Kleen <ak@linux.intel.com>
>
> Some of the node comparisons in hist.c dropped the upper
> 32bit by using an int variable to store the compare
> result. This broke various 64bit fields, causing
> incorrect collapsing (found for the TSX transaction field)
>
> Just use int64_t always.
Thanks, applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-10-01 17:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-27 23:39 [PATCH] perf, tools: Fix sorting for 64bit entries Andi Kleen
2013-09-30 7:48 ` Namhyung Kim
2013-10-01 17:00 ` Arnaldo Carvalho de Melo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox