Re: [PATCH 2/3] hwrng: Add a driver for the hwrng found in power7+ systems

Michael Ellerman
2013-10-01T08:25:55Z

On Thu, Sep 26, 2013 at 06:01:27PM +1000, Benjamin Herrenschmidt wrote:
> On Thu, 2013-09-26 at 16:31 +1000, Michael Ellerman wrote:
>
> > + pr_info("registered powernv hwrng.\n");
>
> First letter of a line should get a capital :-) Also since
> it's per-device, at least indicate the OF path or the chip number or
> something ...

It's not the first letter, it looks like this:

powernv-rng: registered powernv hwrng.

Which looks nice to me, but I can make it this if you prefer:

powernv-rng: Registered powernv hwrng.

And it's not per-device due to the trick in the probe routine. It's a
bit sneaky but we need to make it a proper driver for module loading to
work, but we only want to register one hwrng device.

cheers