Re: [PATCH -v2] EFI: Runtime services virtual mapping

Dave Young
2013-10-08T09:19:14Z

Sorry for reply late because I was in a long holiday...

On 09/30/13 at 10:17pm, Borislav Petkov wrote:
> On Thu, Sep 26, 2013 at 11:12:42AM +0800, Dave Young wrote:
> > If we choose this approach, can we save not only the efi_mapping, but
> > also the fields which will be converted to virt addr, like fw_vendor,
> > runtime, tables? During my test on a HP workstation, the config table
> > item (SMBIOS) also is converted to virt addr though spec only mention
> > fw_vendor/runtime/tables.
>
> Btw, I was about to ask: how do you pass boot_params to the kexec
> kernel?

As Vivek mentioned, just kexec-tools will get the saved info from sysfs
or procfs, then it as a boot loader will prepare the linux boot setup
struct with these 1st efi values.

>
> Because I'm looking into hpa's idea to pass an efi_mapping array of
> regions with setup_data but how does this get passed to the kexec'ed
> kernel? I see in your patches you have boot_params.saved_*** for the
> needed info but you're not writing to them anywhere. Is that why you've
> added them to the systab_show function so that userspace can parse it
> and build the boot_params thing?

Yes, I just printed them in systab_show, kexec-tools will parse it.

>
> Thanks.
>
> --
> Regards/Gruss,
> Boris.
>
> Sent from a fat crate under my desk. Formatting is fine.
> --